From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id aa7c8fb4 for ; Thu, 27 Feb 2020 13:23:12 +0000 (UTC) Received: (qmail 23094 invoked by alias); 27 Feb 2020 13:23:07 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45495 Received: (qmail 22902 invoked by uid 1010); 27 Feb 2020 13:23:07 -0000 X-Qmail-Scanner-Diagnostics: from wout5-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25731. spamassassin: 3.4.2. Clear:RC:0(64.147.123.21):SA:0(-2.6/5.0):. Processed in 0.767684 secs); 27 Feb 2020 13:23:07 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrleeigdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfgjfhfogggtgfesthhqtd dtredtjeenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghnihgv lhdrshhhrghhrghfrdhnrghmvgeqnecukfhppeejledrudejkedrjedrudekleenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghn ihgvlhdrshhhrghhrghfrdhnrghmvg X-ME-Proxy: Date: Thu, 27 Feb 2020 13:22:29 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin Message-ID: <20200227132229.3e290918@tarpaulin.shahaf.local2> In-Reply-To: <321F9465-ABF9-465D-9242-7EF9A0EDDBED@kba.biglobe.ne.jp> References: <82F8CDE0-C95C-4D31-ABFC-EBB3C97799F3@kba.biglobe.ne.jp> <1B509B1C-A670-482F-9D88-2145E15D03A1@kba.biglobe.ne.jp> <20200109131553.hqetnd45sc43z6xb@tarpaulin.shahaf.local2> <087AE8B9-35B0-4258-9626-AACA85471A07@kba.biglobe.ne.jp> <20200111201549.GA1264@tarpaulin.shahaf.local2> <3340070A-53DD-40F0-8363-A8C7D84702D3@kba.biglobe.ne.jp> <374cecf6-45d5-4688-861f-cc52017dbcea@www.fastmail.com> <321F9465-ABF9-465D-9242-7EF9A0EDDBED@kba.biglobe.ne.jp> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Jun T wrote on Tue, 25 Feb 2020 18:38 +0900: > Sorry for a *very* slow response; I've been quite busy these days. > Finally I found some time to work on this. No worries; we've all been there. I'm swamped/backlogged too. > But removing rlimits.awk has one drawback: > Before the patch, unknown resource can be detected in the build > time (by the special make rule defined in rlimits.mdd). > With the patch, we can notice unknown resouce(s) only when running > the limit (or ulimit) builtin. We may hope that a user who sees > UNKNOWN in the output of limit/ulimit will report it to us, or > add a simple test like >=20 > limit | grep UNKNOWN || print OK >=20 > somewhere in the test (but in which .ztst file?). I prefer a new test, but to arrange things in such a way that a failure of the new test won't fail the build or prevent other tests from running. So, how about: =E2=80=94 1. Placing the test in a new file, V99nonfatal.ztst; and 2. Using =C2=ABF:=C2=BB lines to explain that when the test fails, that sho= uldn't be treated as a build breaker and there is no problem to go on and do =C2=ABmake install=C2=BB. ? We might even add a new flag, e.g., =C2=ABZTST_failure_is_fatal=3Dfalse=C2= =BB, which would cause =C2=ABmake test=C2=BB to report the failure on stderr but keep = the exit code as zero: this way, if someone builds zsh 5.8 five years from now on a 2025-vintage OS, their =C2=ABmake && make check && make install=C2= =BB wouldn't fail on account of OS API changes between now and then. A couple of minor issues spotted in read-through: > --- a/Src/Builtins/rlimits.c > +++ b/Src/Builtins/rlimits.c > @@ -53,11 +40,214 @@ enum { > +typedef struct { Suggest to name the struct type =E2=80=94 =C2=ABtypedef struct resinfo_t { = =E2=80=A6 } resinfo_t=C2=BB =E2=80=94 as that tends to result in prettier output in the= debugger. > +/* table of known resources */ > +static resinfo_t known_resources[] =3D { Suggest to make the variable const. I haven't had time yet to do a full review or to test this, I'm afraid =E2= =98=B9 Cheers, Daniel