From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: Unreadable directories aren't included in glob expansion
Date: Fri, 28 Feb 2020 14:26:17 +0000 [thread overview]
Message-ID: <20200228142617.2700eb46@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <3DFEA2DC-139B-435D-A272-18208085736B@kba.biglobe.ne.jp>
Jun T wrote on Fri, 28 Feb 2020 15:37 +0900:
> > 2020/02/27 22:00, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> >
> > Jun. T wrote on Thu, 27 Feb 2020 00:51 +0900:
> >>
> >> I think just skipping this test on Cygwin is enough for now.
> >
> > I assume some day we'll fix the C code to make the test pass on other
> > platforms. When that happens, should the test then continue be skipped
> > on Cygwin? If not, I suggest adding a comment reminding to remove the
> > skip when the test starts to pass on other platforms.
>
> Sorry, I was not following this thread; what kind of "fix" do you
> have in mind?
I do not have a specific fix in mind. I just assumed that at some
indefinite point in the future we will change the C code in a way that
makes the test produce the expected output, and at the same time remove
the 'f' flag from the test.
> Anyway, the only thing I know is
> both access("d000/.", F_OK) and stat("d000/.", st)
> succeed on Cygwin. If the revised C code depends on the failure of
> either of these calls then the test need be skipped on Cygwin,
> I think.
Why would we need to skip the test on Cygwin after we fix it on other
platforms? The only reason the test fails on Cygwin is because it's
marked 'f' (= expected to fail) and _does_ produce the expected
output. Once we fix the C code so the test produces the expected
output, I think we'll be able to remove the 'f' flag _and_ the skip,
and then the test will be passing on all platforms, including Cygwin.
What am I missing?
Cheers,
Daniel
next prev parent reply other threads:[~2020-02-28 14:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200109154313eucas1p13b2e5465f21d059ea08537012e140236@eucas1p1.samsung.com>
[not found] ` <20200109154145.rqksfenozx6745rn@tarpaulin.shahaf.local2>
[not found] ` <1578585101.6028.13.camel__24021.2781982095$1578585228$gmane$org@samsung.com>
[not found] ` <20200109172222.uwgyjouab45zk2gf__13897.4118557357$1578604026$gmane$org@chaz.gmail.com>
[not found] ` <20200110072753.yh7qms4w2gb44zcf@chaz.gmail.com>
[not found] ` <20200110170932.yz5wvd4uzr2taq57@tarpaulin.shahaf.local2>
2020-02-26 15:51 ` Jun. T
2020-02-27 13:00 ` Daniel Shahaf
2020-02-28 6:37 ` Jun T
2020-02-28 6:51 ` Bart Schaefer
2020-02-28 7:57 ` Jun T
2020-02-28 14:26 ` Daniel Shahaf [this message]
2020-02-28 14:55 ` Daniel Shahaf
2020-03-03 1:57 ` Jun T
2020-03-04 19:21 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228142617.2700eb46@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).