From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 68c2182f for ; Fri, 28 Feb 2020 14:27:01 +0000 (UTC) Received: (qmail 6024 invoked by alias); 28 Feb 2020 14:26:55 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45502 Received: (qmail 5711 invoked by uid 1010); 28 Feb 2020 14:26:55 -0000 X-Qmail-Scanner-Diagnostics: from wout4-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25731. spamassassin: 3.4.2. Clear:RC:0(64.147.123.20):SA:0(-2.6/5.0):. Processed in 0.690549 secs); 28 Feb 2020 14:26:55 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrleekgdeifecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfgjfhfogggtgfesthejtd dtredtvdenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghnihgv lhdrshhhrghhrghfrdhnrghmvgeqnecukfhppeejledrudejkedrjedrudekleenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghn ihgvlhdrshhhrghhrghfrdhnrghmvg X-ME-Proxy: Date: Fri, 28 Feb 2020 14:26:17 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: Unreadable directories aren't included in glob expansion Message-ID: <20200228142617.2700eb46@tarpaulin.shahaf.local2> In-Reply-To: <3DFEA2DC-139B-435D-A272-18208085736B@kba.biglobe.ne.jp> References: <20200109154145.rqksfenozx6745rn@tarpaulin.shahaf.local2> <1578585101.6028.13.camel__24021.2781982095$1578585228$gmane$org@samsung.com> <20200109172222.uwgyjouab45zk2gf__13897.4118557357$1578604026$gmane$org@chaz.gmail.com> <20200110072753.yh7qms4w2gb44zcf@chaz.gmail.com> <20200110170932.yz5wvd4uzr2taq57@tarpaulin.shahaf.local2> <228AACAF-6A76-417F-929A-0CC48A9AB1D0@kba.biglobe.ne.jp> <20200227130017.2c0d48cd@tarpaulin.shahaf.local2> <3DFEA2DC-139B-435D-A272-18208085736B@kba.biglobe.ne.jp> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Jun T wrote on Fri, 28 Feb 2020 15:37 +0900: > > 2020/02/27 22:00, Daniel Shahaf wrote: > > > > Jun. T wrote on Thu, 27 Feb 2020 00:51 +0900: > >> > >> I think just skipping this test on Cygwin is enough for now. > > > > I assume some day we'll fix the C code to make the test pass on other > > platforms. When that happens, should the test then continue be skipped > > on Cygwin? If not, I suggest adding a comment reminding to remove the > > skip when the test starts to pass on other platforms. > > Sorry, I was not following this thread; what kind of "fix" do you > have in mind? I do not have a specific fix in mind. I just assumed that at some indefinite point in the future we will change the C code in a way that makes the test produce the expected output, and at the same time remove the 'f' flag from the test. > Anyway, the only thing I know is > both access("d000/.", F_OK) and stat("d000/.", st) > succeed on Cygwin. If the revised C code depends on the failure of > either of these calls then the test need be skipped on Cygwin, > I think. Why would we need to skip the test on Cygwin after we fix it on other platforms? The only reason the test fails on Cygwin is because it's marked 'f' (= expected to fail) and _does_ produce the expected output. Once we fix the C code so the test produces the expected output, I think we'll be able to remove the 'f' flag _and_ the skip, and then the test will be passing on all platforms, including Cygwin. What am I missing? Cheers, Daniel