zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Vin Shelton <acs@alumni.princeton.edu>
Cc: Zsh Hackers' List <zsh-workers@zsh.org>
Subject: Re: Test Failure. 2020-03-08
Date: Sun, 8 Mar 2020 15:27:59 +0000	[thread overview]
Message-ID: <20200308152759.GA19385@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CACeGjnUcoomNPV=dqCp4aF1sv1bJnY38-j+xpyYFaLvwYOQdPw@mail.gmail.com>

Vin Shelton wrote on Sun, Mar 08, 2020 at 08:38:53 -0400:
> Using the latest sources, I'm getting the following test error in the
> modload test:
> 
> --- /tmp/zsh.ztst.7939/ztst.err 2020-03-08 08:33:41.076674463 -0400
> +++ /tmp/zsh.ztst.7939/ztst.terr 2020-03-08 08:33:41.080007796 -0400
> @@ -0,0 +1 @@
> +zsh:2: failed to load module `zsh/parameter':
> /opt/zsh-2020-03-08/lib/zsh/5.8.0.1-dev/zsh/parameter.so: cannot open shared object file: No such file or directory
> Test ../../../src/zsh-2020-03-08/Test/V01zmodload.ztst failed: error output differs from expected as shown above for:
>  $ZTST_testdir/../Src/zsh -fc '
>    zmodload zsh/parameter
>    unset options
>    echo $+options
>  '
> Was testing: can unset a non-readonly autoloadable parameter after loading
> the module
> ../../../src/zsh-2020-03-08/Test/V01zmodload.ztst: test failed.
> 
> Please let me know if you need more info.

Could you try the following, please?

diff --git a/Test/V01zmodload.ztst b/Test/V01zmodload.ztst
index c3c64a79d..4fddb0bcc 100644
--- a/Test/V01zmodload.ztst
+++ b/Test/V01zmodload.ztst
@@ -349,6 +349,7 @@
 ?(eval):9: file descriptor out of range
 
  $ZTST_testdir/../Src/zsh -fc '
+   MODULE_PATH=${(q)MODULE_PATH}
    if zmodload -e zsh/parameter; then zmodload -u zsh/parameter; fi
    unset options
    zmodload zsh/parameter
@@ -359,6 +360,7 @@
 # Currently prints '1'.
 
  $ZTST_testdir/../Src/zsh -fc '
+   MODULE_PATH=${(q)MODULE_PATH}
    zmodload zsh/parameter
    unset options
    echo $+options
@@ -367,6 +369,7 @@
 >0
 
  $ZTST_testdir/../Src/zsh -fc '
+   MODULE_PATH=${(q)MODULE_PATH}
    if zmodload -e zsh/parameter; then zmodload -u zsh/parameter; fi
    unset builtins
  '
@@ -375,13 +378,15 @@
 # Currently, the 'unset' succeeds.
 
  $ZTST_testdir/../Src/zsh -fc '
+   MODULE_PATH=${(q)MODULE_PATH}
    zmodload zsh/parameter
    unset builtins
  '
 1:can't unset a readonly autoloadable parameter after loading the module
-?zsh:3: read-only variable: builtins
+*?zsh:?: read-only variable: builtins
 
  $ZTST_testdir/../Src/zsh -fc '
+   MODULE_PATH=${(q)MODULE_PATH}
    zmodload zsh/parameter
    zmodload -u zsh/parameter
    echo $options

Cheers,

Daniel

  reply	other threads:[~2020-03-08 15:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-08 12:38 Vin Shelton
2020-03-08 15:27 ` Daniel Shahaf [this message]
2020-03-08 20:47   ` Vin Shelton
2020-03-09  1:59     ` Daniel Shahaf
2020-03-09  2:08       ` Vin Shelton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200308152759.GA19385@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=acs@alumni.princeton.edu \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).