Re: PATCH: sshfs user-side automount

[Daniel Shahaf <d.s@daniel.shahaf.name>]

Peter Stephenson wrote on Tue, 17 Mar 2020 12:19 +0000:
> On Mon, 2020-03-16 at 18:36 +0000, Daniel Shahaf wrote:
> > Peter Stephenson wrote on Mon, 16 Mar 2020 10:11 +0000:  
> > > 
> > > (Lines are marked as "preformatted" in Evolution --- I hope that removes
> > > hard spaces.)  
> > That seems to have made no difference.
> > 
> > You might find it easier to run «git format-patch -1» and then attach
> > the resulting file.  
> 
> I can certainly do that but I'm not sure quite when this is turning
> up --- may be because I have an older version of Evolution here.
> 

Yeah, the MUA would be my first suspect.

You can set «git config --global format.suffix .patch.txt» to get a .txt extension.

> > > 
> > > +the default behaviour is equivalent to the following value:
> > > +example(zstyle ':chwpd:sshfs:' command-path sshfs -o workaround=rename)  
> > According to the sshfs(1) man page, the "buflimit" workaround is
> > enabled by default.
> > 
> > Is the "buflimit" workaround enabled when sshfs(1) is invoked as «sshfs
> > -o workaround=rename»?  I.e., does defaulting the "rename" workaround
> > enabled effectively change sshfs(1)'s default behaviour?  
> 
> My reading of the manual page is you'd need to set "nobuflimit" explicitly
> to turn it off, else there wouldn't be much use for the "no" prefix,
> you'd always have to list the ones you want to turn on.  So I think
> the way it's done is there to fix this exact issue.

In the alternative semantics, the "no" prefix wouldn't be useless; it'd still
be useful to allow people to write scripts such as «f() { sshfs -o
workaround=foo "$@" }» that may be invoked as «f -o workaround=nofoo» to
disable foo.  However, I agree it's probably implemented as you say.

I don't see anything about this in the output of `sshfs -o sshfs_debug -o debug
-o workaround=rename`.

Cheers,

Daniel

P.S. Speaking of sshfs_debug, here's a quick updated completion.  Some
of the completed values aren't documented in the man page on my system,
but I left them in, as I'm not sure whether they were removed before or
added after the version I have installed.

8<--8<--8<--8<--8<--8<--8<--8<--8<--8<--8<--8<--8<--8<--8<--8<--8<--8<--
From 19bc7ded6f1752c8a4283f262310730059d33f04 Mon Sep 17 00:00:00 2001
From: Daniel Shahaf <danielsh@apache.org>
Date: Tue, 17 Mar 2020 13:35:48 +0000
Subject: [PATCH] _sshfs: Complete some more options

---
 Completion/Linux/Command/_sshfs | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/Completion/Linux/Command/_sshfs b/Completion/Linux/Command/_sshfs
index 3363ecdc0..66faf9997 100644
--- a/Completion/Linux/Command/_sshfs
+++ b/Completion/Linux/Command/_sshfs
@@ -19,8 +19,14 @@ _arguments -C -S : \
   ':mountpoint:_files -/' && ret=0
 
 if [[ $state == options ]]; then
-  _values -s , "sshfs or fuse or mount options" \
+  # TODO complete ssh(1) options
+  _values -s , "options to ssh, sshfs, mount, or FUSE" \
+    'port:number' \
+    'compression: :(yes no)' \
     reconnect delay_connect sshfs_sync no_readahead sync_readdir \
+    sshfs_debug \
+    'cache: :(yes no)' \
+    'cache_timeout:timeout (seconds)' \
     'dir_cache:cache setting:(yes no)' \
     'dcache_max_size:size [10000]' \
     'dcache_timeout:timeout (seconds) [20]' \
@@ -37,12 +43,13 @@ if [[ $state == options ]]; then
     sftp_server:path:_files \
     directport:port:_ports \
     slave disable_hardlink transform_symlinks follow_symlinks no_check_root password_stdin \
+    debug \
     allow_other allow_root auto_unmount nonempty default_permissions \
     fsname:filesystem\ name \
     subtype:filesystem\ type \
     large_read \
     max_read:max\ size \
-    hard_remove use_ino readdir_ino direct_io kernel_cache auto_cache \
+    hard_remove use_ino readdir_ino direct_io kernel_cache auto_cache noauto_cache \
     'umask:permissions' \
     'uid:owner' 'gid:group' \
     'entry_timeout:timeout (seconds) [1]' \
@@ -60,7 +67,7 @@ if [[ $state == options ]]; then
     congestion_threshold:threshold \
     async_read sync_read atomic_o_trunc big_writes no_remote_lock no_remote_flock \
     no_remote_posix_lock splice_write splice_move splice_read \
-    from_code:charset to_code:charset subdir:_directories rellinks && ret=0
+    from_code:charset to_code:charset subdir:_directories rellinks norellinks && ret=0
 fi
 
 return ret


> 
> pws
>