From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Jun T <takimoto-j@kba.biglobe.ne.jp>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin
Date: Fri, 20 Mar 2020 17:02:56 +0000 [thread overview]
Message-ID: <20200320170256.3f141384@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <939538FA-A90B-44DA-AF85-C50D0F516BA0@kba.biglobe.ne.jp>
Good morning Jun-san,
I've started to review the rlimits patch and have found an issue:
Jun T wrote on Tue, 03 Mar 2020 18:23 +0900:
> diff --git a/Test/B12limit.ztst b/Test/B12limit.ztst
> new file mode 100644
> index 000000000..2a072da08
> --- /dev/null
> +++ b/Test/B12limit.ztst
> @@ -0,0 +1,10 @@
> +# check if there is unknown resouce(s)
> +
> +%test
> +
> + ZTST_not_fatal=1
> + limit | grep UNKNOWN || print OK
> +0:Check if there is unknown resouce(s) in the system
> +>OK
> +F:A failure here just indicates there is a resource in your system that is
> +F:unknown to zsh developers. Please report this to zsh-workers mailing list.
The "limit" builtin is provided by a module. As such, it can be
unavailable if the module had been disabled in config.modules prior to
building.
Proposed patch:
[[[
diff --git a/Test/B12limit.ztst b/Test/B12limit.ztst
index 5dd7afdbe..2a4749632 100644
--- a/Test/B12limit.ztst
+++ b/Test/B12limit.ztst
@@ -1,4 +1,12 @@
-# check if there is unknown resouce(s)
+
+%prep
+
+ if grep '^name=zsh/rlimits .* link=no ' $ZTST_testdir/../config.modules >/dev/null
+ then
+ ZTST_unimplemented="the zsh/rlimits module was disabled by configure (see config.modules)"
+ return 0
+ fi
+ zmodload zsh/rlimits
%test
]]]
(The %prep block is copied verbatim from V07pcre.ztst.)
With that patch, B12limit.ztst gets skipped if zsh/rlimits is disabled.
Cheers,
Daniel
P.S. Shouldn't the test file should be renamed into the V namespace?
next prev parent reply other threads:[~2020-03-20 17:03 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 10:39 Jun T
2020-01-08 21:33 ` Daniel Shahaf
2020-01-09 10:32 ` Jun T
2020-01-09 13:15 ` Daniel Shahaf
2020-01-10 10:24 ` Jun T
2020-01-11 20:15 ` Daniel Shahaf
2020-01-13 11:00 ` Jun T
2020-01-13 16:42 ` Daniel Shahaf
2020-01-14 4:44 ` Jun T
2020-01-14 16:25 ` Daniel Shahaf
2020-02-25 9:38 ` Jun T
2020-02-27 13:22 ` Daniel Shahaf
2020-02-27 18:46 ` Mikael Magnusson
2020-02-28 8:42 ` Jun T
2020-02-28 14:19 ` Daniel Shahaf
2020-02-28 14:31 ` Daniel Shahaf
2020-03-03 9:23 ` Jun T
2020-03-04 19:29 ` Daniel Shahaf
2020-03-05 10:26 ` Jun T
2020-03-05 14:58 ` Daniel Shahaf
2020-03-20 17:02 ` Daniel Shahaf [this message]
2020-03-20 17:20 ` Bart Schaefer
2020-03-20 17:39 ` Daniel Shahaf
2020-03-20 18:28 ` Daniel Shahaf
2020-03-20 18:36 ` Bart Schaefer
2020-03-20 19:38 ` Daniel Shahaf
2020-03-20 18:39 ` Bart Schaefer
2020-03-20 19:32 ` Daniel Shahaf
2020-03-20 19:18 ` Daniel Shahaf
2020-03-23 5:31 ` Jun T
2020-03-24 2:08 ` Daniel Shahaf
2020-03-23 5:41 ` Jun T
2020-03-24 1:33 ` Jun T
2020-03-24 2:43 ` Daniel Shahaf
2020-03-25 0:16 ` Jun T
2020-03-25 22:04 ` Daniel Shahaf
2020-03-25 23:42 ` [PATCH] find RLIM_NLIMITS correctly on CygwinjL Daniel Shahaf
2020-03-24 2:34 ` [PATCH] find RLIM_NLIMITS correctly on Cygwin Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320170256.3f141384@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).