zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Jun T <takimoto-j@kba.biglobe.ne.jp>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin
Date: Tue, 24 Mar 2020 02:43:20 +0000	[thread overview]
Message-ID: <20200324024320.12bae9e9@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <FB8CDFB2-6DFC-4A39-AAC0-EBAE802F8D69@kba.biglobe.ne.jp>

Jun T wrote on Tue, 24 Mar 2020 10:33 +0900:
> > 2020/03/23 14:41, I wrote:
> > 
> > Personally I feel only adding a test (B12limit.zsh) is enough for now, but
> > have no objection to adding a runtime check in rlimits.c.  
> 
> If I add the runtime check, and if there is a duplicated option letter,
> I get the error message 'duplicate ulimit option letter' every time
> I start zsh. This may be quite annoying for ordinary users.

That message is printed by the DPUTS1() macro.  That macro expands to
nothing unless the «DEBUG» preprocessor symbol is defined, which
happens if one runs configure with --enable-zsh-debug.  Ordinary users
shouldn't see that.

> B12limit.ztst (limit| grep UNKNOWN || print OK) fails due to the error
> message; I think it's OK. But V01zmodload.ztst also fails due to the
> message, and other tests would fail if they use the rlimits module.
> 

Only in --enable-zsh-debug mode, and the fix is trivial: edit
known_resources and change one of the two colliding resources' letter
to 'N'.  Does this address your concerns, or would you prefer something
more?  We could even remove the DPUTS1() call entirely.

> So I think just adding a test for duplicated option letter is enough.
> If someone add a new resource then it is their responsibility to
> confirm that all the tests pass. I think ordinary users need not see
> the error message.

They won't, unless they configure with --enable-zsh-debug.

Cheers,

Daniel

  reply	other threads:[~2020-03-24  2:44 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08 10:39 Jun T
2020-01-08 21:33 ` Daniel Shahaf
2020-01-09 10:32   ` Jun T
2020-01-09 13:15     ` Daniel Shahaf
2020-01-10 10:24       ` Jun T
2020-01-11 20:15         ` Daniel Shahaf
2020-01-13 11:00           ` Jun T
2020-01-13 16:42             ` Daniel Shahaf
2020-01-14  4:44               ` Jun T
2020-01-14 16:25                 ` Daniel Shahaf
2020-02-25  9:38                   ` Jun T
2020-02-27 13:22                     ` Daniel Shahaf
2020-02-27 18:46                       ` Mikael Magnusson
2020-02-28  8:42                       ` Jun T
2020-02-28 14:19                         ` Daniel Shahaf
2020-02-28 14:31                           ` Daniel Shahaf
2020-03-03  9:23                           ` Jun T
2020-03-04 19:29                             ` Daniel Shahaf
2020-03-05 10:26                               ` Jun T
2020-03-05 14:58                                 ` Daniel Shahaf
2020-03-20 17:02                             ` Daniel Shahaf
2020-03-20 17:20                               ` Bart Schaefer
2020-03-20 17:39                                 ` Daniel Shahaf
2020-03-20 18:28                                   ` Daniel Shahaf
2020-03-20 18:36                                     ` Bart Schaefer
2020-03-20 19:38                                       ` Daniel Shahaf
2020-03-20 18:39                                     ` Bart Schaefer
2020-03-20 19:32                                       ` Daniel Shahaf
2020-03-20 19:18                     ` Daniel Shahaf
2020-03-23  5:31                       ` Jun T
2020-03-24  2:08                         ` Daniel Shahaf
2020-03-23  5:41                       ` Jun T
2020-03-24  1:33                         ` Jun T
2020-03-24  2:43                           ` Daniel Shahaf [this message]
2020-03-25  0:16                             ` Jun T
2020-03-25 22:04                               ` Daniel Shahaf
2020-03-25 23:42                                 ` [PATCH] find RLIM_NLIMITS correctly on CygwinjL Daniel Shahaf
2020-03-24  2:34                         ` [PATCH] find RLIM_NLIMITS correctly on Cygwin Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200324024320.12bae9e9@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).