From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,RDNS_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 Received: (qmail 6935 invoked from network); 25 Mar 2020 22:05:47 -0000 Received-SPF: pass (primenet.com.au: domain of zsh.org designates 203.24.36.2 as permitted sender) receiver=inbox.vuxu.org; client-ip=203.24.36.2 envelope-from= Received: from unknown (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTP; 25 Mar 2020 22:05:47 -0000 Received: (qmail 23030 invoked by alias); 25 Mar 2020 22:05:40 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45617 Received: (qmail 4545 invoked by uid 1010); 25 Mar 2020 22:05:40 -0000 X-Qmail-Scanner-Diagnostics: from wout3-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25758. spamassassin: 3.4.2. Clear:RC:0(64.147.123.19):SA:0(-2.6/5.0):. Processed in 4.426799 secs); 25 Mar 2020 22:05:40 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudehgedgudefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfgjfhfogggtgfesth hqtddtredtjeenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghn ihgvlhdrshhhrghhrghfrdhnrghmvgeqnecukfhppeejledrudejiedruddvhedrvdefvd enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhs segurghnihgvlhdrshhhrghhrghfrdhnrghmvg X-ME-Proxy: Date: Wed, 25 Mar 2020 22:04:55 +0000 From: Daniel Shahaf To: Jun T Cc: zsh-workers@zsh.org Subject: Re: [PATCH] find RLIM_NLIMITS correctly on Cygwin Message-ID: <20200325220455.18501146@tarpaulin.shahaf.local2> In-Reply-To: <452D3122-F904-4A39-9E2E-31F3285C8019@kba.biglobe.ne.jp> References: <82F8CDE0-C95C-4D31-ABFC-EBB3C97799F3@kba.biglobe.ne.jp> <1B509B1C-A670-482F-9D88-2145E15D03A1@kba.biglobe.ne.jp> <20200109131553.hqetnd45sc43z6xb@tarpaulin.shahaf.local2> <087AE8B9-35B0-4258-9626-AACA85471A07@kba.biglobe.ne.jp> <20200111201549.GA1264@tarpaulin.shahaf.local2> <3340070A-53DD-40F0-8363-A8C7D84702D3@kba.biglobe.ne.jp> <374cecf6-45d5-4688-861f-cc52017dbcea@www.fastmail.com> <321F9465-ABF9-465D-9242-7EF9A0EDDBED@kba.biglobe.ne.jp> <20200320191846.3a4f5682@tarpaulin.shahaf.local2> <20200324024320.12bae9e9@tarpaulin.shahaf.local2> <452D3122-F904-4A39-9E2E-31F3285C8019@kba.biglobe.ne.jp> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Jun T wrote on Wed, 25 Mar 2020 09:16 +0900: > > 2020/03/24 11:43, Daniel Shahaf wrote: > >=20 > > Jun T wrote on Tue, 24 Mar 2020 10:33 +0900: =20 > >>=20 > >> I get the error message 'duplicate ulimit option letter' every time > >> I start zsh. This may be quite annoying for ordinary users. =20 > >=20 > > That message is printed by the DPUTS1() macro. =20 >=20 > Whoops, sorry. >=20 > I think only someone here (zsh-workers) will add a new resource, and > I believe they will run the tests (but not sure they use > --enable-zsh-debug). So just adding a test is sufficient, I think. >=20 Okay, I'll commit the test from 45590, then, and leave the rest out. > > 2020/03/21 2:02, Daniel Shahaf wrote: > > =20 > >> + limit | grep UNKNOWN || print OK =20 > >=20 > > The "limit" builtin is provided by a module. As such, it can be > > unavailable if the module had been disabled in config.modules prior to > > building. =20 >=20 > So what the fix for this? Is it enough to skip the tests if loading > rlimits module fails (because we are testing module features, not > module loading)? Yes, I think so. The patch in 45591 will take care of testing that zmodload succeeds. With that patch, B12limit.ztst can just do =C2=ABif ! zmodload =E2=80=A6; ZTST_unimplemented=3D=E2=80=A6=C2=BB like al= l other V*ztst files: zmodload errors will be caught by 45591. Cheers, Daniel