From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Received: (qmail 3084 invoked from network); 15 Apr 2020 01:16:16 -0000 Received-SPF: pass (primenet.com.au: domain of zsh.org designates 203.24.36.2 as permitted sender) receiver=inbox.vuxu.org; client-ip=203.24.36.2 envelope-from= Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with UTF8ESMTPZ; 15 Apr 2020 01:16:16 -0000 Received: (qmail 23936 invoked by alias); 15 Apr 2020 01:16:10 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45700 Received: (qmail 13068 invoked by uid 1010); 15 Apr 2020 01:16:10 -0000 X-Qmail-Scanner-Diagnostics: from wout4-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.2/25779. spamassassin: 3.4.4. Clear:RC:0(64.147.123.20):SA:0(-2.6/5.0):. Processed in 0.994845 secs); 15 Apr 2020 01:16:10 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfedvgdegvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfgjfhfogggtgfesthejtd dtredtvdenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghnihgv lhdrshhhrghhrghfrdhnrghmvgeqnecukfhppeejledrudejjedruddugedrudegleenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegu rghnihgvlhdrshhhrghhrghfrdhnrghmvg X-ME-Proxy: Date: Wed, 15 Apr 2020 01:15:30 +0000 From: Daniel Shahaf To: Cedric Ware Cc: zsh-workers@zsh.org Subject: Re: [PATCH] Enable sub-second timeout in zsystem flock Message-ID: <20200415011530.2b8f3ed3@tarpaulin.shahaf.local2> In-Reply-To: <20200414202100.x7fxbf3liwbyclpe@phare.normalesup.org> References: <20200308183907.mxnhqrr2uflwooax@phare.normalesup.org> <20200314210454.hp562smyqv3ew255@phare.normalesup.org> <20200315005036.45bc846b@tarpaulin.shahaf.local2> <20200315160324.dstgtmajzwxpaccn@phare.normalesup.org> <20200315165410.GA30241@tarpaulin.shahaf.local2> <20200413213449.orqym5bqboznancl@phare.normalesup.org> <20200414114700.108febf3@tarpaulin.shahaf.local2> <20200414202100.x7fxbf3liwbyclpe@phare.normalesup.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cedric Ware wrote on Tue, 14 Apr 2020 22:21 +0200: > Hopefully this patch can now be integrated, unless there are new > issues? The issues I've raised before have all been addressed (other than the new nits below); however, I haven't done a line-by-line review. dana, would you happen to have time to review the Cedric's latest revision (workers/45690)? No problem if not; just asking since you reviewed earlier revisions. Cedric Ware wrote on Mon, 13 Apr 2020 23:34 +0200: > +++ b/Doc/Zsh/mod_system.yo > @@ -196,9 +196,16 @@ item(tt(zsystem flock -u) var(fd_expr))( > +(Note: var(timeout) must be less than 2^30-1 seconds (about 34 years); > +and var(interval) must be less than 0.999 * LONG_MAX microseconds > +(only about 35 minutes on 32-bit systems).) The semicolon feels out of place. (Might be just me, though.) > +++ b/Test/V14system.ztst > @@ -0,0 +1,150 @@ > +# Test zsh/system module > + > +%prep > + > + if zmodload -s zsh/system && zmodload -s zsh/zselect; then > + tst_dir=V13.tmp s/V13/V14/ > Cheers, Daniel