From: Stephane Chazelas <stephane@chazelas.org>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: [PATCH] [ping] Effect of "print -s" when called in zle widget not seen until zle is restarted
Date: Sun, 10 May 2020 11:07:27 +0100 [thread overview]
Message-ID: <20200510100727.j42omcak4lps55qo@chazelas.org> (raw)
In-Reply-To: <20200502212517.v36yw3jv7x3zxzho@chazelas.org>
[Repost as it looks like it was missed the first time round.]
From
https://unix.stackexchange.com/questions/583443/adding-a-string-to-the-zsh-history
User https://unix.stackexchange.com/users/368116/noibe:
> The following function
>
> function test_hist() {
> print -s "This is a test"
> }
> zle -N test_hist
> bindkey '^X^T' test_hist
>
> adds the string This is a test to the zsh-history.
>
> If I call the function explicitly by typing test_hist, the
> string is immediately added to the history, but if I call it
> through the bindkey by pressing ctrl-x ctrl-t, the string is not
> added to the history straight away. I need to issue another
> command before I can see it in the history.
>
> Why is that, and how can I fix it?
My answer there:
I find that using fc -R =(print text) in place of print -s text
works consistently in and out of a zle widgets though, so it
could be a work around for you.
Looking at the code of zsh 5.8, I find that fc -R seems to let
zle know that a new history entry has been added when it detects
zle is active, while print -s doesn't.
This patch (on the current git head as of
2020-05-02T22:20+01:00) seems to fix it:
diff --git a/Src/builtin.c b/Src/builtin.c
index 3dab3f9b4..551653508 100644
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -4918,6 +4918,8 @@ bin_print(char *name, char **args, Options ops, int func)
ent->stim = ent->ftim = time(NULL);
ent->node.flags = 0;
addhistnode(histtab, ent->node.nam, ent);
+ if (zleactive)
+ zleentry(ZLE_CMD_SET_HIST_LINE, curhist);
unqueue_signals();
return 0;
}
Not sure if that's the right fix though. I'll submit it to
zsh-workers@zsh.org.
Hence this email.
next prev parent reply other threads:[~2020-05-10 10:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-02 21:25 Stephane Chazelas
2020-05-10 10:07 ` Stephane Chazelas [this message]
2020-05-21 5:09 ` [PATCH] [ping] " Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200510100727.j42omcak4lps55qo@chazelas.org \
--to=stephane@chazelas.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).