zsh-workers
 help / color / mirror / code / Atom feed
From: Stephane Chazelas <stephane@chazelas.org>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] [doc] clone module using xterm's slave mode
Date: Tue, 19 May 2020 19:54:13 +0100	[thread overview]
Message-ID: <20200519185413.m54ljmsvv2zrmwww@chazelas.org> (raw)
In-Reply-To: <20200519010140.38c12d2b@tarpaulin.shahaf.local2>

2020-05-19 01:01:40 +0000, Daniel Shahaf:
[...]
> There's a race condition here («clone» might run before «./pty» is
> created).  Is it worthwhile to point it out in the text, or add
> a «sleep» in the example?
[...]

You're right, maybe a better approach would be to supply a
contrib function for that which could be extended to other
terminal emulators like:

clone_on_new_terminal() {
  local terminal_cmd setup
  case $1 in
    (*xterm*)
      terminal_cmd="$1 -Sunused/3"
      setup='IFS= read -r WINDOWID'
      ;;
    (*rxvt*)
      terminal_cmd="$1 -pty-fd 3"
      setup=
      ;;
    (*)
      printf >&2 '"%s" terminal not supported\n' "$1"
      return 1
      ;;
  esac
      
  socat -d -d PTY,wait-slave,echo=0 "exec:$terminal_cmd,nofork,fdout=3,fdin=3" 2>&1 | {
    local -a fields
    IFS=' ' read -rA fields
    clone $fields[-1]
    if (($!)); then
      cat >&2
    else
      eval "$setup"
    fi
  }
}

Still a bit brittle as it relies on a specific output format of
socat's debug output. 

> By the way, WDYT of adding a concept index entry (e.g., «cindex(tty,
> cloning the shell onto an unused)») at the top of the file?  I think the
> existing cindex entries won't help someone who doesn't know what the
> module is called to discover it.
[...]

To be honest, I'm not sure I understand what that module is for.

What would be a typical use case?

-- 
Stephane

  reply	other threads:[~2020-05-19 18:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-17 10:13 Stephane Chazelas
2020-05-17 20:19 ` Mikael Magnusson
2020-05-18  6:14   ` [PATCHv2] " Stephane Chazelas
2020-05-19  1:01 ` [PATCH] " Daniel Shahaf
2020-05-19 18:54   ` Stephane Chazelas [this message]
2020-05-19 23:36     ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200519185413.m54ljmsvv2zrmwww@chazelas.org \
    --to=stephane@chazelas.org \
    --cc=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).