zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Stephane Chazelas <stephane@chazelas.org>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] [doc] clone module using xterm's slave mode
Date: Tue, 19 May 2020 23:36:37 +0000	[thread overview]
Message-ID: <20200519233637.26e57deb@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <20200519185413.m54ljmsvv2zrmwww@chazelas.org>

Stephane Chazelas wrote on Tue, 19 May 2020 19:54 +0100:
> 2020-05-19 01:01:40 +0000, Daniel Shahaf:
> [...]
> > There's a race condition here («clone» might run before «./pty» is
> > created).  Is it worthwhile to point it out in the text, or add
> > a «sleep» in the example?  
> [...]
> 
> You're right, maybe a better approach would be to supply a
> contrib function for that which could be extended to other
> terminal emulators like:
> 

I'm fairly certain that that's nothing at all like what I said :)

Anyway, to answer your question, I'd say that's up to you.  The docs
patch is perfectly good and useful as it stands.  A function would be
even better, but if that's not possible for some reason (e.g., because
of the mentioned dependency on «socat»'s debug output format), then I'd
vote for going with the docs patch.

> > By the way, WDYT of adding a concept index entry (e.g., «cindex(tty,
> > cloning the shell onto an unused)») at the top of the file?  I think the
> > existing cindex entries won't help someone who doesn't know what the
> > module is called to discover it.  
> [...]
> 
> To be honest, I'm not sure I understand what that module is for.
> 
> What would be a typical use case?

Not sure.

Cheers,

Daniel

      reply	other threads:[~2020-05-19 23:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-17 10:13 Stephane Chazelas
2020-05-17 20:19 ` Mikael Magnusson
2020-05-18  6:14   ` [PATCHv2] " Stephane Chazelas
2020-05-19  1:01 ` [PATCH] " Daniel Shahaf
2020-05-19 18:54   ` Stephane Chazelas
2020-05-19 23:36     ` Daniel Shahaf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200519233637.26e57deb@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=stephane@chazelas.org \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).