From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 20783 invoked from network); 19 May 2020 23:37:27 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 19 May 2020 23:37:27 -0000 Received: (qmail 311 invoked by alias); 19 May 2020 23:37:16 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45856 Received: (qmail 19743 invoked by uid 1010); 19 May 2020 23:37:16 -0000 X-Qmail-Scanner-Diagnostics: from out5-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25814. spamassassin: 3.4.4. Clear:RC:0(66.111.4.29):SA:0(-2.6/5.0):. Processed in 0.720159 secs); 19 May 2020 23:37:16 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddtkedgvdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfgjfhfogggtgfesthhqtddtredtjeenucfhrhhomhepffgrnhhi vghlucfuhhgrhhgrfhcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgeqne cuggftrfgrthhtvghrnhephfdtteefheevuedthedutdeifeegteettdejtdffheduieei jeelteetkeduteehnecukfhppeejledrudejjedrudefgedrfeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdrshhh rghhrghfrdhnrghmvg X-ME-Proxy: Date: Tue, 19 May 2020 23:36:37 +0000 From: Daniel Shahaf To: Stephane Chazelas Cc: Zsh hackers list Subject: Re: [PATCH] [doc] clone module using xterm's slave mode Message-ID: <20200519233637.26e57deb@tarpaulin.shahaf.local2> In-Reply-To: <20200519185413.m54ljmsvv2zrmwww@chazelas.org> References: <20200517101347.g7v6k2g7hoew636q@chazelas.org> <20200519010140.38c12d2b@tarpaulin.shahaf.local2> <20200519185413.m54ljmsvv2zrmwww@chazelas.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Stephane Chazelas wrote on Tue, 19 May 2020 19:54 +0100: > 2020-05-19 01:01:40 +0000, Daniel Shahaf: > [...] > > There's a race condition here (=C2=ABclone=C2=BB might run before =C2= =AB./pty=C2=BB is > > created). Is it worthwhile to point it out in the text, or add > > a =C2=ABsleep=C2=BB in the example? =20 > [...] >=20 > You're right, maybe a better approach would be to supply a > contrib function for that which could be extended to other > terminal emulators like: >=20 I'm fairly certain that that's nothing at all like what I said :) Anyway, to answer your question, I'd say that's up to you. The docs patch is perfectly good and useful as it stands. A function would be even better, but if that's not possible for some reason (e.g., because of the mentioned dependency on =C2=ABsocat=C2=BB's debug output format), th= en I'd vote for going with the docs patch. > > By the way, WDYT of adding a concept index entry (e.g., =C2=ABcindex(tt= y, > > cloning the shell onto an unused)=C2=BB) at the top of the file? I thi= nk the > > existing cindex entries won't help someone who doesn't know what the > > module is called to discover it. =20 > [...] >=20 > To be honest, I'm not sure I understand what that module is for. >=20 > What would be a typical use case? Not sure. Cheers, Daniel