From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 23950 invoked from network); 28 May 2020 08:45:44 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 28 May 2020 08:45:44 -0000 Received: (qmail 10149 invoked by alias); 28 May 2020 08:45:36 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 45931 Received: (qmail 18563 invoked by uid 1010); 28 May 2020 08:45:36 -0000 X-Qmail-Scanner-Diagnostics: from out2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25821. spamassassin: 3.4.4. Clear:RC:0(66.111.4.26):SA:0(-2.6/5.0):. Processed in 3.853722 secs); 28 May 2020 08:45:36 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddviedgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfgjfhfogggtgfesthhqtddtredtjeenucfhrhhomhepffgrnhhi vghlucfuhhgrhhgrfhcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgeqne cuggftrfgrthhtvghrnheptdeggeffgffhhfegfeeggfelgfeugfevvdfgueeltdfhtedu feehjeeuffevheevnecuffhomhgrihhnpeiishhhrdhorhhgnecukfhppeejledrudejie drfeelrdeileenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvg X-ME-Proxy: Date: Thu, 28 May 2020 08:44:52 +0000 From: Daniel Shahaf To: Marlon Richert Cc: Zsh hackers list Subject: Re: Zsh crashes on `compadd` when using `_history` completer & zstyle `ignored-patterns` is set Message-ID: <20200528084452.34074159@tarpaulin.shahaf.local2> In-Reply-To: References: <20200526184830.4b52dd0c@tarpaulin.shahaf.local2> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Marlon Richert wrote on Thu, 28 May 2020 10:49 +0300: > On Tue, 26 May 2020 at 21:48, Daniel Shahaf wrot= e: >=20 > > > > I followed these steps as follows: > > > > [[[ > > $ cd "$(mktemp -d)" > > $ tee .zshrc > > HISTFILE=3D${ZDOTDIR:-$HOME}/.zsh_history > > HISTSIZE=3D2000 > > SAVEHIST=3D1000 > > autoload -Uz compinit > > compinit > > zstyle ':completion:*' ignored-patterns '' > > > > $ yes | head -1001 > .zsh_history > > $ ZDOTDIR=3D$PWD $builddir/Src/zsh -d > > % bindkey -e > > % > > ]]] > > > > The terminal beeped and no crash happened. > > > > What's your $ZSH_VERSION and $ZSH_PATCHLEVEL? > > =20 >=20 > $ZSH_VERSION =3D 5.8 > $ZSH_PATCHLEVEL =3D zsh-5.8-0-g77d203f >=20 > Could the contents of my histfile have an influence on this? If you do `y= es > | head -1001 > .zsh_history`, then there is no realistic data in the > histfile. >=20 That's possible, yes. Can _you_ reproduce the bug using the steps I posted? I don't have your $HISTFILE, but I can't reproduce the issue if I substitute my $HISTFILE (using =C2=ABcp $HISTFILE ./.zsh_history=C2=BB) i= nto the above steps, and it's longer than 1000 lines. > I noticed that if I start Zsh without a histfile, then the problem does n= ot > occur. What if you start zsh with a empty histfile? If you can reproduce the problem with your usual histfile but not with an empty one, try reducing your histfile to the smallest one that does still reproduce the problem. There are generic instructions at http://www.zsh.org/cgi-bin/mla/redirect?WORKERNUMBER=3D45791, if you aren't familiar with the procedure. (They're written for .zshrc but you can apply them to $HISTFILE as well.) Can you try reproducing the bug in zsh built from master? Cheers, Daniel