From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: add-zle-hook-widget and multiple hooks
Date: Mon, 8 Jun 2020 06:14:25 +0000 [thread overview]
Message-ID: <20200608061425.034f9d90@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CAHYJk3Rtfj=cfhRpnBhzBUjbF2_9R5W9vG4a68qT84pH9xVRGA@mail.gmail.com>
[moving Eric to bcc]
Mikael Magnusson wrote on Sat, 06 Jun 2020 13:58 +0200:
> On 6/6/20, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> > When two or more zle-line-pre-redraw hooks are registered using
> > add-zle-hook-widget, the value of $LASTWIDGET when the each hook is
> > called is the name of the former hook:
> >
> > [Eric Freese wrote in
> > https://github.com/zsh-users/zsh-autosuggestions/issues/529#issuecomment-632113840]
> > $ zsh -df
> > % autoload add-zle-hook-widget
> > % f() {}
> > % g() { zle -M "$(typeset -p LASTWIDGET)" }
> > % add-zle-hook-widget line-pre-redraw f
> > % add-zle-hook-widget line-pre-redraw g
> > % x<CURSOR>
> > typeset -r LASTWIDGET=f
> >
> > The issue here is that g would like to to know what widget was invoked
> > immediately before the redraw. In the example, that'd be self-insert.
> >
> > I've attached two proofs of concept. WDYT?
> >
> > I'll add docs, etc, once an approach is chosen.
> >
> > Cheers,
> >
> > Daniel
> >
> > P.S. For the latter patch, note that «zle $widget -f» is distinct from
> > «zle -f».
>
> I think the warning message when -f is not followed by nolast should
> be phrased in the same way it would if there were other valid flags,
> since it would have to change when more are added anyway (we will
> probably not want to enumerate all possible flags in this warning
> message).
Thanks for the review.
If we add more flags that are too many to list, then we should change
the error message, yes; nevertheless, _right now_ only one flag is
supported, so the error message might as well say that. That'd be
a feature, not a bug. Compare:
% ssh $foo svn info --show-item=dept
svn: E205000: 'dept' is not a valid value for --show-item; did you mean 'depth'?
% ssh $bar svn info --show-item=dept
svn: E205000: 'dept' is not a valid value for --show-item
When I'm on $bar and get that error message, I know not to bother
trying the correct spelling because it won't work. Same here: If 5.9
supports -f nolast, 5.10 supports -f somethingelse as well, and then
somebody tries -f somethingelse in 5.9, a generic error message will
be less helpful to them than a specific one.
> Also, I think rather than reusing the concept of the -f option, it
> would be better to use another flag (maybe -l for LASTWIDGET) which is
> analogous to the existing -w option:
_Why_ would that be better?
> Normally, calling a widget in this way does not set the special
> parameter WIDGET and related parameters, so that the environ‐
> ment appears as if the top-level widget called by the user were
> still active. With the option -w, WIDGET and related parame‐
> ters are set to reflect the widget being executed by the zle
> call.
Cheers,
Daniel
next prev parent reply other threads:[~2020-06-08 6:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-06 8:40 Daniel Shahaf
2020-06-06 11:58 ` Mikael Magnusson
2020-06-08 6:14 ` Daniel Shahaf [this message]
2020-06-08 17:52 ` Mikael Magnusson
2020-06-10 13:34 ` Daniel Shahaf
2020-06-18 11:42 ` Daniel Shahaf
2020-06-27 2:54 ` Daniel Shahaf
2020-06-27 3:02 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608061425.034f9d90@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=mikachu@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).