From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 4563 invoked from network); 10 Jun 2020 13:45:46 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 10 Jun 2020 13:45:46 -0000 Received: (qmail 6828 invoked by alias); 10 Jun 2020 13:45:38 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 46040 Received: (qmail 17382 invoked by uid 1010); 10 Jun 2020 13:45:38 -0000 X-Qmail-Scanner-Diagnostics: from wout1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25835. spamassassin: 3.4.4. Clear:RC:0(64.147.123.24):SA:0(-2.6/5.0):. Processed in 0.730878 secs); 10 Jun 2020 13:45:38 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudehiedgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfgjfhfogggtgfesthhqtddtredtjeenucfhrhhomhepffgrnhhi vghlucfuhhgrhhgrfhcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgeqne cuggftrfgrthhtvghrnhephfdtteefheevuedthedutdeifeegteettdejtdffheduieei jeelteetkeduteehnecukfhppeejledrudejiedrfeelrdeileenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdrshhh rghhrghfrdhnrghmvg X-ME-Proxy: Date: Wed, 10 Jun 2020 13:44:59 +0000 From: Daniel Shahaf To: Oliver Kiddle Cc: "O. simplex" , "zsh-workers@zsh.org" Subject: Re: Solution: Bu report - unix/_gpg completion broken Message-ID: <20200610134459.514b0a3d@tarpaulin.shahaf.local2> In-Reply-To: <99116-1591744033.948885@zagI.gwnq.OfJE> References: <20200515085324.63c6325f@tarpaulin.shahaf.local2> <20200606081909.33d488c5@tarpaulin.shahaf.local2> <99116-1591744033.948885@zagI.gwnq.OfJE> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Oliver Kiddle wrote on Wed, 10 Jun 2020 01:07 +0200: > On 6 Jun, Daniel Shahaf wrote: > > --- a/Completion/compinit > > @@ -159,6 +159,7 @@ _comp_options=3D( > > + NO_shfileexpansion =20 >=20 > Stuffing extra options into _comp_options is usually a bad idea because > it prevents the completion system from honouring the user's preferences. > In this case _expand will no longer handle the correct precedence of ~ > and brace expansion. Oh, sorry. I looked for such side effects before I made the change, but didn't find any. Should I revert that patch pending a better one? In any case, I think the long term fix here isn't to expect completion functions to be able to run under arbitrary syntax-modifying options=C2=A0= =E2=80=94 especially given that some completion functions are maintained outside our own tree by people not as familiar with the spectrum of syntax variations as folks on this list=C2=A0=E2=80=94 but to run completion funct= ions under a known set of options and make the user's options available to them separately. That's exactly what we would necessarily do if completion functions didn't happen to be executed by the same interpreter that will later executed $PREBUFFER$BUFFER. z-sy-h has code for this. It synthesizes an associative array akin to $options, but it doesn't require zsh/parameter. Cheers, Daniel P.S. OT: Does anyone use a zsh build where the zsh/parameter module is not available [i.e., where =C2=ABzmodload zsh/parameter=C2=BB would fail]? > It looks to me like the shfileexpansion option has got broken more > fundamentally at some point. Swap the =3D and : in the character > class in the pattern on the line that produces an error and the error > goes away. _complete_debug also appears to be broken with > shfileexpansion: >=20 > setopt shfileexpansion; : =3D(echo hi) >=20 > I've not bisected fully but I did check a very old zsh and it worked > fine with that. >=20 > Oliver >=20