From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 8199 invoked from network); 17 Jun 2020 08:38:57 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 17 Jun 2020 08:38:57 -0000 Received: (qmail 15140 invoked by alias); 17 Jun 2020 08:38:51 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 46053 Received: (qmail 6560 invoked by uid 1010); 17 Jun 2020 08:38:51 -0000 X-Qmail-Scanner-Diagnostics: from wout5-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25842. spamassassin: 3.4.4. Clear:RC:0(64.147.123.21):SA:0(-2.6/5.0):. Processed in 0.905112 secs); 17 Jun 2020 08:38:51 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejvddgtdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfgjfhfogggtgfesthhqtddtredtjeenucfhrhhomhepffgrnhhi vghlucfuhhgrhhgrfhcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgeqne cuggftrfgrthhtvghrnhephfdtteefheevuedthedutdeifeegteettdejtdffheduieei jeelteetkeduteehnecukfhppeejledrudejiedrfeelrdeileenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdrshhh rghhrghfrdhnrghmvg X-ME-Proxy: Date: Wed, 17 Jun 2020 08:38:12 +0000 From: Daniel Shahaf To: Frederick Zhang Cc: zsh-workers@zsh.org Subject: Re: [PATCH] add missing read-only zfs property "space" Message-ID: <20200617083812.16ac8afc@tarpaulin.shahaf.local2> In-Reply-To: <20200605081136.82262-1-frederick888@tsundere.moe> References: <20200605081136.82262-1-frederick888@tsundere.moe> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Thanks for the patch. I see that =C2=ABzfs list -o space=C2=BB works, but I don't see any referen= ce to the value =C2=ABspace=C2=BB in the help output (`zfs list -o foobar 2>&1`) = or man page. Is that value supported and undocumented? Or is it undocumented because it's deprecated? workers@, could someone take over the review, please? I have a few patches to finish and don't want to spread myself too thin. Cheers, Daniel Frederick Zhang wrote on Fri, 05 Jun 2020 18:11 +1000: > Signed-off-by: Frederick Zhang > --- > Completion/Unix/Command/_zfs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > Although it's only documented under 'zfs list', it seems to be available > to other subcommands as well, e.g. 'zfs get'. >=20 > diff --git a/Completion/Unix/Command/_zfs b/Completion/Unix/Command/_zfs > index 814358bc7..452e1160d 100644 > --- a/Completion/Unix/Command/_zfs > +++ b/Completion/Unix/Command/_zfs > @@ -132,9 +132,9 @@ _zfs() { > ) > =20 > # TODO: userused@ and groupused@ could have more extensive handling > ro_properties=3D( > - "name" "type" "creation" "used" "available" "referenced" > + "name" "type" "creation" "space" "used" "available" "referenced" > "compressratio" "mounted" "origin" "usedbychildren" > "usedbydataset" "usedbyrefreservation" "usedbysnapshots" > "defer_destroy" "userused@" "userrefs" "groupused@" > "keychangedate" "keystatus" "rekeydate"