* [PATCH] add missing read-only zfs property "space" @ 2020-06-05 8:11 Frederick Zhang 2020-06-17 8:38 ` Daniel Shahaf 0 siblings, 1 reply; 4+ messages in thread From: Frederick Zhang @ 2020-06-05 8:11 UTC (permalink / raw) To: zsh-workers; +Cc: Frederick Zhang Signed-off-by: Frederick Zhang <frederick888@tsundere.moe> --- Completion/Unix/Command/_zfs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Although it's only documented under 'zfs list', it seems to be available to other subcommands as well, e.g. 'zfs get'. diff --git a/Completion/Unix/Command/_zfs b/Completion/Unix/Command/_zfs index 814358bc7..452e1160d 100644 --- a/Completion/Unix/Command/_zfs +++ b/Completion/Unix/Command/_zfs @@ -132,9 +132,9 @@ _zfs() { ) # TODO: userused@ and groupused@ could have more extensive handling ro_properties=( - "name" "type" "creation" "used" "available" "referenced" + "name" "type" "creation" "space" "used" "available" "referenced" "compressratio" "mounted" "origin" "usedbychildren" "usedbydataset" "usedbyrefreservation" "usedbysnapshots" "defer_destroy" "userused@" "userrefs" "groupused@" "keychangedate" "keystatus" "rekeydate" -- 2.27.0 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] add missing read-only zfs property "space" 2020-06-05 8:11 [PATCH] add missing read-only zfs property "space" Frederick Zhang @ 2020-06-17 8:38 ` Daniel Shahaf 2020-06-17 8:42 ` Frederick Zhang 0 siblings, 1 reply; 4+ messages in thread From: Daniel Shahaf @ 2020-06-17 8:38 UTC (permalink / raw) To: Frederick Zhang; +Cc: zsh-workers Thanks for the patch. I see that «zfs list -o space» works, but I don't see any reference to the value «space» in the help output (`zfs list -o foobar 2>&1`) or man page. Is that value supported and undocumented? Or is it undocumented because it's deprecated? workers@, could someone take over the review, please? I have a few patches to finish and don't want to spread myself too thin. Cheers, Daniel Frederick Zhang wrote on Fri, 05 Jun 2020 18:11 +1000: > Signed-off-by: Frederick Zhang <frederick888@tsundere.moe> > --- > Completion/Unix/Command/_zfs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Although it's only documented under 'zfs list', it seems to be available > to other subcommands as well, e.g. 'zfs get'. > > diff --git a/Completion/Unix/Command/_zfs b/Completion/Unix/Command/_zfs > index 814358bc7..452e1160d 100644 > --- a/Completion/Unix/Command/_zfs > +++ b/Completion/Unix/Command/_zfs > @@ -132,9 +132,9 @@ _zfs() { > ) > > # TODO: userused@ and groupused@ could have more extensive handling > ro_properties=( > - "name" "type" "creation" "used" "available" "referenced" > + "name" "type" "creation" "space" "used" "available" "referenced" > "compressratio" "mounted" "origin" "usedbychildren" > "usedbydataset" "usedbyrefreservation" "usedbysnapshots" > "defer_destroy" "userused@" "userrefs" "groupused@" > "keychangedate" "keystatus" "rekeydate" ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] add missing read-only zfs property "space" 2020-06-17 8:38 ` Daniel Shahaf @ 2020-06-17 8:42 ` Frederick Zhang 2020-06-17 14:01 ` Eric Cook 0 siblings, 1 reply; 4+ messages in thread From: Frederick Zhang @ 2020-06-17 8:42 UTC (permalink / raw) To: Daniel Shahaf; +Cc: zsh-workers [-- Attachment #1.1: Type: text/plain, Size: 2008 bytes --] It's documented in the man page under Subcommands -> zfs list: > -o property > (omitted) > • The value space to display space usage properties on file systems and volumes. This is a shortcut for specifying -o name,avail,used,usedsnap,usedds,usedrefreserv,usedchild -t filesystem,volume syntax. On 17/6/20 6:38 pm, Daniel Shahaf wrote: > Thanks for the patch. > > I see that «zfs list -o space» works, but I don't see any reference to > the value «space» in the help output (`zfs list -o foobar 2>&1`) or man > page. Is that value supported and undocumented? Or is it undocumented > because it's deprecated? > > workers@, could someone take over the review, please? I have a few > patches to finish and don't want to spread myself too thin. > > Cheers, > > Daniel > > > Frederick Zhang wrote on Fri, 05 Jun 2020 18:11 +1000: >> Signed-off-by: Frederick Zhang <frederick888@tsundere.moe> >> --- >> Completion/Unix/Command/_zfs | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> Although it's only documented under 'zfs list', it seems to be available >> to other subcommands as well, e.g. 'zfs get'. >> >> diff --git a/Completion/Unix/Command/_zfs b/Completion/Unix/Command/_zfs >> index 814358bc7..452e1160d 100644 >> --- a/Completion/Unix/Command/_zfs >> +++ b/Completion/Unix/Command/_zfs >> @@ -132,9 +132,9 @@ _zfs() { >> ) >> >> # TODO: userused@ and groupused@ could have more extensive handling >> ro_properties=( >> - "name" "type" "creation" "used" "available" "referenced" >> + "name" "type" "creation" "space" "used" "available" "referenced" >> "compressratio" "mounted" "origin" "usedbychildren" >> "usedbydataset" "usedbyrefreservation" "usedbysnapshots" >> "defer_destroy" "userused@" "userrefs" "groupused@" >> "keychangedate" "keystatus" "rekeydate" > -- Best regards, Frederick Zhang Email: frederick888@tsundere.moe PGP: 8BFB EA5B 4C44 BFAC C8EC 5F93 1F92 8BE6 0D8B C11D [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] add missing read-only zfs property "space" 2020-06-17 8:42 ` Frederick Zhang @ 2020-06-17 14:01 ` Eric Cook 0 siblings, 0 replies; 4+ messages in thread From: Eric Cook @ 2020-06-17 14:01 UTC (permalink / raw) To: zsh-workers On 6/17/20 4:42 AM, Frederick Zhang wrote: > It's documented in the man page under Subcommands -> zfs list: > >> -o property >> (omitted) >> • The value space to display space usage properties on file systems and volumes. This is a shortcut for specifying -o name,avail,used,usedsnap,usedds,usedrefreserv,usedchild -t filesystem,volume syntax. > I've merged your patch, thank you for the submission. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-17 14:02 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-06-05 8:11 [PATCH] add missing read-only zfs property "space" Frederick Zhang 2020-06-17 8:38 ` Daniel Shahaf 2020-06-17 8:42 ` Frederick Zhang 2020-06-17 14:01 ` Eric Cook
Code repositories for project(s) associated with this public inbox https://git.vuxu.org/mirror/zsh/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).