zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Manuel Jacob <me@manueljacob.de>, zsh-workers@zsh.org
Subject: vcs_info patch-format/applied-string awareness? (was: Re: [PATCH] Add code to Mercurial VCS backend to show topic if there is any.)
Date: Fri, 19 Jun 2020 10:46:26 +0000	[thread overview]
Message-ID: <20200619104626.6689220f@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <20200619100731.099deac3@tarpaulin.shahaf.local2>

Daniel Shahaf wrote on Fri, 19 Jun 2020 10:07 +0000:
> Manuel Jacob wrote on Fri, 19 Jun 2020 04:06 +0200:
> > I’m concerned that most people won’t use the feature because they’re
> > not aware that it exists.  
> 
> Fair point.  Let's first see if we can enable the feature without user
> interaction at all.  If that doesn't pan out, then we can see about
> addressing the lack of awareness.

By the way, I think this point applies to the "show patch series"
functionality too.  That functionality is used by several vcs backends
(e.g., quilt, hg mq, git rebase), but is not enabled by default and
I suspect many people don't know it exists.

I'm referring to this:

[[[
$ cd Functions/VCS_Info/
$ rm -rf vcs-test/ 
$ zsh ./test-repo-git-rebase-apply
⋮
CONFLICT (content): Merge conflict in iota
⋮
zsh: exit 1     zsh ./test-repo-git-rebase-apply
$ (cd vcs-test/ && zsh) 
myref/rebase/+ f973ee0a1fe5
[5+2=7] ea03c123a587 r7: Append a line
% 
]]]

See the "[5+2=7] ea03c123a587 r7: Append a line" line.  (That line was
generated by setting zstyles to values such as those given in comments
at the top of ./test-repo-git-rebase-apply, plus some fine-tuning by
zshrc hooks.)

So, should we have patch series information displayed by default?  The
information about applied patches is parsed by default, but not shown
by default because the %m expando isn't in the default formats/actionformats
values.

Or alternatively, should we increase awareness of it?

Cheers,

Daniel

P.S.  The hg backend doesn't seem to support equivalent functionality
for the rebase/histedit commands; see the VCS_INFO_set-patch-format call.
hg mq support is present but not enabled by default.

  reply	other threads:[~2020-06-19 10:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-07  7:44 [PATCH] Add code to Mercurial VCS backend to show topic if there is any Manuel Jacob
2020-06-07 12:14 ` Daniel Shahaf
2020-06-07 13:31   ` Manuel Jacob
2020-06-08  5:31     ` Daniel Shahaf
2020-06-09  1:15       ` Manuel Jacob
2020-06-09 22:34         ` Daniel Shahaf
2020-06-17  8:27           ` Daniel Shahaf
2020-06-19  2:06             ` Manuel Jacob
2020-06-19 10:07               ` Daniel Shahaf
2020-06-19 10:46                 ` Daniel Shahaf [this message]
2020-06-19 22:48                   ` vcs_info patch-format/applied-string awareness? Manuel Jacob
2020-06-20  9:54                     ` Daniel Shahaf
2020-06-20 22:06                       ` Manuel Jacob
2020-06-19 23:29                 ` [PATCH] Add code to Mercurial VCS backend to show topic if there is any Manuel Jacob
2020-06-20 10:43                   ` Daniel Shahaf
2020-06-07 13:49 ` Manuel Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200619104626.6689220f@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=me@manueljacob.de \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).