zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsugabubus <zsugabubus@national.shitposting.agency>
Cc: zsh-workers@zsh.org
Subject: Re: Useless assignment in _rm
Date: Tue, 23 Jun 2020 12:40:15 +0000	[thread overview]
Message-ID: <20200623124015.3a97ed8b@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <20200622102738.56fotlwrsbckxgzh@localhost>

zsugabubus wrote on Mon, 22 Jun 2020 12:27 +0200:
> diff --git a/Completion/Unix/Command/_rm b/Completion/Unix/Command/_rm
> index ea9190d..e66b77f 100644
> --- a/Completion/Unix/Command/_rm
> +++ b/Completion/Unix/Command/_rm
> @@ -69,7 +69,7 @@ _arguments -C -s -S $opts \
> 
>  case $state in
>    (file)
> -    line[CURRENT]=()
> +    (( CURRENT > 0 )) && line[CURRENT]=()
>      line=( ${line//(#m)[\[\]()\\*?#<>~\^\|]/\\$MATCH} )
>      _files -F line && ret=0
>      ;;

Thanks; I'll commit this unless someone sees a reason not to.

In the future, could you put patches _above_ the dash-dash-space line?
Many MUAs trim by default everything after that line.

Thanks,

Daniel

  reply	other threads:[~2020-06-23 12:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-21 12:09 zsugabubus
2020-06-21 13:32 ` Daniel Shahaf
2020-06-22 10:27   ` zsugabubus
2020-06-23 12:40     ` Daniel Shahaf [this message]
2020-06-28 13:13       ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200623124015.3a97ed8b@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    --cc=zsugabubus@national.shitposting.agency \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).