From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 5062 invoked from network); 23 Jun 2020 12:40:59 -0000
Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2)
  by inbox.vuxu.org with ESMTPUTF8; 23 Jun 2020 12:40:59 -0000
Received: (qmail 11533 invoked by alias); 23 Jun 2020 12:40:53 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
Sender: zsh-workers@zsh.org
X-Seq: 46103
Received: (qmail 10901 invoked by uid 1010); 23 Jun 2020 12:40:53 -0000
X-Qmail-Scanner-Diagnostics: from out3-smtp.messagingengine.com by f.primenet.com.au (envelope-from <d.s@daniel.shahaf.name>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.102.3/25850. spamassassin: 3.4.4.  
 Clear:RC:0(66.111.4.27):SA:0(-2.6/5.0):. 
 Processed in 0.710427 secs); 23 Jun 2020 12:40:53 -0000
X-Envelope-From: d.s@daniel.shahaf.name
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts)
X-ME-Sender: <xms:M_jxXg1YiO_rp-opKv67lkLZrzgb7Kuk0swvrdOJoN1ztB0iQkoyNQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudekhedgvdekucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkjghfofggtgfgsehtje
    dttdertddvnecuhfhrohhmpeffrghnihgvlhcuufhhrghhrghfuceougdrshesuggrnhhi
    vghlrdhshhgrhhgrfhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeefudetgeevhedvhf
    etveetvdduleduieejueduueejjedtteeutdejhfdtgfeiteenucfkphepjeelrddujeei
    rdefledrieelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
    homhepugdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgv
X-ME-Proxy: <xmx:M_jxXrFHGza1-PxKX76Xpvhfb2-Qux4W0CnshZX63eFGdWB0j8VL6g>
    <xmx:M_jxXo7kkhh4nhKFY0be9mm7XPT1tHB8x0MHkbPqFKSW493kqnMPcw>
    <xmx:M_jxXp1Qrovg2wvIrykXzRo6JEONTtjHWJP8cal0_74XqibDB9MuCQ>
    <xmx:M_jxXjFIptcGnaIeORGmjhDeF5zNPS8oLVEYyXG-LpRZ8pmjAXXBYw>
Date: Tue, 23 Jun 2020 12:40:15 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsugabubus <zsugabubus@national.shitposting.agency>
Cc: zsh-workers@zsh.org
Subject: Re: Useless assignment in _rm
Message-ID: <20200623124015.3a97ed8b@tarpaulin.shahaf.local2>
In-Reply-To: <20200622102738.56fotlwrsbckxgzh@localhost>
References: <20200621120913.tk5caqwb3ob2r6wt@localhost>
	<20200621133257.2c4b679d@tarpaulin.shahaf.local2>
	<20200622102738.56fotlwrsbckxgzh@localhost>
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

zsugabubus wrote on Mon, 22 Jun 2020 12:27 +0200:
> diff --git a/Completion/Unix/Command/_rm b/Completion/Unix/Command/_rm
> index ea9190d..e66b77f 100644
> --- a/Completion/Unix/Command/_rm
> +++ b/Completion/Unix/Command/_rm
> @@ -69,7 +69,7 @@ _arguments -C -s -S $opts \
> 
>  case $state in
>    (file)
> -    line[CURRENT]=()
> +    (( CURRENT > 0 )) && line[CURRENT]=()
>      line=( ${line//(#m)[\[\]()\\*?#<>~\^\|]/\\$MATCH} )
>      _files -F line && ret=0
>      ;;

Thanks; I'll commit this unless someone sees a reason not to.

In the future, could you put patches _above_ the dash-dash-space line?
Many MUAs trim by default everything after that line.

Thanks,

Daniel