zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Sebastian Gniazdowski <sgniazdowski@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [BUG] zsystem:34: flock: invalid timeout value: '0'
Date: Fri, 26 Jun 2020 14:16:44 +0000	[thread overview]
Message-ID: <20200626141644.7cb5e511@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CAKc7PVAm3Wp9Gme42qNQeLo=QE8A2ZvcjcyQqw=aRQa2UDNX0w@mail.gmail.com>

Sebastian Gniazdowski wrote on Thu, 25 Jun 2020 19:49 +0200:
> Hi
> I think that something happened to zsystem / flock, as the following
> returns the above error under Cygwin:
> 
> $ zsystem flock -t 0 -f FD -e /home/SG/.zsh_nr1
> zsystem:34: flock: invalid timeout value: '0'
> 
> Timeout of value 0 is an acceptable one - it means no waiting for the lock,
> just try-to-lock and exit.

You've neglected to identify the environment it works in, the
environment number it doesn't work in, and the reason you didn't do
a bisect as courtesy prescribes.

In this case, system.c gets so few commits that a bisect is almost
a formality.  The bug is likely to have been introduced by workers/45708.

I recommend that you test the behaviour with and without that commit
and reported the results.

I further recommend that, if you have time, you also prepare a patch,
or at least an expected-to-fail regression test (using the 'f' flag
after the exit code).

  reply	other threads:[~2020-06-26 14:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-25 17:49 Sebastian Gniazdowski
2020-06-26 14:16 ` Daniel Shahaf [this message]
2020-06-26 19:42   ` Sebastian Gniazdowski
2020-06-27  1:47     ` Daniel Shahaf
2020-06-27  2:04       ` Bart Schaefer
2020-06-27  7:13         ` Cedric Ware
2020-06-27  7:27           ` Roman Perepelitsa
2020-06-27 17:01             ` Bart Schaefer
2020-06-27 17:12               ` Roman Perepelitsa
2020-06-27 17:58                 ` Bart Schaefer
2020-06-27 18:09                   ` Roman Perepelitsa
2020-06-27 20:38             ` Cedric Ware
2020-06-28  9:27               ` Roman Perepelitsa
2020-07-10 15:28                 ` Sebastian Gniazdowski
2020-07-11  5:18                   ` dana
2020-06-27 17:25           ` Sebastian Gniazdowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200626141644.7cb5e511@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=sgniazdowski@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).