From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 20291 invoked from network); 28 Jun 2020 13:14:34 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 28 Jun 2020 13:14:34 -0000 Received: (qmail 275 invoked by alias); 28 Jun 2020 13:14:24 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: Sender: zsh-workers@zsh.org X-Seq: 46159 Received: (qmail 25981 invoked by uid 1010); 28 Jun 2020 13:14:24 -0000 X-Qmail-Scanner-Diagnostics: from out1-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25850. spamassassin: 3.4.4. Clear:RC:0(66.111.4.25):SA:0(-2.6/5.0):. Processed in 4.125984 secs); 28 Jun 2020 13:14:24 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeliedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkjghfofggtgfgsehtje dttdertddvnecuhfhrohhmpeffrghnihgvlhcuufhhrghhrghfuceougdrshesuggrnhhi vghlrdhshhgrhhgrfhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeefudetgeevhedvhf etveetvdduleduieejueduueejjedtteeutdejhfdtgfeiteenucfkphepjeelrddujeei rdefledrieelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepugdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Date: Sun, 28 Jun 2020 13:13:37 +0000 From: Daniel Shahaf To: zsugabubus Cc: zsh-workers@zsh.org Subject: Re: Useless assignment in _rm Message-ID: <20200628131337.16548f69@tarpaulin.shahaf.local2> In-Reply-To: <20200623124015.3a97ed8b@tarpaulin.shahaf.local2> References: <20200621120913.tk5caqwb3ob2r6wt@localhost> <20200621133257.2c4b679d@tarpaulin.shahaf.local2> <20200622102738.56fotlwrsbckxgzh@localhost> <20200623124015.3a97ed8b@tarpaulin.shahaf.local2> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Daniel Shahaf wrote on Tue, 23 Jun 2020 12:40 +0000: > zsugabubus wrote on Mon, 22 Jun 2020 12:27 +0200: > > diff --git a/Completion/Unix/Command/_rm b/Completion/Unix/Command/_rm > > index ea9190d..e66b77f 100644 > > --- a/Completion/Unix/Command/_rm > > +++ b/Completion/Unix/Command/_rm > > @@ -69,7 +69,7 @@ _arguments -C -s -S $opts \ > > > > case $state in > > (file) > > - line[CURRENT]=() > > + (( CURRENT > 0 )) && line[CURRENT]=() > > line=( ${line//(#m)[\[\]()\\*?#<>~\^\|]/\\$MATCH} ) > > _files -F line && ret=0 > > ;; > > Thanks; I'll commit this unless someone sees a reason not to. Applied, thanks. I edited your vanity plate of an email address out. I'm afraid it amounts to name-calling and as such has no place in official documentation, which ChangeLog is. Also, I forgot to say it before, thanks for auditing other uses of *:: and *:::.