zsh-workers
 help / color / mirror / code / Atom feed
* Incoming patch for fix to zsh man page
@ 2020-07-06 10:50 Pete Moore
  2020-07-06 10:50 ` [PATCH] Remove spurious open bracket in " Pete Moore
  0 siblings, 1 reply; 4+ messages in thread
From: Pete Moore @ 2020-07-06 10:50 UTC (permalink / raw)
  To: zsh-workers


Hi all,

I wasn't sure if I should send the patch directly here or create
a github PR, so I've done both!

The incoming patch is a copy of https://github.com/zsh-users/zsh/pull/59

Many thanks,
Pete


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] Remove spurious open bracket in zsh man page
  2020-07-06 10:50 Incoming patch for fix to zsh man page Pete Moore
@ 2020-07-06 10:50 ` Pete Moore
  2020-07-06 23:44   ` Daniel Shahaf
  0 siblings, 1 reply; 4+ messages in thread
From: Pete Moore @ 2020-07-06 10:50 UTC (permalink / raw)
  To: zsh-workers; +Cc: Pete Moore

---
 Doc/Zsh/metafaq.yo | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Doc/Zsh/metafaq.yo b/Doc/Zsh/metafaq.yo
index c123a7cea..e41b88dc5 100644
--- a/Doc/Zsh/metafaq.yo
+++ b/Doc/Zsh/metafaq.yo
@@ -25,7 +25,6 @@ cindex(acquiring zsh by FTP)
 cindex(availability of zsh)
 nofill(uref(ftp://ftp.zsh.org/pub/)
 uref(https://www.zsh.org/pub/))
-)
 
 The up-to-date source code is available via Git from Sourceforge.  See
 uref(https://sourceforge.net/projects/zsh/) for details.  A summary of
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Remove spurious open bracket in zsh man page
  2020-07-06 10:50 ` [PATCH] Remove spurious open bracket in " Pete Moore
@ 2020-07-06 23:44   ` Daniel Shahaf
  2020-07-07  7:33     ` Peter Moore
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Shahaf @ 2020-07-06 23:44 UTC (permalink / raw)
  To: Pete Moore; +Cc: zsh-workers

Pete Moore wrote on Mon, 06 Jul 2020 12:50 +0200:
> ---
>  Doc/Zsh/metafaq.yo | 1 -
>  1 file changed, 1 deletion(-)

Thanks!  Merged with a changed log message.

Quick question: The patch removes a _closing_ bracket but the log
message spoke of an _opening_ bracket.  Is there a stray opening
bracket somewhere as well?

For patch submission we prefer email to GitHub.  Thanks for covering
all the bases, though!

Cheers,

Daniel

> diff --git a/Doc/Zsh/metafaq.yo b/Doc/Zsh/metafaq.yo
> index c123a7cea..e41b88dc5 100644
> --- a/Doc/Zsh/metafaq.yo
> +++ b/Doc/Zsh/metafaq.yo
> @@ -25,7 +25,6 @@ cindex(acquiring zsh by FTP)
>  cindex(availability of zsh)
>  nofill(uref(ftp://ftp.zsh.org/pub/)
>  uref(https://www.zsh.org/pub/))
> -)
>  
>  The up-to-date source code is available via Git from Sourceforge.  See
>  uref(https://sourceforge.net/projects/zsh/) for details.  A summary of


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Remove spurious open bracket in zsh man page
  2020-07-06 23:44   ` Daniel Shahaf
@ 2020-07-07  7:33     ` Peter Moore
  0 siblings, 0 replies; 4+ messages in thread
From: Peter Moore @ 2020-07-07  7:33 UTC (permalink / raw)
  To: Daniel Shahaf; +Cc: zsh-workers

Thanks Daniel! Indeed the log message was incorrect; it was indeed a spurious closing bracket. Thanks for correcting!

Pete


> On 7. Jul 2020, at 01:44, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> 
> Pete Moore wrote on Mon, 06 Jul 2020 12:50 +0200:
>> ---
>> Doc/Zsh/metafaq.yo | 1 -
>> 1 file changed, 1 deletion(-)
> 
> Thanks!  Merged with a changed log message.
> 
> Quick question: The patch removes a _closing_ bracket but the log
> message spoke of an _opening_ bracket.  Is there a stray opening
> bracket somewhere as well?
> 
> For patch submission we prefer email to GitHub.  Thanks for covering
> all the bases, though!
> 
> Cheers,
> 
> Daniel
> 
>> diff --git a/Doc/Zsh/metafaq.yo b/Doc/Zsh/metafaq.yo
>> index c123a7cea..e41b88dc5 100644
>> --- a/Doc/Zsh/metafaq.yo
>> +++ b/Doc/Zsh/metafaq.yo
>> @@ -25,7 +25,6 @@ cindex(acquiring zsh by FTP)
>> cindex(availability of zsh)
>> nofill(uref(ftp://ftp.zsh.org/pub/)
>> uref(https://www.zsh.org/pub/))
>> -)
>> 
>> The up-to-date source code is available via Git from Sourceforge.  See
>> uref(https://sourceforge.net/projects/zsh/) for details.  A summary of
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-07-07  7:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-06 10:50 Incoming patch for fix to zsh man page Pete Moore
2020-07-06 10:50 ` [PATCH] Remove spurious open bracket in " Pete Moore
2020-07-06 23:44   ` Daniel Shahaf
2020-07-07  7:33     ` Peter Moore

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).