zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Vin Shelton <acs@alumni.princeton.edu>
Cc: Bart Schaefer <schaefer@brasslantern.com>,
	"Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: Five New Test Failures
Date: Tue, 7 Jul 2020 16:03:00 +0000	[thread overview]
Message-ID: <20200707160300.1f33cd0b@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CACeGjnWkkXui2NJb8XiVe3Z91BkFTUexHkzfzWHh+6PNc73eZA@mail.gmail.com>

Vin Shelton wrote on Tue, 07 Jul 2020 10:14 -0400:
> Thanks, Bart.  That fixes four of the five failures.  All except this one:
> 
> ../../../src/zsh-2020-07-07/Test/E01options.ztst: starting.
> This test hangs the shell when it fails...
> Pattern match failed, line 1:
> -<zsh: sure you want to delete all 15 files in
> /opt/build/zsh-2020-07-07/Test/options.tmp \[yn\]\?
>  <zsh: sure you want to delete all <-> files in / \[yn\]\?
> +>nuc2% zsh: sure you want to delete all 15 files in
> /opt/build/zsh-2020-07-07/Test/options.tmp [yn]?
>  >nuc2% zsh: sure you want to delete all 28 files in / [yn]?

Well, it's my patch, but I can't reproduce the failure.  I'm guessing
it's the prompt at the start that causes it, but I'm not sure why it'd
be printed in Vin's setup but not in mine.

In the meantime, a theoretical fix for the case of /* expanding to more than 100 names:

diff --git a/Test/E01options.ztst b/Test/E01options.ztst
index c59509f2e..7b8e3940e 100644
--- a/Test/E01options.ztst
+++ b/Test/E01options.ztst
@@ -1449,4 +1449,4 @@ F:If this test fails at the first unsetopt, refer to P01privileged.ztst.
   BEL=$'\a'
 0q:RM_STAR_SILENT
 *>zsh: sure you want to delete all 15 files in ${PWD:h}/options.tmp \[yn\]\? ${BEL}
-*>zsh: sure you want to delete all <-> files in / \[yn\]\? ${BEL}
+*>zsh: sure you want to delete (more than <->|all <->) files in / \[yn\]\? ${BEL}

  reply	other threads:[~2020-07-07 16:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-05 15:28 Vin Shelton
2020-07-05 16:28 ` Bart Schaefer
2020-07-05 16:57   ` Bart Schaefer
2020-07-05 17:22     ` Bart Schaefer
2020-07-07 14:14       ` Vin Shelton
2020-07-07 16:03         ` Daniel Shahaf [this message]
2020-07-07 16:39           ` Bart Schaefer
2020-07-07 19:33             ` Vin Shelton
2020-07-08  0:25         ` Jun T
2020-07-08  1:03           ` Vin Shelton
2020-07-08 10:49           ` Jun T
2020-07-08 18:23             ` Vin Shelton
2020-07-08 20:30               ` Bart Schaefer
2020-07-08 20:55                 ` Vin Shelton
2020-07-09  8:04               ` Jun T
2020-07-11  0:02                 ` Daniel Shahaf
2020-07-09 10:17             ` Jun T
2020-07-11  0:03               ` Daniel Shahaf
2020-07-05 16:54 ` Message size limit? (was: Five New Test Failures) Daniel Shahaf
2020-07-05 17:13   ` Vin Shelton
2020-07-07 16:06     ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200707160300.1f33cd0b@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=acs@alumni.princeton.edu \
    --cc=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).