From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 23795 invoked from network); 28 Jul 2020 07:54:37 -0000 Received: from ns1.primenet.com.au (HELO primenet.com.au) (203.24.36.2) by inbox.vuxu.org with ESMTPUTF8; 28 Jul 2020 07:54:37 -0000 Received: (qmail 21639 invoked by alias); 28 Jul 2020 07:54:26 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: Sender: zsh-workers@zsh.org X-Seq: 46271 Received: (qmail 861 invoked by uid 1010); 28 Jul 2020 07:54:26 -0000 X-Qmail-Scanner-Diagnostics: from wout3-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.3/25884. spamassassin: 3.4.4. Clear:RC:0(64.147.123.19):SA:0(-2.6/5.0):. Processed in 1.994207 secs); 28 Jul 2020 07:54:26 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedriedugdduvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfgjfhfogggtgfesthejtddtredtvdenucfhrhhomhepffgrnhhi vghlucfuhhgrhhgrfhcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgeqne cuggftrfgrthhtvghrnhepfeduteegveehvdfhteevtedvudeludeijeeuudeujeejtdet uedtjefhtdfgieetnecukfhppedutdelrdeigedrudeguddrieejnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepugdrshesuggrnhhivghlrdhs hhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Date: Tue, 28 Jul 2020 07:53:43 +0000 From: Daniel Shahaf To: Roman Perepelitsa Cc: Tomasz =?UTF-8?B?S8WCb2N6a28=?= , Zsh hackers list Subject: Re: 5.8: LTO exposes some new issues Message-ID: <20200728075343.2cfb1ebf@tarpaulin.shahaf.local2> In-Reply-To: References: <35bf1c7b-163f-4baf-9d5a-c1d7e72459ec@www.fastmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Roman Perepelitsa wrote on Mon, 27 Jul 2020 14:19 +0200: > +++ b/Src/zsh.h > @@ -1205,9 +1207,15 @@ struct hashtable { > -#ifdef HASHTABLE_INTERNAL_MEMBERS > - HASHTABLE_INTERNAL_MEMBERS /* internal use in hashtable.c */ > -#endif > + /* HASHTABLE INTERNAL MEMBERS */ > + ScanStatus scan; /* status of a scan over this hashtable */ > + > +#ifdef ZSH_HASH_DEBUG > + /* Members of struct hashtable used for debugging hash tables */ \ > + HashTable next, last; /* linked list of all hash tables */ \ > + char *tablename; /* string containing name of the hash table */ \ > + PrintTableStats printinfo; /* pointer to function to print table stats */ > +#endif /* !ZSH_HASH_DEBUG */ > }; Thanks for looking into this. It's clearly correct, but as written, the patch loses the distinction that these members are private to hashtable.c and should not be accessed by other parts of the code. Could you address that, please? If there's an easy way to have the compiler enforce this restriction, great; else, we can at least add a comment. Cheers, Daniel