From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 23085 invoked from network); 25 Sep 2020 06:34:40 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 25 Sep 2020 06:34:40 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1601015680; b=zFoIjUy80/60O5dkyehGZFkccOQFctoRHhFTw5KylcChB50NK74M82j7EWBEVtZ3AzpfPT1Rly s5k+Sc6h6o468H0xlbkVG/pGIEk9WkqS1mOQguPtRxasXfs11drvNyTJ3NfW//MyO8VPL3VjeY Su//qGs+PzOXOt80gWJfpRLzBqO+0dAv9XyfHUrH10KQwi7FJlNUzPwqq3+AKPN17CpuETwgp/ 0okvCxt6EDUqkDujQO5tGDLGkbJwJpBo7gkfWbtp2UXW0lk2DC1dzt3RgmM5eHfur3PsDjke1s /MfeMULTxCYL02jqMVHMIFkS4JKtI/M7rcuzvaQ/ui7Dhw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out4-smtp.messagingengine.com) smtp.remote-ip=66.111.4.28; dkim=pass header.d=daniel.shahaf.name header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm3 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1601015680; bh=gTNRuRYG/aylDMjn8WEDtz2ZGRdcdJuJvG9sHKG75uQ=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=PzCsyZnwtaf5uHBFL7tpEp05xQfCfN5VbrOrkSSyg8q0UOre8yIYM/ctLykdtW8BlcNowoQKp2 bz/kV1KmIPVRe64nZGmCJxuXb2Gg3fmgPmDf5FPWc+aerKvzsZO3ykTbthNq1RJclC63XnO/c2 yAIiJ5qnhfwyHXsQ8ahxdzyK7xQgq6vtitPzQ1UO43OZ028K3LJ/+/G9zfy4FUSNM5sACAsQNF 85wSWo8SIAF5D0C2v2VSIsyTJ7QCpa4rS/ps+0eFMP0x7IWMf0gqYdPFu5eQeaPKFFAz9TyExt KsoprWSA0D9UpxF1XYwd2ADJ/h9OLnfYI6wshpnEQCqbeA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=YcF652I765qxtx7yzu/l2ImOzxoUJcaAFP26IjDkFbk=; b=UbuObejAPtCJGd65eNN/LAh/28 Xy2U9FcwPFYihR9eFoHlBZfE3Dd+wZOXWRKktxtl176/BgVKliBazHkpk50RFk3T43KfUuMa6noaA vQ0YYGRpv8EqSYZQwF7+3kupbUCegfSONJc2t4ZifTMLuuVAhSoPgNAwCk8tZKK9bavHWfuls60af zWfhS27LFn2wVTKXH6NVIw5u39DYUMsZQsPqgaYsMy1BUVX1ZOrHeDJN+gKVPPrbtbLCEmW+o6qFz +Da8BwqIK/SnxUvQxz5XrPMlb3Ia5QI/dSeMv2wdPkUFkELk5Ro2eDAQXpDqmRfJICInfFLQuHLtP zAOIFKrA==; Received: from authenticated user by zero.zsh.org with local id 1kLhJT-000FIH-EH; Fri, 25 Sep 2020 06:34:35 +0000 Authentication-Results: zsh.org; iprev=pass (out4-smtp.messagingengine.com) smtp.remote-ip=66.111.4.28; dkim=pass header.d=daniel.shahaf.name header.s=fm1 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm3 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out4-smtp.messagingengine.com ([66.111.4.28]:52893) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1kLhJ8-000F9U-Ov; Fri, 25 Sep 2020 06:34:15 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id F3BB15C01C5; Fri, 25 Sep 2020 02:34:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 25 Sep 2020 02:34:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm1; bh=YcF652I765qxtx7yzu/l2ImOzxoUJcaAFP26IjDk Fbk=; b=eQwKQp8Iq3s08NN01NZRD0jb4T/lUIBImnmqx7oe4OgRYTCsmzjWt9EX kEe/DQaDsI72A6zEsJe/pViOzEig42NotpCkKQy9yAIQmIfg0AXp16lxXYSEiA/C pMHfbSeH/jxM1g/rE5mXl3uSJa8zCQgvv8fNQ2npJy3n+ksy4ViQnPcmjspQX6ob Xnu6oqAkMGiTpyyhZwD/vdJElJSqH+f5r04Inj7sncHv6tMDaVw226FnueaDJ9/T L3gZSqNFOlXdq3LpCzTvsLfXAvuflSr9p8ldyqpW/23y7CuOsyR7Eo5M/xvHrgR6 yfYRAtHE2BpJM6kv5BaGW6nkxPjvhw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=YcF652I765qxtx7yzu/l2ImOzxoUJcaAFP26IjDkF bk=; b=Qrl8jpfYQG7ywRYe3ACi8456BoeLm8wWx3/Rtsj40RciFmHuspzKRRscx 8n4F2a5QVfi7Tr8bDQ/8OYma8VLLPY3FH/X3kAY4HAAYFkFok8D2qD4o21/EgUvE E2y0Ui6MNrx6PJH960z70zJMk8lF0D3fGRC/ZfEQmacqvto09BSydTrs1oFee2J+ JC4ojgZHsKIvnsaurbyI8dQDLh+7wXq01Qi3dBVJvpV7fUdKuYHMGyH8HkEmNAdT VouwZd9i1w2kwvkdzG4ZVb4OHZEoIFh0tdOAkeRgs5MKtV4eir9TNaAO/YO9Mp0F FCq6DYv+AEd2wQLkWd4vJ7c2WlkFw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudelgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjggfsehtkedttddtredunecuhfhrohhmpeffrghn ihgvlhcuufhhrghhrghfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpefgleehtdffuefhgeeuleefffejgedttdelhedvvdeuiefh vefgvdfghfevvdekteenucfkphepuddtledrieehrdefvddrudekfeenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdr shhhrghhrghfrdhnrghmvg X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-109-65-32-183.red.bezeqint.net [109.65.32.183]) by mail.messagingengine.com (Postfix) with ESMTPA id 715B7328005D; Fri, 25 Sep 2020 02:34:13 -0400 (EDT) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1000) id 4ByMZX0Dp0zw8; Fri, 25 Sep 2020 06:34:11 +0000 (UTC) Date: Fri, 25 Sep 2020 06:34:11 +0000 From: Daniel Shahaf To: Guido Cella Cc: zsh-workers@zsh.org Subject: Re: [PATCH] _git-grep: Complete files when outside git repos Message-ID: <20200925063411.GD29504@tarpaulin.shahaf.local2> References: <20200924203441.80963-1-guidocella91@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200924203441.80963-1-guidocella91@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 47398 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Guido Cella wrote on Thu, Sep 24, 2020 at 22:34:41 +0200: > --- > Completion/Unix/Command/_git | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git > index 05e2a23..67f06c5 100644 > --- a/Completion/Unix/Command/_git > +++ b/Completion/Unix/Command/_git > @@ -1037,6 +1037,12 @@ _git-grep () { > # don't complete treeishs. > case $state in > (tree-or-file) > + # Check if we're not in a git repository. > + if ! git rev-parse 2>/dev/null; then > + _files && ret=0 > + return ret > + fi Why is this correct? When cwd isn't a repository, «git grep foo ./bar» just errors out: . % ls iota % git grep This iota fatal: not a git repository (or any parent up to mount point /) Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set). zsh: exit 128 Does newer git behave differently? If not, shouldn't the behaviour be conditional on --no-index having been passed? > integer first_tree last_tree start end i > > (( start = words[(I)(-f|-e)] > 0 ? 1 : 2 )) > -- > 2.28.0 > >