zsh-workers
 help / color / mirror / code / Atom feed
* [PATCH v2] _git-grep: Complete files when outside git repos
@ 2020-09-25  7:47 Guido Cella
  2020-09-25  7:52 ` Guido Cella
  2020-09-26 10:23 ` [PATCH v3] " Guido Cella
  0 siblings, 2 replies; 4+ messages in thread
From: Guido Cella @ 2020-09-25  7:47 UTC (permalink / raw)
  To: zsh-workers

---
 Completion/Unix/Command/_git | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
index 05e2a23..2847d1c 100644
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -1033,10 +1033,21 @@ _git-grep () {
     ': :_guard "^-*" pattern' \
     '*:: :->tree-or-file' && ret=0
 
-  # TODO: If --cached, --no-index, -O, or --open-files-in-pager was given,
+  # TODO: If --cached, -O, or --open-files-in-pager was given,
   # don't complete treeishs.
   case $state in
     (tree-or-file)
+      # Check if we're not in a git repository
+      # from the exit status of an arbitrary git command.
+      if ! git rev-parse 2>/dev/null && [[
+        words[(I)--no-index] -ne 0 ||
+        "$(_call_program get-grep-fallbacktonoindex-option git config --type=bool grep.fallbackToNoIndex)" \
+        == 'true'
+      ]]; then
+        _files && ret=0
+        return ret
+      fi
+
       integer first_tree last_tree start end i
 
       (( start = words[(I)(-f|-e)] > 0 ? 1 : 2 ))
@@ -1052,7 +1063,7 @@ _git-grep () {
         fi
       done
 
-      # TODO: Need to respect --cached and --no-index here.
+      # TODO: Need to respect --cached here.
       if (( last_tree == 0 || last_tree == end )); then
         if (( first_tree == 0 )); then
           _alternative \
-- 
2.28.0



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-09-26 10:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-25  7:47 [PATCH v2] _git-grep: Complete files when outside git repos Guido Cella
2020-09-25  7:52 ` Guido Cella
2020-09-26  5:27   ` Mikael Magnusson
2020-09-26 10:23 ` [PATCH v3] " Guido Cella

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).