From: Matthew Martin <phy1729@gmail.com>
To: zsh-workers@zsh.org
Subject: [patch] Avoid race in zf_mkdir
Date: Fri, 9 Oct 2020 15:07:37 -0500 [thread overview]
Message-ID: <20201009200737.GA78914@CptOrmolo.darkstar> (raw)
A user reported in #zsh they were seeing sporadic zf_mkdir errors when
concurrently creating the same directory. Move the stat ISDIR check to
after the mkdir call to avoid the race.
diff --git a/Src/Modules/files.c b/Src/Modules/files.c
index 6d20e38a8..ae301c14f 100644
--- a/Src/Modules/files.c
+++ b/Src/Modules/files.c
@@ -124,17 +124,17 @@ domkdir(char *nam, char *path, mode_t mode, int p)
mode_t oumask;
char const *rpath = unmeta(path);
+ oumask = umask(0);
+ err = mkdir(rpath, mode) ? errno : 0;
+ umask(oumask);
+ if(!err)
+ return 0;
if(p) {
struct stat st;
if(!stat(rpath, &st) && S_ISDIR(st.st_mode))
return 0;
}
- oumask = umask(0);
- err = mkdir(rpath, mode) ? errno : 0;
- umask(oumask);
- if(!err)
- return 0;
zwarnnam(nam, "cannot make directory `%s': %e", path, err);
return 1;
}
next reply other threads:[~2020-10-09 20:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 20:07 Matthew Martin [this message]
2020-10-09 20:24 ` Bart Schaefer
2020-10-09 20:35 ` Roman Perepelitsa
2020-10-09 20:47 ` Bart Schaefer
2020-10-09 20:53 ` Matthew Martin
2020-10-09 21:22 ` Roman Perepelitsa
2020-10-09 21:27 ` Bart Schaefer
2020-10-10 11:50 ` Roman Perepelitsa
2020-10-15 10:01 ` Roman Perepelitsa
2020-10-15 15:29 ` Bart Schaefer
2020-10-15 15:36 ` Roman Perepelitsa
2020-10-15 16:47 ` Bart Schaefer
2020-10-22 13:30 ` Roman Perepelitsa
2020-10-09 21:40 ` Matthew Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009200737.GA78914@CptOrmolo.darkstar \
--to=phy1729@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).