From: Matthew Martin <phy1729@gmail.com>
To: zsh-workers@zsh.org
Subject: Re: [patch] Avoid race in zf_mkdir
Date: Fri, 9 Oct 2020 15:53:57 -0500 [thread overview]
Message-ID: <20201009205357.GA6449@CptOrmolo.darkstar> (raw)
In-Reply-To: <CAH+w=7ZRvW3Yq3XO6TwbK1hgSDNE8ynX0eQOU2dTuLcAELNUDg@mail.gmail.com>
On Fri, Oct 09, 2020 at 01:47:49PM -0700, Bart Schaefer wrote:
> On Fri, Oct 9, 2020 at 1:35 PM Roman Perepelitsa <
> roman.perepelitsa@gmail.com> wrote:
>
> > On Fri, Oct 9, 2020 at 10:25 PM Bart Schaefer <schaefer@brasslantern.com>
> > wrote:
> > >
> > > Er, sorry, this doesn't actually avoid the race, it just prevents the
> > error message from being shown by whichever shell loses the race.
> >
> > I think this is the expected behavior. It's prescribed by POSIX for mkdir.
> >
> [...]
>
> >
> > The patch is incorrect for a different reason. If `zf_mkdir -p foo` is
> > racing with another process that's doing `mkdir foo && rmdir foo`, the
> > zf_mkdir call must never fail but with this patch it can fail.
> >
>
> Hm ... in that case the code shouldn't call stat() unless the mkdir() gives
> EEXIST? And then ignore ENOENT from stat()?
>
> What if another process is doing "touch foo && rm foo"? How is it possible
> to distinguish that from mkdir+rmdir ?
>
> Or are we confusing the requirements for mkdir(2) from those for mkdir(1)
> ? I don't have the spec handy.
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/mkdir.html
I suppose we could stat before and after if after mkdir errno = EEXIST.
next prev parent reply other threads:[~2020-10-09 20:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 20:07 Matthew Martin
2020-10-09 20:24 ` Bart Schaefer
2020-10-09 20:35 ` Roman Perepelitsa
2020-10-09 20:47 ` Bart Schaefer
2020-10-09 20:53 ` Matthew Martin [this message]
2020-10-09 21:22 ` Roman Perepelitsa
2020-10-09 21:27 ` Bart Schaefer
2020-10-10 11:50 ` Roman Perepelitsa
2020-10-15 10:01 ` Roman Perepelitsa
2020-10-15 15:29 ` Bart Schaefer
2020-10-15 15:36 ` Roman Perepelitsa
2020-10-15 16:47 ` Bart Schaefer
2020-10-22 13:30 ` Roman Perepelitsa
2020-10-09 21:40 ` Matthew Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201009205357.GA6449@CptOrmolo.darkstar \
--to=phy1729@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).