From: Felipe Contreras <felipe.contreras@gmail.com> To: zsh-workers@zsh.org Cc: Felipe Contreras <felipe.contreras@gmail.com> Subject: [PATCH] builtin: trivial cleanup Date: Thu, 12 Nov 2020 11:38:22 -0600 Message-ID: <20201112173822.1500674-1-felipe.contreras@gmail.com> (raw) The flags were being set in exactly the same way in both branches of the condition. Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> --- Src/builtin.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/Src/builtin.c b/Src/builtin.c index 09eb3728c..5d780e4ca 100644 --- a/Src/builtin.c +++ b/Src/builtin.c @@ -2231,17 +2231,12 @@ typeset_single(char *cname, char *pname, Param pm, UNUSED(int func), arrfixenv(pm->node.nam, x); } } - if (usepm == 2) /* do not change the PM_UNSET flag */ - pm->node.flags = (pm->node.flags | (on & ~PM_READONLY)) & ~off; - else { - /* - * Keep unset if using readonly in POSIX mode. - */ - if (!(on & PM_READONLY) || !isset(POSIXBUILTINS)) - off |= PM_UNSET; - pm->node.flags = (pm->node.flags | - (on & ~PM_READONLY)) & ~off; - } + /* + * Keep unset if using readonly in POSIX mode unless specified otherwise. + */ + if ((usepm != 2) && !((on & PM_READONLY) && isset(POSIXBUILTINS))) + off |= PM_UNSET; + pm->node.flags = (pm->node.flags | (on & ~PM_READONLY)) & ~off; if (on & (PM_LEFT | PM_RIGHT_B | PM_RIGHT_Z)) { if (typeset_setwidth(cname, pm, ops, on, 0)) return NULL; -- 2.29.2
reply other threads:[~2020-11-12 17:39 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201112173822.1500674-1-felipe.contreras@gmail.com \ --to=felipe.contreras@gmail.com \ --cc=zsh-workers@zsh.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
zsh-workers This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.vuxu.org/zsh-workers # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V1 zsh-workers zsh-workers/ http://inbox.vuxu.org/zsh-workers \ zsh-workers@zsh.org public-inbox-index zsh-workers Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.vuxu.org/vuxu.archive.zsh.workers code repositories for the project(s) associated with this inbox: https://git.vuxu.org/mirror/zsh/ AGPL code for this site: git clone https://public-inbox.org/public-inbox.git