From: Stephane Chazelas <stephane@chazelas.org>
To: "Jun. T" <takimoto-j@kba.biglobe.ne.jp>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCHv1] [long] improvements to limit/ulimit API and doc
Date: Thu, 26 Nov 2020 17:23:54 +0000 [thread overview]
Message-ID: <20201126172354.g5guqrhu3mwrv6ia@chazelas.org> (raw)
In-Reply-To: <05C414E9-A152-40CD-90C3-C74D7FD773A8@kba.biglobe.ne.jp>
2020-11-27 00:22:05 +0900, Jun. T:
>
> > 2020/11/26 22:55, Stephane Chazelas <stephane@chazelas.org> wrote:
> >
> > But:
> >
> > $ bash --posix -c 'ulimit 18446744073709551617; ulimit'
> > 1
>
> I think this is a bug of bash.
> It seems bash checks the wrap around only for the calculation of
> bytes = 512*blocks, and does not check if the number of blocks
> is already wrapped around.
Yes, looks like it does:
if (limit * factor / factor != limit) error(out of range)
(where limit is converted from string without overflow check).
>
> > There's also the question of the actual value of RLIM_INFINITY,
> > RLIM_SAVED_MAX, RLIM_SAVED_CUR and whether we can assume
> > RLIM_INFINITY is the maximum possible value.
>
> I guess zsh need not care about these things.
>
> # I must say I don't know what it means if RLIM_SAVED_XXX is not
> # equal to RLIM_INFINITY.
I can't say I know anything about those RLIM_SAVED_XXX. I
came across them for the first time today.
> Zsh only need to check whether the new limit user wants to set is
> within the range of rlim_t.
Yes, but how do you determine that range? Should we not also
reject 18446744073709551615 as out-of-range on systems where
it's RLIM_INFINITY since it's not preventing file sizes to get
past 18446744073709551615 for instance.
$ bash --posix -c 'ulimit -t 18446744073709551615 && ulimit -t'
unlimited
yash rejects it:
$ yash -c 'ulimit -t 18446744073709551614 && ulimit -t'
18446744073709551614
$ yash -c 'ulimit -t 18446744073709551615 && ulimit -t'
ulimit: Numerical result out of range
$ yash -c 'ulimit -t 18446744073709551616 && ulimit -t'
ulimit: `18446744073709551616' is not a valid integer
In any case, while I agree they are valid (though minor)
concerns, I won't address them in this round. I can add a
"BUGS" entry though.
--
Stephane
next prev parent reply other threads:[~2020-11-26 17:24 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 21:49 Stephane Chazelas
2020-11-25 0:35 ` Daniel Shahaf
2020-11-25 6:44 ` Stephane Chazelas
2020-11-27 17:16 ` Daniel Shahaf
2020-11-26 6:57 ` [PATCHv2 1/2] [long] improvements to limit/ulimit API and doc ((un)limit in csh emulation) Stephane Chazelas
2020-11-25 23:43 ` [PATCHv1] [long] improvements to limit/ulimit API and doc Oliver Kiddle
2020-11-26 20:14 ` [PATCH] ulimit option completions using ulimit -a output Stephane Chazelas
2020-11-27 7:13 ` Stephane Chazelas
2020-11-27 8:15 ` Felipe Contreras
2020-11-27 12:19 ` Oliver Kiddle
2021-03-27 21:25 ` Lawrence Velázquez
2021-04-03 14:57 ` Lawrence Velázquez
2021-04-10 20:11 ` Lawrence Velázquez
2021-04-13 14:35 ` Daniel Shahaf
2021-05-09 20:37 ` Lawrence Velázquez
2021-05-11 19:05 ` Stephane Chazelas
2020-11-26 20:58 ` [PATCHv2 2/2] [long] improvements to limit/ulimit API and doc (the rest) Stephane Chazelas
2020-11-27 16:39 ` Daniel Shahaf
2020-11-27 20:13 ` Stephane Chazelas
2020-11-27 20:36 ` Daniel Shahaf
2020-11-28 6:52 ` zsh coding style (was about a limit patch review) Stephane Chazelas
2020-12-01 16:47 ` Daniel Shahaf
2020-11-28 8:16 ` [PATCHv3 2/2] [long] improvements to limit/ulimit API and doc (the rest) Stephane Chazelas
2021-03-27 21:21 ` Lawrence Velázquez
2021-03-31 18:06 ` Stephane Chazelas
2020-11-26 11:19 ` [PATCHv1] [long] improvements to limit/ulimit API and doc Jun T
2020-11-26 13:55 ` Stephane Chazelas
2020-11-26 15:22 ` Jun. T
2020-11-26 17:23 ` Stephane Chazelas [this message]
2020-11-27 18:24 ` Jun. T
2020-11-27 18:34 ` Daniel Shahaf
2020-11-27 20:46 ` Stephane Chazelas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126172354.g5guqrhu3mwrv6ia@chazelas.org \
--to=stephane@chazelas.org \
--cc=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).