zsh-workers
 help / color / mirror / Atom feed
* "make check" suggestion
@ 2020-11-28  6:52 Bart Schaefer
  2020-11-28 10:31 ` Felipe Contreras
  0 siblings, 1 reply; 3+ messages in thread
From: Bart Schaefer @ 2020-11-28  6:52 UTC (permalink / raw)
  To: Zsh hackers list

I haven't messed around with ztst.zsh for some years, so I'm not
familiar with how the newer features like intentionally failed tests
are handled.  A suggestion perhaps for someone who has worked on it
more recently:

It might be nice to have a mode in which ALL the tests in each file
are run, rather than abort the whole test file when one of them fails
(or unexpectedly succeeds).



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: "make check" suggestion
  2020-11-28  6:52 "make check" suggestion Bart Schaefer
@ 2020-11-28 10:31 ` Felipe Contreras
  2020-12-01 17:03   ` Daniel Shahaf
  0 siblings, 1 reply; 3+ messages in thread
From: Felipe Contreras @ 2020-11-28 10:31 UTC (permalink / raw)
  To: Bart Schaefer; +Cc: Zsh hackers list

On Sat, Nov 28, 2020 at 12:53 AM Bart Schaefer
<schaefer@brasslantern.com> wrote:
>
> I haven't messed around with ztst.zsh for some years, so I'm not
> familiar with how the newer features like intentionally failed tests
> are handled.  A suggestion perhaps for someone who has worked on it
> more recently:
>
> It might be nice to have a mode in which ALL the tests in each file
> are run, rather than abort the whole test file when one of them fails
> (or unexpectedly succeeds).

Coming from Git, I have to say their testing framework is the best
I've ever seen.

It is developed in shell. There may be some bashisms, but they try to
avoid them. Last time I tried it in zsh, it didn't work correctly, but
shouldn't be too hard to fix (and maybe it was a problem in zsh), and
I'm sure they would accept the patches.

The project that tried to extirpate the test system from git.git is
called sharness [1]. I've used it in all my projects, and it works
like a charm.

In this test system all you have to do is pass -i to the test, to stop
at a failure.

For example:

  ./completion-zsh.t -i

Additionally, the system supports Perl's Test Anything Protocol (TAP) [2].

So you can do:

  prove completion-zsh.t :: -i

That's how I developed the git-completion zsh specific tests, which
work great, and are integrated into Travis-CI [3].

If anyone is interested, I could give it a try to port some zsh test
to sharness.

In my personal opinion the testing system of zsh is far from ideal.
But that's just my opinion.

Cheers.

[1] https://github.com/chriscool/sharness
[2] https://en.wikipedia.org/wiki/Test_Anything_Protocol
[3] https://travis-ci.org/github/felipec/git-completion

-- 
Felipe Contreras



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: "make check" suggestion
  2020-11-28 10:31 ` Felipe Contreras
@ 2020-12-01 17:03   ` Daniel Shahaf
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Shahaf @ 2020-12-01 17:03 UTC (permalink / raw)
  To: Felipe Contreras; +Cc: Zsh hackers list

Felipe Contreras wrote on Sat, Nov 28, 2020 at 04:31:46 -0600:
> In my personal opinion the testing system of zsh is far from ideal.
> But that's just my opinion.

I agree that it'd be nice if we didn't have to maintain our own test harness
(as opposed to test cases).

No comment about sharness specifically.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-12-01 17:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-28  6:52 "make check" suggestion Bart Schaefer
2020-11-28 10:31 ` Felipe Contreras
2020-12-01 17:03   ` Daniel Shahaf

zsh-workers

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/zsh-workers

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 zsh-workers zsh-workers/ http://inbox.vuxu.org/zsh-workers \
		zsh-workers@zsh.org
	public-inbox-index zsh-workers

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.workers


code repositories for the project(s) associated with this inbox:

	https://git.vuxu.org/mirror/zsh/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git