From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 28708 invoked from network); 4 Jan 2021 05:15:19 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 4 Jan 2021 05:15:19 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1609737319; b=O/PmpHjmdd/oAbxfBus3wXFeLYbiGqeEa3pQHF0Kt6IuagGoffHmucjhAUml/ddqasub+HIaJs 4i474gbHsIUeSkn/BPqtkEALAVCZYHEG9XT0qWGCaeIW2BZxN6IlXKImN8pu9QBJkzNWfYCd/i qkJopYoQjXTc/W6rtu+LtfzD/q9ivuaqKC3Tn2Jguil7za620ag8aocm/1MnkfesU4phh1L1Ai Pbq8EfQQy/ElIEa0aVhsJsPspJxjyTJ4ectsb+Yungnko94YBM4MaZFbuHVMbuIs6Y0xnJ7CUG 9+6HhAa6eEWwm2x2rYz+1lG9fqRZLrSlQ8RdfizNUZtNXA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (wout3-smtp.messagingengine.com) smtp.remote-ip=64.147.123.19; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1609737319; bh=/rBQh1I6dTg9RIKQGVeKpyvwIa7g+wi0Cja/nA4DiUM=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:MIME-Version: References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=i6gz77A1sg+SZ5SX7eP6LnMCGiiN2E2DPF/+mSTioFlEApjyP/GEtl+8KI6awndq/dwTtDHKyr suS/qxafPxXMK4uY/iiC0BFQZhHmM9Ozjiesfa7lDt6Q/sYpWqhJyEcDsf5hK1H1CRKrYLFT5h 58Um4+BF2+AR3NbtPWnCm3BVE3vvxI3nO91TechXx1FVXHogryhBSj7BVuBAMlrrYTVuXo0LHG J0HQT7K0cGP/4Qa5WttmzN6f/Imk+fwelNfc+a5urFbBEZo2Ka3MmIO/nF6+M1p1353jqQH4QQ uV7VvXcM/MosnehC0nMlwDyu4wDp1AnjvCiKfS1FW/9Gsw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=UXfjGXg/pdF/Md+XJpv/Cv11w1U8FwaG/WOwUIQkvbQ=; b=QJutK7rxnoZT5szK1AFTRPx0lo WA6tKdw9zh/16LjRj6IXGLPjekT2ceD90XlayTxisemQZ5nuQy/7onJteQAtfJZGn+QDIeIhIfm/9 qVeGjG1mzBHcRVFY0y6ym36munuX2D4EI5BB7OG7Z7BqmpL+78CGzEVcxRKpf2XNUIsJKwsB56T1T srD51KuTyURkM75L+UvWED6hlu5FI8qGAe0SPqjB9F6k48dg5tENUcF+5dhRHSmNe6zEIgKNGGJoo QmvoJ0eXp/LeyXJmVF9qjlhjjY01ieySOZvqduScDdfMrtUd+/mOS5uzblKPHjoX/75yLcg+tL4Y+ UBiPgKnQ==; Received: from authenticated user by zero.zsh.org with local id 1kwID7-00074a-2k; Mon, 04 Jan 2021 05:15:17 +0000 Authentication-Results: zsh.org; iprev=pass (wout3-smtp.messagingengine.com) smtp.remote-ip=64.147.123.19; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:60713) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1kwICm-0006uK-Bj; Mon, 04 Jan 2021 05:14:58 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id C617119D0; Mon, 4 Jan 2021 00:14:53 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 04 Jan 2021 00:14:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :in-reply-to:references:mime-version:content-type :content-transfer-encoding; s=fm2; bh=UXfjGXg/pdF/Md+XJpv/Cv11w1 U8FwaG/WOwUIQkvbQ=; b=h82SPaztqwjdvvKLqp1o/9m/3jBCMgBo1ukC429Pu8 9yUOQ3NKbpXOtmympjgqRcmFfCzmk2+r5WfDmkEhxLOpM9/dRwbRy5SjZXF4zP63 TM6o6ZpRG2QjggXco5awF9WRccnQQPDEpip4ANoV8h/svkfya4DVi+RFW+yHoHdr XjQ+0USP95MedcbecHeyWmRx6csW1fw318Enhg6++ZhvXshue/n+DVU2N5ZGWiC5 ymsw8AAairpfO69frJZApuT2rB8a6E7S6XM6MeZ0ynjwoTa9LDQkz40z1UM9ECK8 ZyCvhh+jnuDev6+N9jz5TpG4NgUaCrMBakcLJlbJlHLg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=UXfjGXg/pdF/Md+XJpv/Cv11w1U8FwaG/WOwUIQkv bQ=; b=qN2K7BTLEFdf2qQr7xDSrQALpW21g1c+RFankRfz2yIUQLuR3qshnsRHF YbCcAxKuMqLsoODJMg4Zw4nqUaGR9sr4ldcBI13IuMBYQSWcgHAMXC5BqGFPj+8W wKbJQUOslEBC6owgkD2dUv9kV6lsSsxtv9cWQ1BAyLsnIS1buDRTXSGpJd0bK0tE s+LtfKOnCwuRj5KVjzRsPRi6WWca7b6quk4ig0t0sT6sdQWk0xAyFRV/2IGGGRmg BjaG6wxfSS4ueAXZJiWf5y1DdDdlAe1VqmYRvQIvC6ekbntCtWW7PGC8IuRSImBX nIGTi7ab5c8ZJg/8qRF8GcfruD+vg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdefvddgkeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfgjfhfogggtgfesthejtddtredtvdenucfhrhhomhepffgrnhhi vghlucfuhhgrhhgrfhcuoegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgeqne cuggftrfgrthhtvghrnhepfeduteegveehvdfhteevtedvudeludeijeeuudeujeejtdet uedtjefhtdfgieetnecukfhppedutdelrdeiiedrkeegrdduheelnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepugdrshesuggrnhhivghlrdhs hhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-109-66-84-159.red.bezeqint.net [109.66.84.159]) by mail.messagingengine.com (Postfix) with ESMTPA id 884D31080057; Mon, 4 Jan 2021 00:14:52 -0500 (EST) Received: from tarpaulin.shahaf.local2 (localhost [IPv6:::1]) by tarpaulin.shahaf.local2 (Postfix) with ESMTP id 4D8P2L1YfCzGG; Mon, 4 Jan 2021 05:14:50 +0000 (UTC) Date: Mon, 4 Jan 2021 05:14:48 +0000 From: Daniel Shahaf To: Felipe Contreras Cc: Mikael Magnusson , Zsh hackers list Subject: Re: [PATCH 1/3] src: fix build warnings Message-ID: <20210104051448.083bb483@tarpaulin.shahaf.local2> In-Reply-To: References: <20201231054131.682544-1-felipe.contreras@gmail.com> <20201231054131.682544-2-felipe.contreras@gmail.com> <8591b9d9-f2f0-4045-b8e2-d1b759a360c0@www.fastmail.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Seq: 47795 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Felipe Contreras wrote on Sat, 02 Jan 2021 12:30 -0600: > The best fix is to allocate one byte, especially if it's going to be > freed later on. Yes, please revise the patch to allocate byte(s) from the heap as needed. (See comments at the top of mem.c, and, for instance, dupstring() v. ztrdup().)