From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 5965 invoked from network); 26 Jan 2021 23:38:02 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 26 Jan 2021 23:38:02 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1611704282; b=zPm0VwoB/2GUEvW8612iBMVDxFILuvG+BuD1uFNhYhMdA29Uvy3vlxtHcrgXnnu1KpHYuP+uLM ZQ5rKQSaKJR1v4qW5VBi3e4kJ66FSPKmNajF7eqO8JhkgRIOXm0EoZk7cgR3jqAYBTq/aNYueH VMK1P0hH8jmtYsA8v1CTVxT5HaUdcn2BFHoa/ak2zkijWkD7jF2ibatOrGsWWud4WapbAhDMzX ApiO+mxe9ACeL2SHZbzaePSiZcChv0FzlL8flG87JbNZQVoeJucdcaJjslI3sAHPDaBMHrv3zY LLwGG1DuPbbmdwKNWljQ1PkSiuhZfqfB0+P3nRStA5vPGw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1611704282; bh=P1A59QVeuv5dv2Z+X694jcEbybBQiIJIJQVeAstJsAE=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:DKIM-Signature:DKIM-Signature:DKIM-Signature; b=IoSox/s1AdslVevrfCHuk5AOkitAWV7PK7UoYCl17zzOfwCvhOn3C2z7TCOqoRqwOKCsuShhdC VlSooHJ/u4qN+b++0GFIXky087sG43Y8jgu1zLCM4Ldj2NNuKD+V2fEzQJ1+1Ik4k58gDvgiuA 8eM3qy/apotfLcDK7fB+KonVEYvMj3b6M4Kg/tT/0MHRmTQQfgt7tjsXB6AR54jaNc2POVWrPE oRLLZUtuYT2CRlbk+MlVRz9LMhqySmRAyzb9zELEOOSLlC9s/O4iEG3BHKMVdHx6stiWo4t0d2 ZCY4s01sVIcmq1aF2uDfqj1bHVQ4xqCfLuWbbMdqSjBlIQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=vp+jzr6HzwLGmSOCAeh+NUwgxwMuI88Kn6K1DipKPSE=; b=yn3hIb9OxrXI3g+sFalYm+85Fr nxjKYzOz2kgVsQpjefQ8zSIcXCtN5n8Wvnf3YxwcbgRJe4aoaUZ9M5cTD2qxwH03d7n9WuBqGryAa omO1XHUC/qr4XPGa2tlXIQ7bbn/8AIIypnN485aZZg8sEUxhkgZ2GjtzJXZ0hhpMDbqquK7i/54Jp 9D7wUzbBVduf110D+e342G2gPpqvLeQMZw68j4R3xzIgRnFhZu2IEDJAGg1Xt7bg/NGQ64vPNTxNZ YO1cb5eM1fiONP4KsefjK4vefgwBr4O9IXqaHyfg7eI4XBMSzVuFz+HRQX956ybReT9UmFt4E5C1w RkPJQmyQ==; Received: from authenticated user by zero.zsh.org with local id 1l4XuK-000J5F-MU; Tue, 26 Jan 2021 23:38:00 +0000 Authentication-Results: zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm1 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out2-smtp.messagingengine.com ([66.111.4.26]:49757) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1l4Xu2-000IL6-D3; Tue, 26 Jan 2021 23:37:44 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id EB19F5C0105; Tue, 26 Jan 2021 18:37:40 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 26 Jan 2021 18:37:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=fm2; bh=vp+ jzr6HzwLGmSOCAeh+NUwgxwMuI88Kn6K1DipKPSE=; b=nVMzYtoF+wIW1zh5veT K6QxSVzS5p4G6dEbvvvrDGJzl8tM2Qjw+3Y9VsiT97MpBTj+SmRzjOi94Kkw5iYQ er/QkF1yaOH5DVxL8m87BTMqyCzS4BQNbIqRc866dENEfkGCZszfS51Qg4RkLv9E 1cucob7n2QCdPajYitFlnIbSDNLb6kjcvw1RcxPs8Sud+M0nPGlBegZfkMfC9kfb h3uBhJYrME13Kp26AQjcrELwO45dz/EqSu4cNnRw86VSB68mCsvQddhvPyeIrFCl BfNW0BAQGwo2gGnw6rwW49N/9fcp5pXd0dS7B/Mcjva0wecVHpcYWBaF7ruTP8JF eYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=vp+jzr 6HzwLGmSOCAeh+NUwgxwMuI88Kn6K1DipKPSE=; b=LYwgQLQWreOrdYnQMkPII1 Yf0wDrQGtT04VmAfdTg5HkRAtqEiEbIQKxJWVq37GhKwEYxkXGlX3WjRL6oYgko+ CckCAYCNLu9AETd3Lqtb1HCPk6ToYJgNqFEsDGrtBf5SBwpCA02XCVlKWgMxt7b4 DeZslN8IILBFWh5t+GUirLXpupssR+JOe7jSRGT67J9FkjSJzRuzG0nhefInXWMX Yfk1SpUZ79t3Uce9Uf9Ulvd/CfX0C+XmvbepJhPGikeudG8LxKdNMiKv5A3H5Lh2 a5oiZ8frQ08BvP25M6S7RtMOIivnr/5m4VQTop4W9hF0f28s11wycB4x6Bht9LKQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejgddufecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjfgesthdttd dttdervdenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghnihgv lhdrshhhrghhrghfrdhnrghmvgeqnecuggftrfgrthhtvghrnhepueevkeefffeufeehfe fhgefffedviedthedtgeeljeelvdeihfevjeefteegvdeknecukfhppeejledrudekfedr ieehrddvtdegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepugdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-79-183-65-204.red.bezeqint.net [79.183.65.204]) by mail.messagingengine.com (Postfix) with ESMTPA id 8378E240065; Tue, 26 Jan 2021 18:37:40 -0500 (EST) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4DQNSg024Jz3rY; Tue, 26 Jan 2021 23:37:38 +0000 (UTC) Date: Tue, 26 Jan 2021 23:37:38 +0000 From: Daniel Shahaf To: Jacob Menke Cc: zsh-workers@zsh.org Subject: Re: Possible issue with Completion/Unix/Type/_date_formats return value Message-ID: <20210126233738.GB25751@tarpaulin.shahaf.local2> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 47878 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Jacob Menke wrote on Wed, Jan 20, 2021 at 17:43:31 -0500: > Hello, > > I was wondering if _date_formats has an improper return value. > > When called from _date (when $1 is unset, thus $1 == zsh is > false) _date_formats always returns 1 even when matches are generated from > _describe. This causes completion to continue erroneously. > > Last two lines are shown: > _describe -t date-format-specifier 'date format specifier' specs > -p "${(Q)PREFIX:-%}" -S '' > [[ $1 == zsh ]] && _message -e date-format-precision 'precision for %%.(1-9)' > > I believe the return value of _describe should be returned either by making > _describe last statement or storing its value in local var ret and then > returning ret. Thanks for the report and sorry for the late answer. I agree that it's wrong as it stands. Anyone wants to take it from here?