zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Tests for globbing below protected directories
Date: Tue, 26 Jan 2021 23:56:05 +0000	[thread overview]
Message-ID: <20210126235605.GC25751@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CAH+w=7bwDpyu0Anj5wpQ-v+ATFZ7fvqfz9RSeoE6ahRu=QVGLQ@mail.gmail.com>

Bart Schaefer wrote on Sun, Jan 24, 2021 at 16:15:23 -0800:
> Does this test look as expected?

It's a little counter-intuitive that foo/* is not a superset of foo/file.  The
former can't tractably discover d111/file, of course.  As to whether
foo/file fall back to readdir() when the directory is readable but not
executable, I guess this was either discussed in the other thread or is
ETOOMUCHEFFORT, or possibly both — but it's too late right now for me to go
look, sorry.

Thanks for the patch, Bart.

> Note there are trailing spaces on the "print -raC 2" output, which surprised
> me but has nothing to do with the test itself.
> 

The trailing spaces were eaten by something in the email delivery chain, but
they're definitely unrelated to the test itself:

% print -raC 2 x y | sed 's/$/$/'
x  y  $
% 

Daniel


  reply	other threads:[~2021-01-26 23:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25  0:15 Bart Schaefer
2021-01-26 23:56 ` Daniel Shahaf [this message]
2021-02-02  2:45   ` Bart Schaefer
2021-02-03 11:22     ` Daniel Shahaf
2021-02-03 22:33       ` Bart Schaefer
2021-02-03 23:06         ` Bart Schaefer
2021-02-04 13:09           ` Daniel Shahaf
2021-02-04 21:34             ` Bart Schaefer
2021-02-06 12:15               ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210126235605.GC25751@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).