From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Joshua Krusell <js.shirin@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Improve error message from zparseopts -F
Date: Wed, 3 Feb 2021 11:28:46 +0000 [thread overview]
Message-ID: <20210203112846.GC12261@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <20210202221728.371739-1-js.shirin@gmail.com>
Joshua Krusell wrote on Tue, Feb 02, 2021 at 23:17:28 +0100:
> I see that this was the original intended behaviour in the V12zparseopts
> tests, so ignore if I've missed something.
> +++ b/Test/V12zparseopts.ztst
> @@ -69,7 +69,7 @@
> >ret: 1, optv: , argv: -a -x -z
> ?(anon):zparseopts:2: bad option: x
> >ret: 1, optv: , argv: -ax -z
> -?(anon):zparseopts:2: bad option: -
> +?(anon):zparseopts:2: bad option: -x
> >ret: 1, optv: , argv: -a --x -z
Haven't tested, but this sounds perfectly reasonable to me. If anything, I'd
say go a step further and add the first minus sign as well: referring the the
«--x» option as «-x» could be confusing (or even misleading, if there happens
to actually be a -x option).
And the same thing on line 70, I suppose?
Cheers,
Daniel
next prev parent reply other threads:[~2021-02-03 11:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 22:17 Joshua Krusell
2021-02-03 11:28 ` Daniel Shahaf [this message]
2021-02-03 11:36 ` Peter Stephenson
2021-02-03 15:06 ` Joshua Krusell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210203112846.GC12261@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=js.shirin@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).