From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 20910 invoked from network); 27 Feb 2021 13:24:21 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 27 Feb 2021 13:24:21 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1614432261; b=C/cRvKuQOw7hNluIaWnRTVDp3aAOjiAmcNNZk/y7UCoFRRedwTsRCZf7tgZx7VUsozXLfF3qFy zsYeQ7YrCTnlJJH15Ucas53HtHrZr7bszxwzJy41wauQX1VrhJGsZL6Fbsjzj6JcGCbWDxaRKT 4YKlVqtpwhDWKXLHAnkA2xe/99euRVPOHGzCDx4nQe0vCFt5OXrL/S+wUWj+iz2CoRizLJXU9s XVsgrumUhPPPoa8JnYYIU9qiRKnPLSJxsSp7Bl7HMCht6symJ0SDnuAqGxz45mNAD+CnZa0BcS GPqkhxwnwd/IAEswMp5043TEozruJ2TgwJSpTXjQe7QIdg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (wout4-smtp.messagingengine.com) smtp.remote-ip=64.147.123.20; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1614432261; bh=KVZpFdcPskrcKJY0WBAmCoiXk6JEZnoOmz9skAWgsI0=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:DKIM-Signature:DKIM-Signature:DKIM-Signature; b=Vg4pizBFdbVqca56KjwlXS2YC4G7arRaTXzI+lq4anyyQR7Z0TzIEomC1J2Dy1Jy5nUL85atji wdU5+S8diI5FPPmlvZL0yICO1AVLxLZU92L2GmVtUas9KfZ5bk48QaO4ZuJKnXkFeuLHtebFZt KEolOpqNHvafrJUlCeIQlCU5z3yvKKdHfbHlki0xHSBa6H7vVJW9p6ZFJTwMr8T0h16onq/F5i 2b9WKD2HpuBZXa4Nw4zRRk8hzR/vS6Z+A8ucD5psD/03suIKA7PQ0zDqOPEhw4FDBeB9Gb0moI No701ST3ye8x1//GLYBR7uqqU661rFVgC4zTUMhW60b9Cg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=UorVL8T59Pbv25cpmc9JWzjXMTUVKUAfhQpD1oDsuj4=; b=BNv6HaYU46Yr7MPVfdf94ZqNRj Zf9eQXyrap6DPmY4Pgf49a6DCIRxQgEFpZGzanXJFe4I/lh0EgybNoSQhp5Hx68DkhxIExLUowFR9 o0K/8EXe4Y+o7EkmV4WDzmmncaq/IA8TNFWljVfJLjDVhStA8sqMNTsRp4pIGWmbtgSTOr4jXLtCB /HtEURGZEaRmPo+56NyHGSxaJKTXJffoZsLSBaTu2NqowPO+eOnLm7zlN/B7VrxTE2b8ruXuZHFAP Bq4U7ihVi31nTmP9lXs8rZ6Ag7UyPTYjaIqJPzLg5U8jcqXVIVHDBtviSFTvlRQyKj9/gK2HLeeFt NWA5qR1A==; Received: from authenticated user by zero.zsh.org with local id 1lFza1-0000Rq-Og; Sat, 27 Feb 2021 13:24:21 +0000 Authentication-Results: zsh.org; iprev=pass (wout4-smtp.messagingengine.com) smtp.remote-ip=64.147.123.20; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:51011) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lFzZq-0000JJ-9b; Sat, 27 Feb 2021 13:24:10 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 5E2FE825; Sat, 27 Feb 2021 08:24:08 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 27 Feb 2021 08:24:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=fm2; bh=Uor VL8T59Pbv25cpmc9JWzjXMTUVKUAfhQpD1oDsuj4=; b=YekYHgWTETkfhbsKe6k zDo4lUjp4Bl4r5eI14j52tCVx1mbF/QCY3DcTuN62Egwqp9kOfD/NQklCS1TIdnp dloeSmkBl8iEv5/ZOQ1+/gWM37el7tvbgpqS0yA4CdwlUnQcaWwUoK1sG5PokHRy bLXZ6MBIGcPFBwP7Zx1kOFRF58j8dZEDR62QoLLGeMVNsdKa0yeL+4lgOLfCF8Rf itg07ok2RYubOSo0DcTRUuqUflyGhih/+EENEDfe+/DmkBEWQHC2j4GcaWtOPjWb lPHEQnPxpTUtit9Pt1CnDMVgNCXaBpFNc3folX8OEA9wu+ebZAZPa9bq6C/We8JS ssA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=UorVL8 T59Pbv25cpmc9JWzjXMTUVKUAfhQpD1oDsuj4=; b=ABqbrVQQ7BEgneFtiReNhT qIw7dgqPJam3G6mw3oQE4taDc+J2entXE6GKxG++eIHgjF5TCAyqfFF/9woICLRV GDNuHfFIYBB2UU2k2FnU/m+FUj67IEz83rtq9D3UedrEm68mJQPH2zgY33Jnqwmb UCGDk8RDcvC/DPlxPcVecoKMJMuc9zHixPoGchz8Whw59arZvdukD2/5tirieSbg sybk/NatNncBwQwwlNPj3PN/Vz4/djeN0+tCq7lc1gmM2492g6hNMlobg1vhjK+1 0Axd1szYlXhYTNsL2ZMRmJlQA/9DnctroOzjkkHp7S7oXCp9p39hxpRcvz+/W6SA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrleefgdehudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujggfsehttddttddtredvnecuhfhrohhmpeffrghnihgv lhcuufhhrghhrghfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvqeenuc ggtffrrghtthgvrhhnpeeuveekfeffueefheefhfegffefvdeitdehtdegleejledviefh veejfeetgedvkeenucfkphepjeelrddujeelrdehledruddvtdenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdrshhh rghhrghfrdhnrghmvg X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-79-179-59-120.red.bezeqint.net [79.179.59.120]) by mail.messagingengine.com (Postfix) with ESMTPA id 6530C24005D; Sat, 27 Feb 2021 08:24:07 -0500 (EST) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4DnnKy0dRQzw4; Sat, 27 Feb 2021 13:24:06 +0000 (UTC) Date: Sat, 27 Feb 2021 13:24:06 +0000 From: Daniel Shahaf To: Arseny Maslennikov Cc: zsh-workers@zsh.org Subject: Re: [PATCH] _rpmbuild: complete non-options after `rpmbuild -[btr]?' Message-ID: <20210227132406.GB9308@tarpaulin.shahaf.local2> References: <20210227115501.332503-1-arseny@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210227115501.332503-1-arseny@altlinux.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 48125 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Already fixed in 47323. Please write patches against latest master. Thanks! Arseny Maslennikov wrote on Sat, Feb 27, 2021 at 14:55:01 +0300: > The "tmp" array is being filled up with specstrings for _arguments in > all three cases, but is unused afterwards. Thus non-option arguments > after e. g. `rpmbuild -ba' are not being offered as completion matches. > --- > Completion/Redhat/Command/_rpm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Completion/Redhat/Command/_rpm b/Completion/Redhat/Command/_rpm > index e3469245f..6e4a1e6a1 100644 > --- a/Completion/Redhat/Command/_rpm > +++ b/Completion/Redhat/Command/_rpm > @@ -283,6 +283,7 @@ _rpm () { > build_t) tmp=( '*:tar file:_files -g "*.(#i)tar(.*|)(-.)"' ) ;| > build_?) > _arguments -s -C $buildopts $commonopts $pathopts \ > + "${tmp[@]}" > ;; > checksig) > _arguments -s -C \!-K \ > -- > 2.29.2 > >