From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 15416 invoked from network); 4 Mar 2021 20:17:50 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 4 Mar 2021 20:17:50 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1614889070; b=kh5FrRBKtlhOEmFf23b+ojmd1+F7L2PGZhHSVfDqsFxeGOBylEmLb6io30NDsnh+mOa98HkpS/ LG2mbKndDZsuDJh/B+zMahwAf3pYWydOe9nLKqApUV9V69KEkrj6+Jjr/SyPtkk0XYNLMFMrVi N/RH5KAP1bQCTCoF2C0UZG2TUOUIrzaPjldRwkhA18FS8g0IxjEvthfnP3JayK7Fefz/6lTKoO BxLvUiGbqa/Kk4+O5YzCTMeRWYchz0Z7UmtsOGDLjobFHh8MrXhGJ39ly7TzGm56njjBAweWVO lNI54kLDD+5Lvur/tOaX0S/vSYELDJ7P/ccvYAQh5mz+mA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1614889070; bh=JHKiSon9ptk4pSdziJaQ+3N06eOnl5I2tvOGgeLQAjU=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:DKIM-Signature:DKIM-Signature:DKIM-Signature; b=glKCGM3OP9Pm/rHLy6JIezEfjeuLJ5sNrZbyS0SOxcclb7T/gZKZScT0Cz+sqyhpMIS9mesJGn 5H1tBm7S43pjC/mkooU40aUCfzw315a/Dcq2g21KLZVTm3JwwcYRyg2t5+PCaIpePyrUTpx/C2 0/hGMK4hHJpzQYVTNk92xdfXMrXQo1JsIf7Btl1f4NtVpETf0yWIeBwqDXOAfoz6S65GvQxNRy Yx91sZH55pgND8neNjvJSUCr35R/LED17JEitLvwBfGgIUTsAf7sw+7IUZ2QkkK0AmYfFfAR36 f9K8tGBeyHNSeEgIDLg3cEcL25hrBuwzp8uuasJdCHMVAQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=Et0uYLPKlVPtDzkXUPUK7Id0bS1ENzPL0BUxt3cqPMc=; b=PJhjiYSDCbBIIg6cIHrcHtwkoY 7QTahjvBbObrVqHUWehULDRi7CB1bB6UrkcumAxjadSZ6MRVp1k79bpTvkhxMCyAZX0iUE4eFYA0f efomWE9c1vHGvVSucZVCEIHG1aKyWWeFWt1I4PkDHzdGB7+WeQIEx7HvIDqLz1a0yg9+81R+l8Sib jAKHugw0Q25gJNIjDFUh1/jiQAQ/J1iVMTFb4B9lX2kUXz/9xOx0w04/pDY31/te3SlBRtXiaS5zZ y9qI4sbvZyhAjXYMXxERtcZC4z5j6EElYOv991T4MnA0hPKlby6WdAvZma+Iwx5CD/nUoilF/GMYE TrFpCzrQ==; Received: from authenticated user by zero.zsh.org with local id 1lHuPs-000KB3-CV; Thu, 04 Mar 2021 20:17:48 +0000 Authentication-Results: zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43587) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lHuPW-000K0U-FB; Thu, 04 Mar 2021 20:17:28 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 067465C0102; Thu, 4 Mar 2021 15:17:25 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 04 Mar 2021 15:17:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=fm2; bh=Et0 uYLPKlVPtDzkXUPUK7Id0bS1ENzPL0BUxt3cqPMc=; b=J9DWsop7mYcKbLBTBRo Czom+0J/6JyUKOVZ1IzoHfKCLrZ7+6eij6K75tfsOFx31xzn7IoB4I95NM8V+ATU +YYjzFP9hT0l0H6sk1jn+cr46AXyR74920emZ3HR+eJU7Xqmu6a3io5sBeFymgXb VvkUQj6xb2lNmXKav76XcWfs1xIcfU6e+Ro0AsuizUwIIsVvYiS2fXcpOfS+m0Hv yk6aE6ZNfYy/zVGeBi1JPpzFnsbgcevaEiwwiRgo4KAaqQ5kYnBZEDTFdmgNjglJ OPFoP5Ma4ufCnShYvMcOwAstd4DgIq1eGKPjofJJPrkUr3Dd/7uA5MPDrVw2D0LQ mnA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Et0uYL PKlVPtDzkXUPUK7Id0bS1ENzPL0BUxt3cqPMc=; b=pWYooVtWeA0xGWOFoYFnuu 8i9uY4xwC1hJ0tN52osrjIMakA67JCC3mv99/9NH2UGuMWFDOQkDUvrUeqd8mOAW YGDezlHgsmNcbik4sFSJdDFRKt+AyalGjNU6fLbnQlve6gGuF9YIzmUlQVgDbyFe X+umLH783OkNtOfYhXLi+HB74ckioEiTvhrIXq+sSAkCgjByXZHAW+iJRhA+5uE+ MzCRhO1MVLkoMxy0iw2HwgVdDCPSmaoIJLrD89YGwiJG846Y8rZ7JFB+rQwNTC5K pUcSQoqLS1SWtwpID+fqKH/ztGKIaYxBA+aatK4r/bnNKrMMiznaYJquPqcVYI+w == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddtgedguddviecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujggfsehttddttddtredvnecuhfhrohhmpeffrghn ihgvlhcuufhhrghhrghfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeeuveekfeffueefheefhfegffefvdeitdehtdegleejledv iefhveejfeetgedvkeenucfkphepjeelrddujeelrdehledruddvtdenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdr shhhrghhrghfrdhnrghmvg X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-79-179-59-120.red.bezeqint.net [79.179.59.120]) by mail.messagingengine.com (Postfix) with ESMTPA id 6DA861080057; Thu, 4 Mar 2021 15:17:24 -0500 (EST) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4Ds2GT5GDnzys; Thu, 4 Mar 2021 20:17:21 +0000 (UTC) Date: Thu, 4 Mar 2021 20:17:21 +0000 From: Daniel Shahaf To: Marlon Richert Cc: Zsh hackers list Subject: Re: Bug + patch: `zstyle ':completion:*' menu select=long-list` fails to start menu selection Message-ID: <20210304201721.GA16874@tarpaulin.shahaf.local2> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 48142 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Marlon Richert wrote on Thu, Mar 04, 2021 at 10:56:06 +0200: > Test case: > ``` > exec zsh -f > LISTMAX=0 > setopt menucomplete > autoload -Uz compinit; compinit > zstyle ':completion:*' menu select=long-list > zsh -^D > ``` Thanks. Haven't reviewed the patch, but assuming it's correct, it'd be great to have this test upgraded to a proper regression test; see Test/README in the source tree. Cheers, Daniel > Patch: > ``` > diff --git Completion/Base/Core/_main_complete > Completion/Base/Core/_main_complete > index 663f755..9d90b0f 100644 > --- Completion/Base/Core/_main_complete > +++ Completion/Base/Core/_main_complete > @@ -244,7 +244,7 @@ if [[ $compstate[old_list] = keep || nm -gt 1 ]]; then > > _menu_style=( "$_menu_style[@]" "$_def_menu_style[@]" ) > > - if [[ "$compstate[list]" = *list && tmp -gt LINES && > + if [[ "$compstate[list]" = *list(| *) && tmp -gt LINES && > ( -n "$_menu_style[(r)select=long-list]" || > -n "$_menu_style[(r)(yes|true|on|1)=long-list]" ) ]]; then > compstate[insert]=menu > ``` >