From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_SORBS_WEB, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 30455 invoked from network); 11 Mar 2021 16:16:33 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 11 Mar 2021 16:16:33 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1615479393; b=UdqE3w0I+ANGvuafnuhg1CAH8Xmcli4ynN/hLGnedWLpLC0+f/MCNYwmbJaDu8uKS1M3AHrZOP 93SIaMLF1tZTBH0V8NAztQ//9et6B5M8NQiV4B/7TkyANOH3fc+K+89PioqbjkxGNEEKofZyM3 eXBW7bG41Dq05EXQBX3Num7ywCHFlBNEfk4bfY3B9OHBCKs42NftMNLvH4wlwwXxz11DigAhNy 2/VlyOEP8bOUKOJoV8OgW1oGZPs6J2mualF+5usvL4bwLAZNPwjmDVN227pSOCGfeStqziOZc5 tERW2rxzquZoqc9eLO7Op/NrL+gy43+sJxG3GmpivCwnPg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out4-smtp.messagingengine.com) smtp.remote-ip=66.111.4.28; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1615479393; bh=sKM2gQ4RbbZQeJawb9Eznz335XwgkvU1FjhcRckuQGU=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=OxiyHpntxl9JsDiFCiGBM7FnWdXwrXzK7YinD8/P95gCltE4v3yphFtzDEb77+V36NO50eZyRL l306CFb+YG7FPMoCiificV2mw6p8j3dKIa65vKdHCqujJKJHPdBCRYGdCeGkjqPDvaigUTiaBz 6WnBINpOFTJhVawZO0tyfbtkG2qQ/OBF9TuYO1bABVlDdBudtnjKuZWDMPRDGSsduCheqY86lj 5/XBlkPODjYc7bJ4VYxtK4uK3xJr7C0JDwDPpTvaP3TMrzIovwjbBISqJeavDxCPKtdsgO4qRU sqRhEpe91bNZT07gab7ISINTd7/hGxUVYgsdZL/IcZMOVQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=/YEWZYrlTZEJHcGlnOOnc5teiy7l/sgSyfQ0PPOO/2I=; b=0Fpf/0z9dTvqTMLHFrIm009rL+ dvXf/K6vS9us7JhAKM+2/mnEeRwGVKpbXo3U+gGqHpfNBy6wHJ1SXlB4tQ/14SZTp8/UVmkDRGAN+ TVgwWV4xNInWGwhqihdmIh2yfASQVriRlrLz/oEU6dyvJLBkY3WuR4Enl6c4fVyaMe6tkqUgdMO5u OaQ3I6ZLNIb+eUp1ZfuuFzrel0bA0oLppryaxhiE9y5nndlPtW7jQPfPOhSPFaabW5tQYSG4LKQ+k 8lDVIr8X+BeCNK3BWlZVRPfKDZ2MXUCa4dtbg2dYGm0qbyYKoPNUQ4Y7n0LwHVBpDoaFVgQUtdu76 JovDa1ZQ==; Received: from authenticated user by zero.zsh.org with local id 1lKNzD-000I9E-Vp; Thu, 11 Mar 2021 16:16:32 +0000 Authentication-Results: zsh.org; iprev=pass (out4-smtp.messagingengine.com) smtp.remote-ip=66.111.4.28; dkim=pass header.d=daniel.shahaf.name header.s=fm2 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out4-smtp.messagingengine.com ([66.111.4.28]:59311) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lKNyv-000HzQ-Bg; Thu, 11 Mar 2021 16:16:15 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C4CDC5C00A7; Thu, 11 Mar 2021 11:15:54 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 11 Mar 2021 11:15:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm2; bh=/YEWZYrlTZEJHcGlnOOnc5teiy7l/sgSyfQ0PPOO /2I=; b=WicMgvSHR52aC4Ux6R6IvrZJ7y83ojqgTqtETzGXoxyqGoD80asrpEoI +tHWOO9Mdf4Yzc2O6J4PaqVwZYjomBY1jQHyx4mOJlKnpC6rpZrDZVp6Qpsp1OH7 oGcj/jt1mzZgT65PEnRn6w4Zia5QBpf152sjPidvWzejozdiJxjogWrU1Na3TbOO U+RDbCcKpRgQkBrRzW128mJT66YKHklSsCIQmA3gOQwFiL1AhBvc/Db4SMJ+cuH/ SximGKui9dYndj3MXxsfJDNDtKws/E09iMJEkpHq1KVAsmRU/+JQCzjs+R/SoFwu G2iDJ3AbD9ka6ODbTX6cDnuM+fdKmQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=/YEWZYrlTZEJHcGlnOOnc5teiy7l/sgSyfQ0PPOO/ 2I=; b=dmLbNST6OOYZzP/YvqEfCxJ7yjj5UZEFVuOp996q/0JemlzRCF7bTUSOA VLf8luv55Y5GlDSTjQ/ujElbfi4Ur8Qztix9PdMtOyhQJMzHL3ndR0xEKdK68Hfu O/bK1QnrtTgPsSWeaaFYhrajrbnRK4ZoWOMxbzGTpLl0DlenKtV5s2R9C5K3rVYW 65zPd4fpWmwkstmGXoDi5zfR4K7e4dlRbNXpgsfACS52lDs5v/bIsBaw3+SGIWmC ANnxZDdb5aBNtrp8BAn7D1GuEk5R/hoXoatjVOhn9rTpYIHpT1DpGFWKW2BPf5nq h8eu3gNzcC3EbE2LEZepq3dg/+/Sw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddvtddgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjggfsehtkedttddtreejnecuhfhrohhmpeffrghn ihgvlhcuufhhrghhrghfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpefgkefgfeejgfdvvdfguddtleelkedvfeetiedtudfhveev veduhfdvveeffedvueenucfkphepjeelrddujeeirddviedrieefnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepugdrshesuggrnhhivghlrdhs hhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-79-176-26-63.red.bezeqint.net [79.176.26.63]) by mail.messagingengine.com (Postfix) with ESMTPA id 4E653108006B; Thu, 11 Mar 2021 11:15:54 -0500 (EST) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4DxDZc2vpVz34K; Thu, 11 Mar 2021 16:15:52 +0000 (UTC) Date: Thu, 11 Mar 2021 16:15:52 +0000 From: Daniel Shahaf To: Jacob Gelbman Cc: zsh-workers@zsh.org Subject: Re: Completion script for the ctags program Message-ID: <20210311161552.GA9181@tarpaulin.shahaf.local2> References: <31598-1614116362.902856@aI-l.maGv.3QD7> <20210224142437.GC9342@tarpaulin.shahaf.local2> <3e0a754f-bbac-404d-92ba-b30f0c736f61@www.fastmail.com> <7f0a752e-2685-4c4b-8a31-b8db1728af1f@www.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7f0a752e-2685-4c4b-8a31-b8db1728af1f@www.fastmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 48165 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Daniel Shahaf wrote on Sun, Mar 07, 2021 at 22:10:56 +0000: > Jacob Gelbman wrote on Sun, 07 Mar 2021 21:57 +00:00: > > > On Mar 7, 2021, at 3:42 PM, Daniel Shahaf wrote: > > > Jacob Gelbman wrote on Sun, 07 Mar 2021 19:18 +00:00: > > >>>> elif [ "$state" = "languages" ]; then > > >>>> _values -s , languages $languages > > >>> > > >>> Don't pass unsanitized command output to a builtin. I don't know the > > >>> fix off the top of my head. > > > > > > This point has been neither responded to nor implemented. > > > > I sanitize the output a little bit, by cutting just the first word from > > the list that’s returned. That fixes lines like "OldC++ [disabled]" And > > I’m not that worried about possibly feeding in incorrectly formatted > > data. What’s the worst that could happen? The listing will look messed > > up? > > An option flag could be injected from an external command into compadd. [...] Do you intend to send a revised patch to address this? > You don't know in advance what flag that would be and what it would mean > in compadd (you need to consider future compadd too), so this is > essentially undefined behaviour.