From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 4675 invoked from network); 22 Mar 2021 17:18:08 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 22 Mar 2021 17:18:08 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1616433488; b=NljnOEq2Go6C2RBl9bZ9fxjoesVSf+spmKBKa4PMX25m1jd1eHcYpMiEDbGbG0Muz3uZY/h8Y5 Yv0B8ZdPadWBy12DUyMz9ISVWqqagGqtvnEzpSCJwkjnOkgq2vyVACugyamMdWCwWR345HSYEB 41WKoT/ujIti/nXsAtx9teqc8b4zPs8Xxq3UbDgy2gi2XWfFFdhKTxUEplTVqX+i/rvyQUzHWv w+QlQSkwMbjkNw8Oy8roeMGJwitV1cWboulVtdApGNAXfdDWNsykJHL5Tqbvr4OgN625zRMI6q F1e3Jqx/8zh5b5axHkAGiEtZ3YwATjVqSssg50sRy9OvdQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (relay13.mail.gandi.net) smtp.remote-ip=217.70.178.233; dmarc=none header.from=chazelas.org; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1616433488; bh=LTZI9rymZc44znZWDS5enNcS7SKuKThC/U///14yjyo=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:To:From:Date:DKIM-Signature; b=YvGdEQXEtUJEyRj7hL+hOYZiJiME75T8rLvDdhVm/xjw62++jpcI+TiLlghk8JcWZ3sMCQrbPm p5E1B/EUrfpufMxjD6LHWXX4xeQijzeA2Cg2Tv/oXtLuAVmEuAsVIDzA5kmVPBkbvh8u8TisQ4 pw2HSeKHOluE1xbzKJ7cuXgvlLqOY2N16n3h/Cm8+6s0kGuOD+8FtNDB7C4dFS2vHyxCcPm6U7 hrKlb7bwytCjmnYDFpYYuQd8QfLo5q3fgdzJoZdudIe0T++GKUYnlXkAD8w2/gvFydxpWAUJhl VU1SZRbM1BJUqF13pppAGmITq2abfDzp0NxEY7gL2XmFIw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=4YrmNZ6MHiT+7VSW8x8P0oVHzyMV1ThDapD05L1ovc4=; b=a+eGJEFBACehA+0VYc5xLemetT JJBDrterv12pwoPg2SGECNvUTpxNdF9X51MlpZa/GM/L1Xb2P5gPUXGH0lppCKEl/4Bvwl9qrxuDX ZlMssuCeDETFgr8JgfJAuauPelVUjgl/ZvMK+SGD3adnJvVlOTpj5eLaDfFDR6kUULvf+iG+R3KbR TGdHlc1IZwWePLh8o1jNdRHrbxlyTO7sut8p/kL6cZxXpFss02laSS7/JY80ky9JfPIDmA55HMgEY N7xBUCPiNK91+5+65fAzqgjn/BiWzobZD3e7OMTc/d2sSbyiNttYv0pSydVVGehNJVHvCqWuMV+OK x0bQ5YTw==; Received: from authenticated user by zero.zsh.org with local id 1lOOBr-000OKu-HL; Mon, 22 Mar 2021 17:18:07 +0000 Authentication-Results: zsh.org; iprev=pass (relay13.mail.gandi.net) smtp.remote-ip=217.70.178.233; dmarc=none header.from=chazelas.org; arc=none Received: from relay13.mail.gandi.net ([217.70.178.233]:24821) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1lOOBY-000OB8-QR; Mon, 22 Mar 2021 17:17:51 +0000 Received: from chazelas.org (0547c5a9.skybroadband.com [5.71.197.169]) (Authenticated sender: stephane@chazelas.org) by relay13.mail.gandi.net (Postfix) with ESMTPSA id 8631380006 for ; Mon, 22 Mar 2021 17:17:47 +0000 (UTC) Date: Mon, 22 Mar 2021 17:17:46 +0000 From: Stephane Chazelas To: Zsh hackers list Subject: Re: [PATCH] Fix [:IDENT:] vs posixidentifiers Message-ID: <20210322171746.67pb332lvf3a3pkk@chazelas.org> Mail-Followup-To: Zsh hackers list References: <20201217150844.zkjydkeutae7cdpq@chazelas.org> <20210207155013.ean4tgv57uhn22nu@chazelas.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210207155013.ean4tgv57uhn22nu@chazelas.org> X-Seq: 48224 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Ping again. Note that it's pretty straighforward, and I don't expect anyone would object to it. I also have a (much more involved and arguable) "limit" patch from last year which might be on someone's review queue. Maybe it would help to publish review queues on zsh.org (may as flat list of workers/1234 lines for each reviewer), so patch submitters can know whether or not the patch is being considered but reviewer are overwhelmed or it simply fell through the cracks. (in any case, I'm in no particular hurry for that (minor) bug to be fixed). Cheers, Stephane 2021-02-07 15:50:13 +0000, Stephane Chazelas: > Ping. Anybody objecting to this? > > 2020-12-17 15:08:44 +0000, Stephane Chazelas: > > $ zsh -c '[[ é = [[:IDENT:]] ]]' || echo no > > no > > $ zsh -o posixidentifiers -c '[[ é = [[:IDENT:]] ]]' && echo yes > > yes > > > > That should be the other way round. > > > > > > From: Stephane Chazelas > > Date: Thu, 17 Dec 2020 14:49:50 +0000 > > Subject: [PATCH] Fix [:IDENT:] vs posixidentifiers > > > > wcsitype(c, IIDENT) should return false for non-ASCII characters > > when the POSIX_IDENTIFIERS option is on, not the other way round. > > --- > > Src/utils.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Src/utils.c b/Src/utils.c > > index 5151b89a8..2a8d677a7 100644 > > --- a/Src/utils.c > > +++ b/Src/utils.c > > @@ -4327,7 +4327,7 @@ wcsitype(wchar_t c, int itype) > > } else { > > switch (itype) { > > case IIDENT: > > - if (!isset(POSIXIDENTIFIERS)) > > + if (isset(POSIXIDENTIFIERS)) > > return 0; > > return iswalnum(c); > > > > -- > > 2.29.2 > > >