From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 30006 invoked from network); 29 Mar 2021 16:04:37 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 29 Mar 2021 16:04:37 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1617033877; b=MPrIDxH8TNbL5rs6YrT9OaPqhJA48H07/x0w0iwQ4JHRDXoociK8ttwqJ7AVjdh1aoF+J82+x4 HZU7ehA3xpA84VKVhKEOHC8uaSsFfS1aYIbQ51VjsG+dYJkVjUlt6/uCm7VzvXkWew0GW1OB0M zCTo7Ws6Ygf61lcGt7oG7ZuULQ0PJr5HZDsStLlehk8/n9ZgAhnLzONdwHeAISYCfTJhbL4XJw QDXvCfEykGMYMBheRzLLIqNINjQc3JI2RbvXjTV2GFG181YLBjI4/r3/FFXogrTTAEaberRXPa fRcXCGYR0NaHvv/eUoKOFA8LA8zGwgARpuQv3cebhIuWEA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1617033877; bh=yvoN+FT6rf6LxepmVKSUStMod4xpjQxCx3BfVZRc144=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=aoG9+bTV0LSW0PyeQb0PUwmdA2Cwa/b3uLUp/ijiB6qpx0t1bqFRCVOL9oC18GCjtJWe4yC7xu Yo5d+Zm0X4vKh3Y1arW8hleAm9FevOpyKP/B6CpzK6CP4TrccAOPhqrHcXIGJjMiuxM8CQ/fwI XRtyhy974fLzuViLzaAWDm8iKMn0d4nxz3RIhi3avVRdL0jALphyaa8IXgWCOvcxfawegs/7TH rgyFjj60Wuz+Yo9Xh/Dg996IFL8S/y02ToNWkhvITJfWYj3miXgyEzY1Gng9o3xzdkSTDd1MUi iFVxxd11yKojbI0Muoz3wx8/UNMVzbw4UtrKfFpq+Vud4g==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=qtpPJYADnQ77mNpC7LORxDWJ/KhK/aZMEFdtxtEAobE=; b=WRlja/DQU+hREA33R/zDrRh8QJ RGohce/hUDNVqL3LxbsqVINJpwA7SyGfQM90bZQizELxeLdHzG5BYOqHYfkcj66eGhpKckVG57BAb 5Y9Zjar3VhtHavkbeBYivUSwkKg3lDJum5qXfmnf+8jN/VsUTWxvAXfeX0P6Yq4fAGx3aGRyJelDS X4Kat5dRwC4wsrcbC9vS8/RGDpubTXA3297tWz6DQZm4+vs739p6HtaXsg+Po9R3exdprVNJ3ICWl cArUhhgXulXnwIiRce4u1qqthznqhha8Ex9KeiHx4nCidGQF8F61rPuzlCfEERqqO8nDAWHDDSFlz PwEXIy+w==; Received: from authenticated user by zero.zsh.org with local id 1lQuNX-000Ae9-DJ; Mon, 29 Mar 2021 16:04:35 +0000 Authentication-Results: zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out2-smtp.messagingengine.com ([66.111.4.26]:57147) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lQuNI-000AUb-8B; Mon, 29 Mar 2021 16:04:20 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 545C85C011A; Mon, 29 Mar 2021 12:04:19 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 29 Mar 2021 12:04:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm3; bh=qtpPJYADnQ77mNpC7LORxDWJ/KhK/aZMEFdtxtEA obE=; b=iqkUXXYlriK/8AMZ+LyKbtM0GYhK7BrjOHFRcRsZ04PyDQTiwKH5gxxs F/dDQBYoz525fbupAnvFYPzRQOAYgSfRPlUhYwOba2QY3uZqr5tGvnudcBqRcOeb 8slkLDbdVBUk4c6C+JprdlCzbE7P8jt04Tsf64JejziI9129Ao6Kxh1Fn3NvcFMU DIXTZevbz2uoKaxVRVDscPhprbHd1bNDbyxnbzB2bH2lhN0kqaQdLGOgU+N1G/gI 5w/1GD7a0x1nvwTbT+xaWwhFVAV5LQefVpQCtpvdM5Fn9s4SaI3mmCaVcoUa+p6l LuDl4mszB61xwF4lwC8xzzftLnekqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=qtpPJYADnQ77mNpC7LORxDWJ/KhK/aZMEFdtxtEAo bE=; b=pZa6NCFJ5yNY1B2zRqd50KhMAjRuc3Yfo5nl99V0wn5fDT+wEx4rv6VOo 6w5W7bzK+I8MIfY9fDt00qyKT/4Sp8yNAUtxWq9gPteyVe8P1LMgJ58l0K6xfJ/4 KtuNzhXqhdKvdtcXI+gm1zxEwuPg+RUTw1iVB7A+GmAkUNd5pfVpRNLaI4EgdCpg dNMarRD+amTpZMgHSClZ+LJ8Ac3lU8NThm2pI6KCu4j92A7HdD/i2Akp1x+Eskad 4gv5E26eNTCPYFuukchYcUTUfHk0L71iihJvH7ClPSBcERTOENRw0J5SmQmiApuY Muak6IxR1XKlZJDf05IEM5hp2BNLw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudehkedgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjggfsehtkedttddtredunecuhfhrohhmpeffrghn ihgvlhcuufhhrghhrghfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpefgleehtdffuefhgeeuleefffejgedttdelhedvvdeuiefh vefgvdfghfevvdekteenucfkphepjeelrddukedvrdefiedrudekudenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegurghnihgvlhdr shhhrghhrghfrdhnrghmvg X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-79-182-36-181.red.bezeqint.net [79.182.36.181]) by mail.messagingengine.com (Postfix) with ESMTPA id AE865108005C; Mon, 29 Mar 2021 12:04:18 -0400 (EDT) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4F8HSw5XHgz44r; Mon, 29 Mar 2021 16:04:16 +0000 (UTC) Date: Mon, 29 Mar 2021 16:04:16 +0000 From: Daniel Shahaf To: Aleksandr Mezin Cc: zsh-workers@zsh.org Subject: Re: [PATCH v4] vcs_info: choose backend by basedir Message-ID: <20210329160416.GU18178@tarpaulin.shahaf.local2> References: <20201114193703.1428617-1-mezin.alexander@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201114193703.1428617-1-mezin.alexander@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 48328 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: Aleksandr Mezin wrote on Sun, Nov 15, 2020 at 01:37:03 +0600: > Also, this patch adjusts VCS_INFO_detect_git and VCS_INFO_detect_cvs to make > them set vcs_comm[basedir], by moving basedir detection code from corresponding > VCS_INFO_get_data_* functions. VCS_INFO_detect_git and VCS_INFO_detect_cvs were > the only VCS_INFO_detect_* functions not setting it. I've committed this part. The code wasn't wrong, but consistency between backends is a good thing to have. > +++ b/Functions/VCS_Info/Backends/VCS_INFO_get_data_git > @@ -138,7 +138,7 @@ VCS_INFO_git_handle_patches () { > > gitdir=${vcs_comm[gitdir]} > VCS_INFO_git_getbranch ${gitdir} It seems to me this call should be moved below the assignment of rrn, in case VCS_INFO_detect_git ever wants to query zstyles. (preëxisting issue) > -gitbase=$( ${vcs_comm[cmd]} rev-parse --show-toplevel 2> /dev/null ) > +gitbase=${vcs_comm[basedir]} > if [[ -z ${gitbase} ]]; then > # Bare repository > gitbase=${gitdir:P} (Haven't forgotten about the non-drive-by part of the patch, either.) Cheers, Daniel