From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Rewrite of zsh-newuser-install
Date: Mon, 5 Apr 2021 18:16:37 +0000 [thread overview]
Message-ID: <20210405181637.GA22397@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CAHLkEDt+=qEL-jMqYxKBXBZuPEi_=dm-Ms-6oZY=b-RyjXJ2rw@mail.gmail.com>
[ for skimmers: there's an unrelated question in the P.S.. ]
Marlon Richert wrote on Sat, Mar 20, 2021 at 00:12:28 +0200:
> Hi all! I pushed in another update:
> https://gitlab.com/marlonrichert/zsh-sensible/-/blob/master/zshrc
>
> I reorganized the entire .zshrc file in an effort to make it easier to
> read. I'd love to get your feedback.
>
> Also, I'm wondering: How do you plan to make a decision on moving
> forward with this? At which point are the new files good enough to
> replace the existing zsh-newuser-install?
Here's a quick review of zshrc and your version of zsh-newuser-install.
Haven't read the entire thread yet, so apologies if I'm repeating issues
previously raised.
Issues in the first-run wizard:
0. I recommend against reusing the name zsh-newuser-install for
a completely different thing. Names shouldn't be overloaded.
1. Errors from «mkdir ZDOTDIR» are discarded.
2. Uses of eval are unsafe (lack ${(q)}) and unnecessary.
3. That also applies to the munging of $template.
4. "$zshrc~" is silently overwritten
5. what happens if the exec on the last line fails?
6. Outputting `man zsh' in two different colours is confusing.
7. zsh's homepage is https://www.zsh.org/.
8. zrestart doesn't handle $ZDOTDIR.
9. For educational purposes, printing should use «print -r --» throughout.
10. Should zrestart use «exec»?
11. «print '\n'» prints _two_ newlines. That's too obscure for
educational code.
Issues in zshrc:
12. Some settings seems like they could break the principle of least
surprise: e.g., FLOW_CONTROL, NUMERIC_GLOB_SORT, matcher 'b:-=+',
check-for-changes (as opposed to check-for-staged-changes).
13. Recommend not to hide symbols from grep, as in up-line-or-{search,history}
14. Use of «bindkey -s … '^Q…'» seems questionable. As a way to inject
commands, it prints them to the tty and adds them to the history; that
doesn't seem elegant enough for example code that all new users would be
pointed to. It's also brittle in that it depends on ^Q not being
re-bindkey'd to anything else.
A few proposed additions:
15. hjkl bindings for menu selection:
if zmodload zsh/complist 2>/dev/null || (( ${+keymaps[(r)menuselect]} )); then
bindkey -M menuselect j down-line-or-history
bindkey -M menuselect k up-line-or-history
bindkey -M menuselect h backward-char
bindkey -M menuselect l forward-char
fi
17. Configure vcs_info to show the original patch's information during
rebases, etc.. It basically boils down to doing
«hook_com[applied-string]=$1» in a gen-applied-string hook. I posted
a fuller version in workers/47519 at the end.
18. Show how to use terminal colours/attributes other than the basic
ones. E.g., I use ${terminfo[dim]} in some places.
Cheers,
Daniel
P.S. I wonder if «: <->» should always behave as though
NUMERIC_GLOB_SORT is set. Haven't tried to nail down a complete
functional spec yet; just thinking out loud.
next prev parent reply other threads:[~2021-04-05 18:17 UTC|newest]
Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-06 20:03 Marlon Richert
[not found] ` <0102017778f35f33-a962e4d3-83e9-4d3b-a0d7-45701bb40b11-000000@eu-west-1.amazonses.com>
2021-02-06 20:19 ` Marlon Richert
2021-02-06 20:33 ` Lawrence Velázquez
2021-02-06 21:54 ` Bart Schaefer
2021-02-07 13:41 ` Marlon Richert
2021-02-07 13:51 ` Roman Perepelitsa
2021-02-07 17:10 ` Marlon Richert
2021-02-07 17:28 ` Marlon Richert
2021-02-07 20:20 ` Bart Schaefer
2021-02-07 21:06 ` dana
2021-02-07 21:15 ` Marlon Richert
2021-02-08 21:57 ` Marlon Richert
2021-02-08 23:33 ` Lawrence Velázquez
2021-02-09 1:42 ` Bart Schaefer
2021-02-09 2:00 ` Bart Schaefer
2021-02-09 8:18 ` Marlon Richert
2021-02-09 23:09 ` Bart Schaefer
2021-02-09 8:17 ` Marlon Richert
2021-02-09 8:29 ` Roman Perepelitsa
2021-02-09 23:16 ` Bart Schaefer
2021-02-12 0:09 ` Bart Schaefer
2021-02-12 5:58 ` Marlon Richert
2021-02-09 4:51 ` dana
2021-02-09 6:00 ` Bart Schaefer
2021-02-09 7:30 ` dana
2021-02-09 7:34 ` dana
2021-02-09 9:55 ` Marlon Richert
2021-02-09 10:01 ` Roman Perepelitsa
2021-02-09 10:04 ` Marlon Richert
2021-02-09 10:56 ` dana
2021-02-09 11:14 ` Roman Perepelitsa
2021-02-09 11:39 ` Marlon Richert
2021-02-09 17:21 ` dana
2021-02-09 21:01 ` Marlon Richert
2021-02-09 21:41 ` Marlon Richert
2021-02-09 23:15 ` dana
2021-02-10 0:02 ` Bart Schaefer
2021-02-10 7:02 ` Marlon Richert
2021-02-10 6:57 ` Marlon Richert
2021-02-12 0:10 ` Bart Schaefer
2021-02-12 5:59 ` Roman Perepelitsa
2021-02-13 0:23 ` dana
2021-02-10 2:30 ` Bart Schaefer
2021-02-10 7:44 ` Marlon Richert
2021-02-10 20:27 ` Marlon Richert
2021-02-11 8:30 ` Bart Schaefer
2021-02-11 21:11 ` Marlon Richert
2021-02-11 22:57 ` Bart Schaefer
2021-02-12 5:49 ` Marlon Richert
2021-02-12 5:47 ` Marlon Richert
2021-02-12 23:43 ` Oliver Kiddle
2021-02-13 1:11 ` Bart Schaefer
2021-02-12 23:26 ` Oliver Kiddle
2021-02-13 0:15 ` Marlon Richert
2021-02-13 1:33 ` Bart Schaefer
2021-02-13 1:36 ` Oliver Kiddle
2021-02-13 2:53 ` Bart Schaefer
2021-02-13 10:26 ` Marlon Richert
2021-02-13 22:53 ` Marlon Richert
2021-02-14 0:34 ` Bart Schaefer
2021-02-14 8:12 ` Marlon Richert
2021-02-13 22:56 ` Bart Schaefer
2021-02-14 8:01 ` Marlon Richert
2021-02-19 21:38 ` Marlon Richert
2021-02-20 0:30 ` dana
2021-02-20 8:18 ` Marlon Richert
2021-02-20 18:57 ` Bart Schaefer
2021-02-21 19:24 ` Marlon Richert
2021-02-24 22:15 ` dana
2021-02-25 8:05 ` Daniel Shahaf
2021-02-25 16:58 ` dana
2021-02-26 22:31 ` Marlon Richert
2021-02-27 13:21 ` Daniel Shahaf
2021-02-27 13:46 ` Daniel Shahaf
2021-03-19 22:12 ` Marlon Richert
2021-03-24 13:45 ` gi1242+zsh
2021-03-24 14:16 ` Paul
2021-03-24 17:44 ` Bart Schaefer
2021-03-24 20:38 ` Marlon Richert
2021-03-25 3:36 ` Paul
2021-04-05 18:16 ` Daniel Shahaf [this message]
2021-04-05 18:52 ` Sorting of <-> (was Re: Rewrite of zsh-newuser-install) Bart Schaefer
2021-04-05 21:31 ` Rewrite of zsh-newuser-install gammafunction
2021-04-07 14:45 ` Marlon
2021-04-09 16:49 ` Marlon
2021-04-09 23:14 ` Daniel Shahaf
2021-04-10 1:17 ` Oliver Kiddle
2021-04-07 18:17 ` Mikael Magnusson
2021-04-07 18:56 ` Daniel Shahaf
2021-03-24 10:00 ` Marlon Richert
2021-03-25 1:15 ` Daniel Shahaf
2021-04-05 14:00 ` Marlon Richert
2021-04-05 18:36 ` Daniel Shahaf
2021-04-05 19:22 ` Daniel Shahaf
2021-02-22 3:54 ` Paul
2021-02-22 8:14 ` Marlon Richert
2021-02-22 16:31 ` Bug in compdescribe with matcher 'b:-=+' Bart Schaefer
2021-06-14 8:28 ` Marlon Richert
2021-08-12 12:03 ` Marlon Richert
2021-08-12 16:15 ` Bart Schaefer
2021-02-19 21:34 ` Rewrite of zsh-newuser-install Marlon Richert
2021-02-13 1:28 ` Bart Schaefer
2021-02-13 1:34 ` Bart Schaefer
2021-04-22 13:57 ` Marlon Richert
2021-02-09 23:05 ` Bart Schaefer
2021-02-09 9:44 ` Marlon Richert
2021-02-09 18:13 ` Greg Klanderman
2021-02-08 9:21 ` Peter Stephenson
2021-02-08 6:35 ` Daniel Shahaf
2021-02-08 8:44 ` Marlon Richert
2021-02-08 8:46 ` Marlon Richert
2021-02-08 10:32 ` Daniel Shahaf
2021-02-08 17:44 ` Marlon Richert
2021-02-08 20:47 ` Bart Schaefer
2021-02-09 21:44 ` Eric Cook
2021-02-09 22:34 ` Bart Schaefer
2021-02-07 20:22 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210405181637.GA22397@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).