From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: "zstyle -L" doesn't quote properly
Date: Wed, 7 Apr 2021 17:36:22 +0000 [thread overview]
Message-ID: <20210407173622.GD6316@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <CAH+w=7bNbz97RzMQNyAVjgzVtSQotwwfSFNb1c2p7-0vPFjMuQ@mail.gmail.com>
Bart Schaefer wrote on Wed, Apr 07, 2021 at 09:42:12 -0700:
> This occurs as a result of a typo when defining the style (the word
> "menu" is misplaced after a copy/paste/edit) but produces garbage
> output. I think the assumption is that in the syntax ...
>
> zstyle [ -e | - | -- ] PATTERN STYLE STRING ...
>
> ... the STYLE must be a simple word and therefore doesn't need
> quoting, but in fact the command will accept any sort of string in
> that position.
>
> % zstyle -e ':completion::*:default' '[[ $WIDGET =
> (|reverse-)menu-complete ]] && reply=(menu yes select interactive)'
> % zstyle -L
> zstyle -e ':completion::*:default' [[ $WIDGET =
> (|reverse-)menu-complete ]] && reply=(menu yes select interactive)
Here's a test.
Right now it prints "ke\x83 y", i.e., the correct value, but metafied
and not escaped.
I'll go ahead and commit it, but whoever is working on a fix, feel free
to tweak/extend it as needed.
Cheers,
Daniel
.oO( type-safety for metafied/tokenized/verbatim strings )
diff --git a/Test/V05styles.ztst b/Test/V05styles.ztst
index 048751941..3fcedfef1 100644
--- a/Test/V05styles.ztst
+++ b/Test/V05styles.ztst
@@ -164,3 +164,12 @@
0:the example in the documentation remains correct
>snow
>snow
+
+ (
+ zstyle $'con\x00text' $'ke\x00y' $'val\x00u' $'e'
+ a=( ${(f)"$(zstyle -L)"} )
+ a=( ${(M)a:#*con*text*ke*y*val*u*e} )
+ print -r -- "$a"
+ )
+-f:zstyle -L escapes the key (regression: workers/48424)
+>zstyle $'con\C-@text' $'ke\C-@y' $'val\C-@u' e
next prev parent reply other threads:[~2021-04-07 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 16:42 Bart Schaefer
2021-04-07 17:36 ` Daniel Shahaf [this message]
2021-04-07 18:12 ` Bart Schaefer
2021-04-07 18:24 ` Daniel Shahaf
2021-04-07 19:21 ` Peter Stephenson
2021-04-07 19:43 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210407173622.GD6316@tarpaulin.shahaf.local2 \
--to=d.s@daniel.shahaf.name \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).