zsh-workers
 help / color / mirror / code / Atom feed
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: zsh-workers@zsh.org
Subject: Re: _arguments -n / $NORMARG (was: Re: [PATCH 1/2] __arguments: New completion function for _arguments.)
Date: Fri, 9 Apr 2021 22:52:38 +0000	[thread overview]
Message-ID: <20210409225238.GC6760@tarpaulin.shahaf.local2> (raw)
In-Reply-To: <81257-1617996298.439634@WyT_.pTdt.VYqg>

Oliver Kiddle wrote on Fri, Apr 09, 2021 at 21:24:58 +0200:
> On 1 Apr, Daniel Shahaf wrote:
> > Could you elaborate on what cases «_arguments -n», as implemented, would
> > cause breakage in?
> 
> I can't remember the exact details, it was a while ago that I went over
> the _arguments source code. But I think you can cause issues by having
> optional arguments to options and not just sets - those also produce
> multiple possible states. The field in castate was being misunderstood
> in general. Sorry I realize I'm being a bit vague but I don't remember
> the details sufficiently.
> 
> I think I intended to fixup each of the uses of the option first before
> raising the issue but I never got around to that.
> 
> > The manual doesn't already include such a warning, but I don't
> > understand how exactly $NORMARG is broken, so I can't document that.
> 
> It'd be less effort to simply drop it from the documentation or mark it
> strictly deprecated. It isn't particularly needed.

Well, I'm not fond of documenting problems from memory, but
a deprecation notice would probably be useful to readers, so no
objections from me to doing that.

Thanks,

Daniel


  reply	other threads:[~2021-04-09 22:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01  0:00 [PATCH 1/2] __arguments: New completion function for _arguments Daniel Shahaf
2021-04-01  0:00 ` [PATCH 2/2] ___arguments: New completion function for __arguments Daniel Shahaf
2021-04-01 12:53 ` [PATCH 1/2] __arguments: New completion function for _arguments Oliver Kiddle
2021-04-01 17:33   ` Daniel Shahaf
2021-04-01 22:34     ` _arguments -n / $NORMARG (was: Re: [PATCH 1/2] __arguments: New completion function for _arguments.) Daniel Shahaf
2021-04-09 19:24       ` Oliver Kiddle
2021-04-09 22:52         ` Daniel Shahaf [this message]
2021-04-02 23:58     ` [PATCH 1/2] __arguments: New completion function for _arguments Oliver Kiddle
2021-04-10 20:41       ` Lawrence Velázquez
2021-04-13 11:28         ` Daniel Shahaf
2021-04-17 12:25       ` Daniel Shahaf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210409225238.GC6760@tarpaulin.shahaf.local2 \
    --to=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).