From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 21192 invoked from network); 13 Apr 2021 12:32:57 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 13 Apr 2021 12:32:57 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1618317177; b=HWyAPmGAHJIzh3/QGCwtvuxmwo3WC0CMAVrwQFGCmRkrPPkYBkhqYQ+ZmR4ZRSsZJJkj0tWqtW mhQwaN12kjfqk7fpGHgI2B9bemNQkw01oDBAriaOUTiECNrmU/vVDAuCwz0aEX8UcqJrSBeGTi Tk1m7YATGJkEEephAylxTrnvREiuAZXs07a+ncVsezruwHOzblOJ4gOnZ61SQFdNAFSXPM3o3U xldzmg6axqXMuQaAzEBXfLli02+8cHh+mP810koH/94vPzgVRs+FsCHrUq0GYiDPyZbdgRDGMm K8J67d6rhW9UmCMF1QO7wgZ7oN3uaBQ4gjrPM+wNVdxptA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out4-smtp.messagingengine.com) smtp.remote-ip=66.111.4.28; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1618317177; bh=rjx2TV+PjkgyvoOuuILIbjbabITHbsuUGuQJtMs9cMc=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=siAXJ+a2Z4V9NkR6nRYoyWIcyvHhcMsEQwmaVXQ6YQzCczi9kbUqWdmA4t+9ONX22hCzLsZPbS zMOZRRuGAuK5wR/dyeElhFVW+1KYGW3hkLeZkdU2VjVbZ2E/efNoF9kNyYuq8W1dOe/yCRXqsn ZnFQAOOZ/MepXmRdOA4imIArsXjTLHET+1rXsJRVT8v/cFjMerVR2WE95ejV6+G/1lNCgb+hip TUPq5q2o5KgoMmNtZGML+JIWgFLxa3O85PMwFOObBjeyJvvuyPX5qEFDyS2oCvpaVrWPpC1RJU cpHkH2gY6oR1woSx6UnJDUQuWCUo5yAbFOKzXl9vo3OICA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=uz06xtdP9/rNfaxK0s8h9OblhgxUdN3wSUiAps9ijuE=; b=l4muPSndNiH/5TA4Y9ukRgWl7e H65ewkoUDzU1tIOqg3f4g1q+TUBJhRejuGjz/mNt/HoeheRHCRSETueSggYowxsqfxCC3UEftbMZP P2ggZbdnAgDasin34yfp09Olx0T/A4eWv2fYqGs4YsdxqMO2wwak4+jspIke4uEJvYLjj5GuV20Jz TTcafzeTFYsxSkQt1pHFGbQCwoZqcesjM+vPlzBZoAKQuOXUKLEmkde3BMX+4k/RXc8GYcm2OTQjY q+g5Ajo/Pkz67PKqK5MgTTpmC/Fb34zql+g9UT02hcmofjYe0oUFmJKvRE81M/SPfYNzpKDjussWD DblqUUYQ==; Received: from authenticated user by zero.zsh.org with local id 1lWIDs-000OUb-PU; Tue, 13 Apr 2021 12:32:52 +0000 Authentication-Results: zsh.org; iprev=pass (out4-smtp.messagingengine.com) smtp.remote-ip=66.111.4.28; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out4-smtp.messagingengine.com ([66.111.4.28]:57223) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lWIDN-000OFF-0i; Tue, 13 Apr 2021 12:32:22 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 057F75C00DC; Tue, 13 Apr 2021 08:32:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 13 Apr 2021 08:32:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm3; bh=uz06xtdP9/rNfaxK0s8h9OblhgxUdN3wSUiAps9i juE=; b=sLLYlVX6PBars+CzPHN5jtSqg8uHuu1uC8Uftcjid49d6fYL+x64FgrE yn6r0iLPFUE/AuwF2B6/BRbIg+oXWWW9GyFmkpf8YjjAzx1qHWn+0/yAAcg8E4SC 2OB+UKsOmWGOVRbxzgmMbnK0tAbnAPILjYU0i21HAMwwLBp2LfpYtH193/a1OSJK cVCP1s7gYuIWGA0altk7pDyMKW/PqRkKKZbH0ctxh765DDU0JZvN65GPcblUqV1V PcArqi0ykWa3kPMpgLupGPXHAY6q5KqpTsrZCmiVkckPkDa6nlL2ht2tZ1hbS54v 2aWh1I3nab2Y1RWmWLRV15Go8cPycQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=uz06xtdP9/rNfaxK0s8h9OblhgxUdN3wSUiAps9ij uE=; b=d7+7rOYTtlWt5kNgdu2NsEVJK3oQ10GaW9EBv+U2QvkUSJU/YiFH4zQPP F0/2AkqJLWfxSyEu0IwGjSFnbobw6cbBmrofS0+3lKkuxbuB1lvY1wKmzJHisj2F 5Fn14Z6AHSt5I7NfVzYlu4SD5wFcu+ab6tlcjRy1dLS0JMQ7cG79quEt6CljFcBS 09+wh+1YJseDC1jscDud/HOjHIU63L5zTUCBDnqjmmYbtNXhcduhPBktJ8nZEtzc xWz5tGSwAyplII86+h/n2RW9hfi7AaeYfSGHj4eVOR1woRLcplQJ8PglLJ8cCp3D IMOyxAqJxVyrEKv/7+oZQPH1aWbRQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekledgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggugfgjfgesth ektddttderudenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghn ihgvlhdrshhhrghhrghfrdhnrghmvgeqnecuggftrfgrthhtvghrnheptdfggeelvdfhfe fhgeejfeeihfduleeiieehgfevgfdugeelffekteduvdegveegnecuffhomhgrihhnpehp rhhoughutghinhhgohhsshdrtghomhenucfkphepuddtledrieeirdeifedrvdeftdenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegurdhssegu rghnihgvlhdrshhhrghhrghfrdhnrghmvg X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-109-66-63-230.red.bezeqint.net [109.66.63.230]) by mail.messagingengine.com (Postfix) with ESMTPA id 4B67424005E; Tue, 13 Apr 2021 08:32:02 -0400 (EDT) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4FKQ341rpDzhV; Tue, 13 Apr 2021 12:32:00 +0000 (UTC) Date: Tue, 13 Apr 2021 12:32:00 +0000 From: Daniel Shahaf To: Marlon Cc: Lawrence =?iso-8859-1?Q?Vel=E1zquez?= , Zsh hackers list Subject: Re: Patch bumping (was Re: Feature Patch: Use completion to view parameter values) Message-ID: <20210413123200.GI6819@tarpaulin.shahaf.local2> References: <20210329171120.GA6044@tarpaulin.shahaf.local2> <20210329181452.GB6044@tarpaulin.shahaf.local2> <18618-1617324651.844569@tLsN.0hLE.FeTt> <2c44b17c-407d-449e-be2e-610db313c1d7@www.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 48526 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: [Marlon: Your quote attribution line is indented one more level than is conventional] Marlon wrote on Mon, Apr 12, 2021 at 11:18:43 +0300: > On 12 Apr 2021, at 00:24, Bart Schaefer wrote: > > With appreciation for Lawrence's efforts, I'd respectfully request > > that the criteria for when to send a "bump" become a matter of record. > > > > There seem to me to be these cases: > > > > 1. The patch has never been reviewed or discussed. > > 2. The patch was reviewed and is acceptable, but was never applied. > > 3. There was a discussion, but it ended without resolution. > > 4. The patch was referred back to the author after review or discussion. > > > > There is room for subjective interpretation of "is acceptable". A > > possible resolution of #2 is that the patch is rejected after all > > (perhaps it has become obsolete in the meantime). > > > > I mention this mostly because I think the useful elapsed time before > > "bumping" might be different in each case. In particular #4 seems > > like it could be left considerably longer, unless the patch is fixing > > a serious bug or security issue. > > > > Thoughts? Leaving #4 "considerably longer" would decrease temporal locality in the patch authors' brains, would reap less "the project noticed my lack of response" benefits (cf. https://producingoss.com/en/managing-participants.html#delegation-followup), and would be more likely to find the patch author busy with other things and unable to follow up and post a revised patch. You don't actually say what benefits you seek to attain. Is it about, say, bumps that are replies to previous bumps? If so, I'd propose, say: - A bump that is a reply to a non-bump should be sent with delay X. - A bump that is a reply to a bump should be sent with delay Y. - A bump that is a reply to a bump that is a reply to a bump should be sent with delay Z and added to git (as proposed in workers/48303). - A bump (that is a reply to a bump)³ should not be sent. (Feel free to read "should" and "should not" in their rfc2119 senses.) > Additionally, it would be helpful if committers remember to inform us > when a when a patch has been accepted/rejected/applied, This would be helpful for other other reasons too: - It would let the patch submitter know their patch has been accepted. (Simply committing the patch to git without replying to it might leave the patch submitter think they were ignored.) - It would make it easier for other committers to skip PATCH threads that have already been handled. > to avoid unnecessary bumps. Cheers, Daniel