From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FAKE_REPLY_C,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 29329 invoked from network); 13 Apr 2021 13:35:47 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 13 Apr 2021 13:35:47 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1618320947; b=saCb9RYyuH7QCZRNaLiIdBNVFrSrqoPU+fSDmRFzILngWs86IQC7sMguoTs8U/PDfKnhwVhrdC C/0sMXlJeKcadJfUFGQc+FY/X58RST6yb5JI93NtkYCA+V5fsc/Pdgbt9OHKTm3ytZlofnTwoX Lhm7xJYh5OqLZI7d6lT4k9qnLHTIagkqLzUodM6Kg+F9dpU38UCNiwWXqVd2hi82eGtFTcbgSD PxZE3NSSANGYckA53ehGoieZofBtKtTTHBm51mR0l2XRXltfXWrxHc+q7YiZg0Z62HK/Cb92eK OAyG+3+efFiODyZBgdRtGgsI1J1BeaSLDw++4tQ/Wptd/A==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1618320947; bh=IEqGOBJ16OAmaQWacTJ6DnVnEU4r2Mbji0I4GEiOmoM=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Subject:To:From:Date:DKIM-Signature:DKIM-Signature: DKIM-Signature; b=Kc0TpgZUKO5DtMzwTPZiM0mc2UheQ+FoLs8VDMLXRq/H2Yp4uyi3oIiuy+7Xh0PE07BEjUah/Q 7tdrUvHxNzTpclyLBRMhIiSQBsG0Y+ciQKNebsZihKWAq7Ilb7dij7OY4T+Anv/X/cnoiC+ytK mvlc8sardN9xkDf8VBGlUgyh/v9SB4b9NfHTOzKsJxMftiWwMG7uhHYuVzcHF7jX2+yf9ts96m E1oyPgmSLDLJrWbgIsOlZ+mepZe8/Jbop0Lcv62FDVTJVueOPKYTPDk8APTtlOAo5XBWa9cCJA AFzblwg6nHz5AVc9adlHShsDbfve2Ca0dCla1gyOc6btYA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:Message-ID:Subject:To:From:Date:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:References; bh=D9G1ZQAJrhU6CzElofVZ/Ymi2XAR+dAZFMzp9NRC1mw=; b=p/9sKCUQyO85TUkDIfOZubZ0M8 7s14sW6cTbW6U7Y/YbIWVvAVVAEEVWvw0Lyzxsae53TA9m5fStF1Ad2sYSCX2YcTXAyreSEYNz2D+ araMIICtYEPGz/YL5a2Jnbai4rxTaLPJwItBlMCPwML4IsA9lLD0jIeINnOVTcwvrckDoWWhX3Vuj 8jD35J+JT83jssZoMneHC0QvQlF4/WCwXZA7yeGWv+ak+ibyLZxLZVwisGAchtfwWr+c7Gakkt2qF rFNQ9QDi/nEAx6EyXfUoo0uyhdXYotRzffhNl4QE38W5SlzQxP7FVX2a+gVWUQZL1IhgiIoupDJvz w6k0/LBA==; Received: from authenticated user by zero.zsh.org with local id 1lWJCi-0000NE-5H; Tue, 13 Apr 2021 13:35:44 +0000 Authentication-Results: zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out2-smtp.messagingengine.com ([66.111.4.26]:58909) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lWJCS-00009K-DS; Tue, 13 Apr 2021 13:35:30 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 1450A5C0154; Tue, 13 Apr 2021 09:35:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 13 Apr 2021 09:35:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:subject:message-id :mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm3; bh=D9G1ZQAJrhU6CzElofVZ/Ymi2XAR+dAZFMzp9NRC 1mw=; b=WUpuRf+p1zQUKm4IrVbeiZUVHnk9iR7ZXISad5RKke1S4CVDpbE0L6X7 uzovGadDyGwPlozdAzGrtUfRaOac0SfvMvtuXqwFXcUFPvQe/nlYSyno1KDOiLZZ ijOP9DvXoITsCwOEvCRpSc83qXFFIDTieREZkbDHWZCjk9/13uhq+xDJwh+yOhBr 0GGsZgTXygquQRqHBawXQmVGN7cq41/3zBEycw8F4bTyo5yYaE6gs5vgZ7nw2czh 35shSQ6s3CtcB1ZIucPtIvXnMuqACsowanzUBVP6RlwrX7m2CK0UfbqJOrWskAYV sJEPHN+Y63b554AF6OYilj7g44tSdg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=D9G1ZQAJrhU6CzElofVZ/Ymi2XAR+dAZFMzp9NRC1mw=; b=V+hQwqi8 4dM/hRIrEyWhdOFZCH45PZiYZjsYltGiCRd8Q8UKXuT1DexM3XngS9d7KsXiofNn KNNLwNMX2IyECCRj75+2KxdiYvkQahHSR7iFh/+IzJl66d24YOj15cwBL7JwZ5dL 2yEH//qLIqhhMfIkebC0fLwK+dggG+JQBw2nwiTn78CyVNcv4lLg6OAITYdA1xM2 ImHJb04vmBZuNZIcuSxxMhdThnPe3DhjwTvCRulxzIWiTrnFVWlHY2TuC/p8Rgrt q+ZpkChbGvcuzObVyhvrD7awZAM41J2ayfL+5fsvcxWwetagZ6ZusuYm7BZmxsK+ g0Io7BSU2b1QkQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekledgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkgggtugfgjggfsehtke dttddtreejnecuhfhrohhmpeffrghnihgvlhcuufhhrghhrghfuceougdrshesuggrnhhi vghlrdhshhgrhhgrfhdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeevudfgueeihfdtud ejudetteduieetudekudfgjefgveegjedvvddutedvhfetvdenucfkphepuddtledrieei rdeifedrvdeftdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpegurdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvg X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-109-66-63-230.red.bezeqint.net [109.66.63.230]) by mail.messagingengine.com (Postfix) with ESMTPA id 6F3A51080057 for ; Tue, 13 Apr 2021 09:35:26 -0400 (EDT) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4FKRSD2W1FzhV; Tue, 13 Apr 2021 13:35:24 +0000 (UTC) Date: Tue, 13 Apr 2021 13:35:24 +0000 From: Daniel Shahaf To: Zsh hackers list Subject: Re: Patch bumping (was Re: Feature Patch: Use completion to view parameter values) Message-ID: <20210413133524.GJ6819@tarpaulin.shahaf.local2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <447A0505-D429-4714-A225-994B61213973@zsh.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 48527 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Marlon wrote on Mon, Apr 12, 2021 at 11:18:43 +0300: > On 12 Apr 2021, at 00:24, Bart Schaefer wrote: > > 1. The patch has never been reviewed or discussed. > > 2. The patch was reviewed and is acceptable, but was never applied. > > 3. There was a discussion, but it ended without resolution. > > 4. The patch was referred back to the author after review or discussion. ⋮ > > I mention this mostly because I think the useful elapsed time before > > "bumping" might be different in each case. In particular #4 seems > > like it could be left considerably longer, unless the patch is fixing > > a serious bug or security issue. > > I would suggest the following minimum wait times before bumping: > > * To remind about an unresolved patch (not yet reviewed, not yet responded to by author after review, not yet accepted/rejected/committed, etc.): > * security issues: 2 days > * critical bug fixes: 1 week > * all other patches: 2 weeks > * Everything else: 1 month I'm not sure what cases fall into "etc." and what cases fall into "everything else", nor what would a "critical" bugfix be. Lawrence Velázquez wrote on Mon, Apr 12, 2021 at 22:47:50 -0400: > On Apr 11, 2021, at 5:24 PM, Bart Schaefer wrote: > > With appreciation for Lawrence's efforts, I'd respectfully request > > that the criteria for when to send a "bump" become a matter of record. > > Certainly! I've been combing the lists every Saturday afternoon/evening > UTC and uniformly bumping recent discussions that have been inactive for > more than five days (to loop in the preceding weekend). > ⋮ > (A) A noncommitter is waiting on a committer (#1, #2, #3). > (B) A committer is waiting on a noncommitter (#4). > (C) A committer is waiting on other committers (the parallel cases). > > As the reason the "patch manager" role exists [*], group A should > be handled expeditiously, while groups B and C can wait. (This > classification reflects how meddlesome I feel when I send reminders.) > > I think a threshold of 1-2 weeks remains appropriate for A, but > perhaps ~1 month would better suit B and C? How would differential delays affect your workflow? A uniform criterion (such as "Thread has been dormant for >5 days") should be easier to apply. Regarding your taxonomy, would it be accurate to say that in cases A and B a submitted patch is awaiting resolution, whereas in case C it's generally a design question that's awaiting resolution? In A+B the person in question is the patch submitter; in C the person in question is probably a regular developer. (Aside: Note the terminology: "developer", not "committer", since in general, distinctions between people who do and don't have commit access shouldn't be made, except when it's necessary to actually invoke «git push».¹) Regarding the magic numbers, I think one month is too long for case B (cf. my remarks today in workers/48526). We don't want to bump _too_ soon either, but I'd aim for something on the order of a week (for the first ping, again as per 48526). "Once a week for patches ≥6 days old" achieves that, as would, say, "at least 48 weekend hours and at least 72 weekday hours". No comment from me on case C. Cheers, Daniel > > unless the patch is fixing a serious bug or security issue. > > Do you think we need to prescribe a standard for these? They seem > pretty rare, and committers are unlikely to let them drop through > the cracks. My initial inclination is to leave them to committers' > discretion. (I'm not privy to zsh-security@ anyway.)