From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 8822 invoked from network); 13 Apr 2021 15:01:59 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 13 Apr 2021 15:01:59 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1618326119; b=aMxOAl4nmh2ShH9LvqXJc+CBa/jgzkLMlNDDfWlO/htw7LSFr4VPPk+H0cIRuGMxxsr/gj4Lfo 4BWUKiguWScPFUgGbq++Lam1tzinxIEsUHJ/V4JdifSnYFBABNelX7ZBSl2DpOaVTnoPQy1afa 7smDr+0LUKqdFvbuOHOin3u+Evq85AvoPApxZ2ushN4vkRW63arjC5yjrtvlivA4w48DOeSyQU zXf/b1OCZ1MGxX4tI+95waEyDo4NT6eSUx3caI115It30nz4Ly9PoREsT1gQiePpJVFKH5jJ6J bc09BnMVnrxFVAh0ek487N/TRlZnAW2v6QCwJaSspi+ldg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-pf1-f176.google.com) smtp.remote-ip=209.85.210.176; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1618326119; bh=x7agK3VED5BV80DKdIt8CZmXq3+0MK88qrmEM3RJvmw=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:DKIM-Signature:DKIM-Signature; b=SKpfx9tL7zBXzA0/4LRdh7rwHcmvBbAKcRLozWNmhk/z+l3/cVLMufsl5tHvhIDahd3klhuMDD nWtot/rttLDjxhHJ+Z1+DR7YVFgVzr51UAvW3HaFsJ2TGXUNngLPQaM4Pcn+AbsVsPrCXCtvcf utOMO6L71tUj8elRGsGqyjsNg2FD6IFtOOUtgn5veFFEA3id1cPKM3DaUPCFBknXwocNibNBmx 5pgqTUn2sXY0i+At8ZxZRoOTslx09xzsK14/JE04vynMWjcDDNdxlx83Qcjsrhz743kMFvnupE ig+93kmQ71Ez4CinBaEf3TJqt1KVUz5RVPwN1oUBAkHKHA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=6GklWQRta+GFGKpp4LQA4Al8niLbpYqwg+cSlYzlugA=; b=FFjwdoYexMN5KWAWzNKumRZqcS ApjVTlQb0QB+n4/pi0UGOVRk6caVJGo1AvNPotWzLFByIKz2b8HJCuAVYS117KSlJ76ku2FfdaiyZ ucIlJBkosQSjL3dv8bs+gFzif2jHXYEkKRPcFRd4JfYmpYSmL4j2SiNA/bw6J3T60jI2c5wyHOnGj Hg64aa3C6OESofWRqEdVkA1CW/TLfRJdYX32OQDwcdJYNRCQDITnKPrkUrxGB69YQgTcDjLCSubtA mpkWcyWNq4X5ilduRaSziOtTndfjdrJJMCGHoCM7uHxj64ruiw0Ojj54D/MHkkZh9boO1DZBZ657n IK9/R/vQ==; Received: from authenticated user by zero.zsh.org with local id 1lWKYB-00050k-OW; Tue, 13 Apr 2021 15:01:59 +0000 Authentication-Results: zsh.org; iprev=pass (mail-pf1-f176.google.com) smtp.remote-ip=209.85.210.176; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-pf1-f176.google.com ([209.85.210.176]:37760) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1lWKXx-0004lY-2i; Tue, 13 Apr 2021 15:01:45 +0000 Received: by mail-pf1-f176.google.com with SMTP id o123so11599471pfb.4; Tue, 13 Apr 2021 08:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6GklWQRta+GFGKpp4LQA4Al8niLbpYqwg+cSlYzlugA=; b=KrutgH4UwFZWaoMgAzMZ4kjhH3Z/E6msb+sktEN2lrN0E6f1n8P5tB7qB91mGRNn64 gyVPaOGRxCOddlezcbJFf12fqywDZODX2r1ljz/qFa7m1L72Bo+dcvtpBdrynHnkuU9R +Gf36Lc5OfuCSqlQbOWQCFwJVCbDPdnPUQQEmB5Fb7MYMzsE25QgSGme9B8Pf+mTrV/0 v1rIW/ev1hP2G9v5iXv7Z5kiw3Saha7VsLX/cjlZLMGx2NQCSnj6kx9wrtkc+/2b6B+0 B5Ynyw+n6gUYENjfo+fYujcgoreSr6kqMyFOA2/Ljp4dprxDC6mu8g+k/tlgGmqTXUhu jNKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6GklWQRta+GFGKpp4LQA4Al8niLbpYqwg+cSlYzlugA=; b=o3+BZ0fBCtWZQlqqmjTQSxRblTkGnTx21aozIUvRAQgfS2BpseEte6RkhUlI8725bI ycjxL+ZmEtTNAxJqG30rulKLxTY0yef2TSz6Z3QkT5XRfEaZBZpzevdK+YeXLufB7x/H th9TwKOapjfskZI+wHpUCxhwl9opOTe4tCtEtu3T7ofx2dZAPfFNJQZ5Zr6+s/VyEuil bKKZ5SBGAk5oAYXk0IjN4L6dyluPAcciatcajN3cg/S0rBlJHiRbFpmXKSvdUX9CrA6f 8SSuuriFFvN4pLHRbR40AdFOZj73443XS0QXDH1tUksVnS/KZEC7FafpeXQnPMAVOYZq kXBA== X-Gm-Message-State: AOAM530ovu0X1zHCMBXmt8yDS3SL8rNjDMuS7LlAg4qytiiaRjVaTn2s vufeOpkWIJwKBXJCJhd2OEbJSoCD1aw/Mg== X-Google-Smtp-Source: ABdhPJyZBoX3k+GBMBVC6Lt1RHLdWF5lcDC6WyEgmOXdt5xH3KQnozZUTUNC9/XNRob87X3lP8OzUQ== X-Received: by 2002:aa7:8493:0:b029:1ee:75b2:2865 with SMTP id u19-20020aa784930000b02901ee75b22865mr29328133pfn.61.1618326103716; Tue, 13 Apr 2021 08:01:43 -0700 (PDT) Received: from localhost ([61.6.230.115]) by smtp.gmail.com with ESMTPSA id 192sm13615289pfz.16.2021.04.13.08.01.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Apr 2021 08:01:42 -0700 (PDT) Date: Tue, 13 Apr 2021 23:01:37 +0800 From: Tim Lee To: Daniel Shahaf Cc: Lawrence =?utf-8?Q?Vel=C3=A1zquez?= , zsh-workers@zsh.org Subject: Re: [PATCH] Improve vcs_info example for ahead/behind git commits Message-ID: <20210413150137.akartr6ngiwaa3o7@localhost> References: <20210328213628.7rwz62bq5p2isd6b@home-guest> <20210329070611.GM18178@tarpaulin.shahaf.local2> <20210329093056.fegqam75id4yfkiq@home-guest> <20210329103927.qzky3fyevptfflvj@home-guest> <1b0343d9-87c2-4a0d-860f-30a390d7034d@www.fastmail.com> <87d2c775-18f3-4664-9a3f-de62f5b71777@www.fastmail.com> <20210413113441.GD6819@tarpaulin.shahaf.local2> <20210413115830.5wogi3e7dh2tthmw@localhost> <20210413140139.GK6819@tarpaulin.shahaf.local2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210413140139.GK6819@tarpaulin.shahaf.local2> X-Seq: 48533 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: > Thanks, applied, and here's a patch series for implementing the other > outstanding points. Would you review it, please? See anything that > could go wrong, or that's missing? Looks good to me. I would use this myself. However, you should take my review with a grain of salt.