From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 15584 invoked from network); 13 Apr 2021 15:53:22 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 13 Apr 2021 15:53:22 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1618329202; b=oakDq20+XHDHfosTHOSG24/0jfLiAv/XKYV6yPnJFANZ2h+w6M5bIchFvjLmPTTOMIWjuQKrSm ftHAoMpv2qbWR9+yCue1dJUCbe5nE5HgeJweavKlr2TNVUZn56KMuFZSm9LauVL07tT2m25OcV ckcq+SBgYfQQVXflhrtNbn834XwcvG97Bs9u/KJS4viH5oeeflVyHJ2RI+ruuJGqfNq5F8Ymne ZDYENb0w6FKYG771sHgX9NGNDSUOmpNOrhPX/pVFJjuBM5gRBJe6pH5RfdhR+d2/Mgdw5L+Hb5 PViXqCaFikkZsKZP8mT1N6O93JNGDGWUHGoVrRDDgk/Idg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1618329202; bh=opZ/AAMlgk3yXlOb0mixc+nzyrLJ+ExYj7bglFCxJsI=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=gyeUn9Dh4uuRMN+xSGBuWx5RvyEsUaqyA9HEtapaJrVBmJaxGhceBM4RcQ3SdfWEVDjo22f8At FvD5a1OkOsjsShXPDWDyymjXXG5mvlt6h+K35PFWH2QicCaq3Y4b7w75g8aTniuN+tLeSgRD6G ZOwUJEiVSQBjZ1sQeHR9AI6DfCb377xULVBUY+HHoP+TSKVcK4Re0fXkeAiHiXWnwG75vGkjAy tS2q/9Ax2ff2awXB5cJ12k5CF1Pd8Ah/WNP249+LhXpPvgLUcPcwv/8WHp5OYxTKl5+/41REa/ kojmo5pvUshjlv958Av9tMjN/Cz4dCSaczj67FPAXVQxhg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID; bh=uqSl3L5zMlYpkyMEI1a/ZVXrhkGttRfwSsUwHtbqtaE=; b=FjxHZ/5UDBVasA1qHlBA28s8AS 0IBDINaLZPS1oncJGUmtL0hfYe9hG+R16kCUKTu+gcxHm1BLDLpUzsyZxEvQJWqP4Tz/Jkgmd2GtF MvXpwhTqIZ7xplVw9TVm07DHiP/Y/kvv1b1B3W79lcN1BENGC/chob8jOlmGjIPB16K2oPT9vFy0e p9qCsryJcnpK9csiM3Y+codxd/0KbbP/B2iUxzJ7ozBOj6NieOb5jEBbiB/G6dIVAWsox2ZRG2kZu aW98w/DKFnK7zZXPtACGiSGD49r6H7Q5AH+GqH3FSYNqZMvMVo+N+5i9OPyKu0hNjrOYSzosiHtIM L9ndMMZQ==; Received: from authenticated user by zero.zsh.org with local id 1lWLLq-000753-PR; Tue, 13 Apr 2021 15:53:18 +0000 Authentication-Results: zsh.org; iprev=pass (out2-smtp.messagingengine.com) smtp.remote-ip=66.111.4.26; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from out2-smtp.messagingengine.com ([66.111.4.26]:35589) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lWLLV-0006ov-JB; Tue, 13 Apr 2021 15:52:59 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 54B585C01A8; Tue, 13 Apr 2021 11:52:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 13 Apr 2021 11:52:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm3; bh=uqSl3L5zMlYpkyMEI1a/ZVXrhkGttRfwSsUwHtbq taE=; b=n1jtuJq7ijpJ/qSjF1ZOUonCX/V53DxN+Lp7rEeoy1nl/Q47V8znmqH8 Jqg7eIDTSQb0KbNm4isblUGa82F7u4P0aYNlssqOEQLB67bnXahj6YO7hfiJqeur kyApxu5FbBFGW6/3XUuhEDFBNL8IBvi9KBKaC/gMVal0c12joghG41H0UZDb3vL2 HaOL2UXGa3z5sX7iFqhbQa3tFUWkKDExW8JWnCvoMkRoy8Zf9WZrRrooJLQNGQby aHTLFPqso+IPPzXKA09dmN6i9tMNRlOyLALvXcS4m4jNO3hTnKsfV2i7PuVJiAQd HBWYrhNjQagRV6H9LE/SK6Rd9XUfJw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=uqSl3L5zMlYpkyMEI1a/ZVXrhkGttRfwSsUwHtbqt aE=; b=vFR4JDDA6o0uME6dmmO76OAAXOGXwgdfHjwfq3qtYKpWJWtSWAPNt847i F2SRXbyBPA+G26MnRM6FRginBauApPjA/NZ2uk1pWL+i6r8sB8pFjQMhogiVni7Y kDqthJZQSQ2ZmeOmonXOsbsedK86WA6tvLc6HjxQjM0+KQiMg+SDRWreDOQJ3eLK bdFkGyITkIKvyXYaLFKQIjpSfkh2RqwUoVLXFkYcDhLYDVNFBJGety5x7vxcqEXb eZ/Z8tOi22va5ST2nEjrDOyFhx1i3cC6PeLh6QdJIz0I9gHu3BfWb1o41fIsrZYb 27SpA3gldSan99twVT7M3ub72xh3Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekledgleefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggugfgjfgesth ektddttderudenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghn ihgvlhdrshhhrghhrghfrdhnrghmvgeqnecuggftrfgrthhtvghrnhepgfelhedtffeuhf egueelfeffjeegtddtleehvddvueeihfevgfdvgffhvedvkeetnecukfhppedutdelrdei iedrieefrddvfedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepugdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-109-66-63-230.red.bezeqint.net [109.66.63.230]) by mail.messagingengine.com (Postfix) with ESMTPA id 7B22F1080057; Tue, 13 Apr 2021 11:52:38 -0400 (EDT) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 4FKVVX2cRFzn9; Tue, 13 Apr 2021 15:52:36 +0000 (UTC) Date: Tue, 13 Apr 2021 15:52:36 +0000 From: Daniel Shahaf To: zeurkous@volny.cz Cc: zsh-workers@zsh.org Subject: Re: patch: zshmisc(1) clarify non-successful exit statuses Message-ID: <20210413155236.GR6819@tarpaulin.shahaf.local2> References: <20210411141520.4ABA89D5@volny.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210411141520.4ABA89D5@volny.cz> User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 48535 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Thanks for the patch. Review: zeurkous@volny.cz wrote on Sun, Apr 11, 2021 at 14:15:20 +0200: > #?patch > # What's this header line? Is this a standard format for unidiffs with log messages? Should Functions/VCS_Info/VCS_INFO_patch2subject grow support for it? zsh's source code is in git. git's interchange format is `[PATCH]' in the subject line, then in the body, everything up to a "---" line is part of the log message, and everything after is not. See git-format-patch(1) for details. More below. > # These patches add, to the zshmisc(1) manual page, clarity about the > # exit status on exec failure. > # > # Me understands that, strictly considered, only Doc/Zsh/exec.yo needs > # updating; however, as me doesn't have yodl, me updated Doc/zshmisc.1 > # as well. Thanks, but there's no need to manually update the .1 files; they aren't in version control. > # Hope this is useful (it is to me), > # > # --zeurkous, Sun Apr 11 11:12:21 UTC 2021. > # > --- Doc/Zsh/..v/5.8/exec.yo Mon Dec 4 14:09:35 2017 > +++ Doc/Zsh/exec.yo Sun Apr 11 10:42:15 2021 > @@ -16,7 +16,10 @@ > Otherwise, the shell searches each element of tt($path) for a > directory containing an executable file by that name. If the > search is unsuccessful, the shell prints an error message and returns > -a nonzero exit status. > +127. > + > +If execution fails because of insufficient permissions, or because the > +file is a directory, the shell prints an error message and returns 126. > Does this sentence cover every possible case of returning 126? The condition in the source is «== EACCES || == ENOEXEC». Moreover, the very next sentence says "the file is not in executable format", and it would be odd to refer to the same condition by different noun phrases in two consecutive sentences. I don't like the newly-added paragraph break. Anyone who stops reading at the end of that paragraph will think the return code is 127, period. Also, stating the return values before going on to say that if the file isn't a directory then it's exeuted anyway could be confusing, couldn't it? Should this part of the manual mention the AUTO_CD option? A few paragraph below the value, 127, is mentioned again. Does that sentence need to be updated? Thanks for the patch! I realize the review is actually longer than the patch, but, it's still shorter than the cumulative number of times the new text will be read. Cheers, Daniel > If execution fails because the file is not in executable format, > and the file is not a directory, it is assumed to be a shell >