From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 962 invoked from network); 14 Apr 2021 12:52:18 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 14 Apr 2021 12:52:18 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1618404738; b=HrJD8Yr8FZP3gTP1OoBpQsM7vk5+s2tV2MxQDgodYkk74pRJ12eu2iY3vXAfsXgoA1lHGGaRSw UGI4McEu1cuXrb8/pvEIl3FFle2Dli1o52gpd/MEqVioLibgtE5bO3T/yzXFcxEldVjxXGmhSI UBOKkftIOWbz0g9ZsA+MvKGx9gaYOT/o79zo5dDFWM8qougKiC6hZhDbiJH/L3LxEX8evVpioz P+XiAr6D9tNJp7M9sRExdIIdQgYFPu1H/+t6fxqp20ayFDYP3VpMyvrDg/LJcMMDDNX7S11wF1 MdWA8sQEGqwWybNjmc0i6fWbu/0qgobFhkL5TycGW8uX7A==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (wout5-smtp.messagingengine.com) smtp.remote-ip=64.147.123.21; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1618404738; bh=c8IFvkrLAaY+AtwmNgy4HElymJLNasHazNtpmFG4wvw=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:To:From:Date:DKIM-Signature: DKIM-Signature:DKIM-Signature; b=hcz27F5uRVleJQEpa7J8fjpVixkaI3Xs8Rt+YbHw3doKufuYGLDIs4smtrpd+CL4ElAZfMOO4k 2HUsB9oiNsdw6cZZ3AdGDvmmL1cBi4N5wCc7offp7CFjxzRHJmsnsZ9/3IJMA6XkSKiGD7l7m4 Cyv0ySW99mlIxReZ/Iqq4cLA6fWxyxcq4LkKyDqsWCmrBb8Cj3XfiXHyQEicR0pNiZHG8ErgbR PzL5/+hvckFEC/vA9B839iDYpcfEVx+XwZGg3F37yJXPdK/YvOHuXY709hlptp65abegwib4cA GY90SEEDdVex3LvO3h/LOiOlxQbtoBZCJzICCTtI2wOYOw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=9Z+8O4QVLSr0eSUFYBfofr0uqtox00Y5pXrf1LJLtmY=; b=FKqgRwdN/TnaSJebqUo8exhnC3 pQXa6H6rRBWZL0rWLZkudBgeO7hNzMm6L16y2x2h+MGerPYFsbSDlQcDgxiUzOy62Sk5cUlR3F7nV bQWU72RgFiYx2k8b1ppeOVguQ18yTbBKv7Dz1YIHtxc0VTSEWa9NDQMp5Kp1B1x3Na+U7cS90NnDn 2vX4hE9tcvTfsXbLR9LQCy8OJFJTtJa4O38gC7kLP9Rlvqfi6JaWtF5xMLjSPFoTM14g3WlcUoVen zs0FBAISEcGmnmCmtygnJcg8yS0q0DLJDog8/7Hhz5BC3tpAQQleQkSSwNI2yIacBp4mHNqhXKTGu jXzw0Csg==; Received: from authenticated user by zero.zsh.org with local id 1lWf0D-0001VU-Tn; Wed, 14 Apr 2021 12:52:18 +0000 Authentication-Results: zsh.org; iprev=pass (wout5-smtp.messagingengine.com) smtp.remote-ip=64.147.123.21; dkim=pass header.d=daniel.shahaf.name header.s=fm3 header.a=rsa-sha256; dkim=pass header.d=messagingengine.com header.s=fm2 header.a=rsa-sha256; dmarc=none header.from=daniel.shahaf.name; arc=none Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:54623) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1lWf01-0001I5-Jk; Wed, 14 Apr 2021 12:52:06 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id E444818FB; Wed, 14 Apr 2021 08:52:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 14 Apr 2021 08:52:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:subject:message-id:references :mime-version:content-type:content-transfer-encoding :in-reply-to; s=fm3; bh=9Z+8O4QVLSr0eSUFYBfofr0uqtox00Y5pXrf1LJL tmY=; b=NdeT6uov394nVPQf3WnNyjYp9//a9YF2RIspe7B1u6QTVBGNKWzKznnI jrbVPx8n+mUnFlj8Nw9QQoSHE04xzUgFHtjTzdHcoGGpb2vr5gm+gRl5JLMJf5UL ufSY4iGBtu+CrgO59ghYjR4S30Eghx3Ci1xs+3Yy99/ImaKC3B6WQKil6v7+bHeM J5vm4DmE+wNvnJK08f94YAqgHn2rn7hSS8zHhfFWdacBm8Zzlcpg/pa4nE2rxiaY tehYWONmE7Fmt8VuzTbFW8QXhlqZ3Vpfahdkw/fcCD1YqOykqqfWXmTBng9dOuCG JTELBA4Rq7eIUfkmemgkxUFC703PEA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=9Z+8O4QVLSr0eSUFYBfofr0uqtox00Y5pXrf1LJLt mY=; b=WphXgPAENPUYtSbC3AvBBvjdnbPTLOwIgZhXZbn2MVn2SiypziIab4ZDI KA5Xcg6floFWGSvorJqZwIk7JeBMPh1WUN12ONf2VwPBkCUeU43hLK2G6kSqWBap zkiuqhd4uJEIKzwt4kVwl+jLEU/tfAe3s7Jyw4+xS/u0+nCczDLi2NH+cm6xCjke Fwrw0zj+RmyT8k2+gG8hAz03oTbKl1hstoCnPRL2XGQp/kUH+rVTGmceK8ZAEz8z fwqF2X7A4USpsGhYQKEVL/A60wPmzvQXAxGfKHvCwyTSTe6PDALTeNL3Z/WdTUyf upPBTCq0ttezeaByR6nWogj4z/h6A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudeluddgheejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggugfgjfgesth ektddttderudenucfhrhhomhepffgrnhhivghlucfuhhgrhhgrfhcuoegurdhssegurghn ihgvlhdrshhhrghhrghfrdhnrghmvgeqnecuggftrfgrthhtvghrnhepgfelhedtffeuhf egueelfeffjeegtddtleehvddvueeihfevgfdvgffhvedvkeetnecukfhppedutdelrdei iedrieefrddvfedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepugdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgv X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-109-66-63-230.red.bezeqint.net [109.66.63.230]) by mail.messagingengine.com (Postfix) with ESMTPA id D452C1080068 for ; Wed, 14 Apr 2021 08:52:02 -0400 (EDT) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1000) id 4FL2Rj1Ttmz43s; Wed, 14 Apr 2021 12:52:01 +0000 (UTC) Date: Wed, 14 Apr 2021 12:52:01 +0000 From: Daniel Shahaf To: zsh-workers@zsh.org Subject: Re: Patch bumping (was Re: Feature Patch: Use completion to view parameter values) Message-ID: <20210414125201.GD3882@tarpaulin.shahaf.local2> References: <20210413133524.GJ6819@tarpaulin.shahaf.local2> <2EE1CCA0-E8C3-4A9F-898B-F823890EA58C@zsh.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2EE1CCA0-E8C3-4A9F-898B-F823890EA58C@zsh.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Seq: 48566 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Lawrence Velázquez wrote on Tue, Apr 13, 2021 at 17:31:30 -0400: > On Apr 13, 2021, at 9:35 AM, Daniel Shahaf wrote: > > Regarding your taxonomy, would it be accurate to say that in cases > > A and B a submitted patch is awaiting resolution, whereas in case C it's > > generally a design question that's awaiting resolution? In A+B the > > person in question is the patch submitter; in C the person in question > > is probably a regular developer. > > Many type C discussions are just a committer saying "I'm thinking > about committing this, what does everyone think?" and then waiting > on any feedback, from nitpicks to overarching design critique. In these, I think it matters whether the "this" referred to is the committer's work or a patch submitter's work. In the latter case, it's essentially case A again. > > (Aside: Note the terminology: "developer", not "committer", since in > > general, distinctions between people who do and don't have commit access > > shouldn't be made, except when it's necessary to actually invoke «git > > push».¹) > > Sure, but commit access is relevant to patch discussions involving > noncommitting contributors (types A and B) because the commit step > is often the only thing holding things up. Personally, I don't recall that many threads ending with "the patch LGTM, just need to push it when I'll get home" or similar. > > No comment from me on case C. > > Should I continue bumping developer-only patch discussions at all? > If so, I'm inclined to let them simmer for longer -- perhaps a month > (as per workers/48516). I feel pretty pesky basically reminding > committers to commit their own patches, but everyone forgets things > now and then. Is it helpful or annoying? Personally, I keep on my todo list patches I've posted, but not patches I've reviewed or random ideas I've floated. I suspect that in general reminders would be helpful when a patch submission requests feedback/comments/reviews or asks a question. Cheers, Daniel